MainNavDirections isn't imported in generated classes [123307342]

Fixed

Bug

Status Update

No update yet.

Description

bo...@gmail.com

created issue #1

Jan 23, 2019 10:15PM

Component used: Navigation
Version used: 1.0.0-alpha01
Devices/Android versions reproduced on: N/A – compilation/build issue

If this is a bug in the library, we would appreciate if you could attach:
- Sample project to trigger the issue.
- A screenrecord or screenshots showing the issue (if UI related).

Steps to reproduce:
- Add a global action to a fragment that's in a different package than the main app package

MainNavNoImport.zip

836 KB

Download

Comments

il...@google.com <il...@google.com> #2Jan 23, 2019 10:21PM

Assigned to da...@google.com.

The removal of the nested graphs and using popUpTo the given fragment appears to prevent the crash from happening in 1.0.0-alpha11.

ap...@google.com <ap...@google.com> #3Jan 24, 2019 12:12AM

Project: platform/prebuilts/androidx/internal
Branch: androidx-master-dev

commit 63bc1ff1fe7c348138295ee7efb8cdc2999622c0
Author: Ian Lake <ilake@google.com>
Date: Sun Feb 03 15:18:53 2019

Update prebuilts for Navigation 1.0.0-beta01

Include fix for

b/123803044

Test: ./gradlew bOS
Change-Id: Icb2a50975541a7bd3327054c72a591c7689c9741

M android/arch/navigation/navigation-common/1.0.0-beta01/navigation-common-1.0.0-beta01.aar
M android/arch/navigation/navigation-common/1.0.0-beta01/navigation-common-1.0.0-beta01.aar.md5
M android/arch/navigation/navigation-common/1.0.0-beta01/navigation-common-1.0.0-beta01.aar.sha1
M android/arch/navigation/navigation-fragment/1.0.0-beta01/navigation-fragment-1.0.0-beta01-sources.jar
M android/arch/navigation/navigation-fragment/1.0.0-beta01/navigation-fragment-1.0.0-beta01-sources.jar.md5
M android/arch/navigation/navigation-fragment/1.0.0-beta01/navigation-fragment-1.0.0-beta01-sources.jar.sha1
M android/arch/navigation/navigation-fragment/1.0.0-beta01/navigation-fragment-1.0.0-beta01.aar
M android/arch/navigation/navigation-fragment/1.0.0-beta01/navigation-fragment-1.0.0-beta01.aar.md5
M android/arch/navigation/navigation-fragment/1.0.0-beta01/navigation-fragment-1.0.0-beta01.aar.sha1
M android/arch/navigation/navigation-runtime/1.0.0-beta01/navigation-runtime-1.0.0-beta01.aar
M android/arch/navigation/navigation-runtime/1.0.0-beta01/navigation-runtime-1.0.0-beta01.aar.md5
M android/arch/navigation/navigation-runtime/1.0.0-beta01/navigation-runtime-1.0.0-beta01.aar.sha1
M android/arch/navigation/navigation-ui/1.0.0-beta01/navigation-ui-1.0.0-beta01.aar
M android/arch/navigation/navigation-ui/1.0.0-beta01/navigation-ui-1.0.0-beta01.aar.md5
M android/arch/navigation/navigation-ui/1.0.0-beta01/navigation-ui-1.0.0-beta01.aar.sha1

https://android-review.googlesource.com/892878

https://goto.google.com/android-sha1/63bc1ff1fe7c348138295ee7efb8cdc2999622c0

il...@google.com <il...@google.com> Jan 24, 2019 12:21AM

Marked as fixed.

[Deleted User] <[Deleted User]> #4Jan 24, 2019 07:35AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c775e5d1ae2ab4b194ee3c0f18523c603cf4d6ec
Author: Ian Lake <ilake@google.com>
Date: Sun Feb 03 15:04:21 2019

Return true when popping from FragmentNavigator

Since NavController only updates its back stack when
a Navigator returns true from popBackStack(), ensure
that all updates to the FragmentNavigator's back stack
(i.e., calling removeLast()) are paired with returning
true from popBackStack().

This ensures that the FragmentManager state and the
NavController states don't get out of sync.

Test: Updated FragmentNavigatorTest test
Test: tested in sample app from bug
BUG: 123803044
Change-Id: I8cfc87cba0a0369b5ae5c3ac610e31b5556ba04e

M navigation/fragment/src/androidTest/java/androidx/navigation/fragment/FragmentNavigatorTest.kt
M navigation/fragment/src/main/java/androidx/navigation/fragment/FragmentNavigator.java

https://android-review.googlesource.com/892996

https://goto.google.com/android-sha1/c775e5d1ae2ab4b194ee3c0f18523c603cf4d6ec

[Deleted User] <[Deleted User]> #5Jan 24, 2019 04:18PM

This is actually an issue where the NavController's back stack state is going out of sync with the FragmentManager / FragmentNavigator's state. This has been fixed and will be available in the next release.

il...@google.com <il...@google.com> #6Jan 24, 2019 05:13PM

Nice job! A quick response!

[Deleted User] <[Deleted User]> #7Jan 24, 2019 08:05PM

I still get this error using the lastest 1.0.0 release :

implementation 'android.arch.navigation:navigation-fragment-ktx:1.0.0'
implementation "android.arch.navigation:navigation-ui-ktx:1.0.0"

I'm using nested graphs.

pe...@gmail.com <pe...@gmail.com> #8Jan 25, 2019 07:57PM

Re #7 - please file a new bug with a sample app that reproduces your issue.

co...@gmail.com <co...@gmail.com> #9Aug 6, 2024 09:03AM

Done.

https://issuetracker.google.com/131733658

co...@gmail.com <co...@gmail.com> #10Aug 7, 2024 04:32PM

It sounds like you are dealing with a coding issue, possibly in a web development or React project. If MainNavDirections isn't being imported in generated classes, you may need to explicitly import it in your files. If you provide more specific details about your setup and the context https://www.exploria.pk/tours/hunza-tour-packages/ in which MainNavDirections is used, I can offer more targeted assistance.

sa...@gmail.com <sa...@gmail.com> #11Jan 23, 2025 06:52AM

Comment has been deleted.

Message last modified on Jan 23, 2025 05:02PM