MainNavDirections isn't imported in generated classes [123307342]

Fixed

Bug

Status Update

No update yet.

Description

bo...@gmail.com

created issue #1

Jan 23, 2019 10:15PM

Component used: Navigation
Version used: 1.0.0-alpha01
Devices/Android versions reproduced on: N/A – compilation/build issue

If this is a bug in the library, we would appreciate if you could attach:
- Sample project to trigger the issue.
- A screenrecord or screenshots showing the issue (if UI related).

Steps to reproduce:
- Add a global action to a fragment that's in a different package than the main app package

MainNavNoImport.zip

836 KB

Download

Comments

il...@google.com <il...@google.com> #2Jan 23, 2019 10:21PM

Assigned to da...@google.com.

alpha01? That's so old! :D

We've found the issue in alpha10 and are working on a fix.

ap...@google.com <ap...@google.com> #3Jan 24, 2019 12:12AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 37ed64d4de87bd4a4365f5c0dfee7b33c8043013
Author: Daniel Santiago Rivera <danysantiago@google.com>
Date: Wed Jan 23 15:46:00 2019

Add missing import of parent Directions class in generated Safe Args.

When generating a parent direction action method in a child directions
class,correctly import the parent direction if its located in another
package. Both JavaPoet and KotlinPoet generate import statements but the
NavWriters were incorrectly creating the class name of the parent type,
specifically it missed the package name which caused the import to be
missing.

Bug: 123307342
Test: ./gradlew navigation:navigation-safe-args-gradle-plugin:test \
navigation:navigation-safe-args-generator:test

Change-Id: Ibeda7a7ec6f31bb1c860dfe1f5cd2a7e7ea6d47d

M navigation/safe-args-generator/src/main/kotlin/androidx/navigation/safe/args/generator/java/JavaNavWriter.kt
M navigation/safe-args-generator/src/main/kotlin/androidx/navigation/safe/args/generator/kotlin/KotlinNavWriter.kt
M navigation/safe-args-generator/src/tests/kotlin/androidx/navigation/safe/args/generator/NavGeneratorTest.kt
M navigation/safe-args-generator/src/tests/kotlin/androidx/navigation/safe/args/generator/NavParserTest.kt
M navigation/safe-args-generator/src/tests/test-data/expected/nav_generator_test/java/nested/LoginFragmentDirections.java
M navigation/safe-args-generator/src/tests/test-data/expected/nav_generator_test/java/nested/RegisterFragmentDirections.java
M navigation/safe-args-generator/src/tests/test-data/expected/nav_generator_test/java/nested_overridden_action/InnerSettingsFragmentDirections.java
M navigation/safe-args-generator/src/tests/test-data/expected/nav_generator_test/java/nested_overridden_action/SettingsFragmentDirections.java
M navigation/safe-args-generator/src/tests/test-data/expected/nav_generator_test/kotlin/nested/LoginFragmentDirections.kt
M navigation/safe-args-generator/src/tests/test-data/expected/nav_generator_test/kotlin/nested/RegisterFragmentDirections.kt
M navigation/safe-args-generator/src/tests/test-data/expected/nav_generator_test/kotlin/nested_overridden_action/InnerSettingsFragmentDirections.kt
M navigation/safe-args-generator/src/tests/test-data/expected/nav_generator_test/kotlin/nested_overridden_action/SettingsFragmentDirections.kt
M navigation/safe-args-generator/src/tests/test-data/nested_login_test.xml
M navigation/safe-args-gradle-plugin/src/test/test-data/app-project-kotlin/src/main/res/navigation/nav_nested_test.xml
A navigation/safe-args-gradle-plugin/src/test/test-data/app-project/src/main/res/navigation/nav_nested_test.xml

https://android-review.googlesource.com/883592

https://goto.google.com/android-sha1/37ed64d4de87bd4a4365f5c0dfee7b33c8043013

il...@google.com <il...@google.com> Jan 24, 2019 12:21AM

Marked as fixed.

[Deleted User] <[Deleted User]> #4Jan 24, 2019 07:35AM

Hi, I'm still having the issue with 1.0.0-alpha11. Generated classes for fragments in nested navigation throws error for global actions.

[Deleted User] <[Deleted User]> #5Jan 24, 2019 04:18PM

I am also having the issue with 1.0.0-alpha11. I'm going to see what the Kotlin generator does with this.

il...@google.com <il...@google.com> #6Jan 24, 2019 05:13PM

Re #4 and #5 - please file a new bug with a sample project that reproduces your issue.

[Deleted User] <[Deleted User]> #7Jan 24, 2019 08:05PM

Re #6 will do. I think it has to do with naming arguments with capital first letters but I'll see if I can make a minimal example app to demonstrate, as a new bug.

pe...@gmail.com <pe...@gmail.com> #8Jan 25, 2019 07:57PM

How do i fix this?

co...@gmail.com <co...@gmail.com> #9Aug 6, 2024 09:03AM

If you're working with Jetpack Navigation in Android and the generated classes don't import MainNavDirections, it usually points to an issue with your setup or the https://lillestromflytt.no/lager-lillestrom/ navigation component.If after all these steps the issue persists, consider invalidating caches and restarting Android Studio (File > Invalidate Caches / Restart), as sometimes cached data can cause problems with code generation.

co...@gmail.com <co...@gmail.com> #10Aug 7, 2024 04:32PM

It sounds like you are dealing with a coding issue, possibly in a web development or React project. If MainNavDirections isn't being imported in generated classes, you may need to explicitly import it in your files. If you provide more specific details about your setup and the context https://www.exploria.pk/tours/hunza-tour-packages/ in which MainNavDirections is used, I can offer more targeted assistance.

sa...@gmail.com <sa...@gmail.com> #11Jan 23, 2025 06:52AM

Comment has been deleted.

Message last modified on Jan 23, 2025 05:02PM