WorkManager's OneTimeWorkRequest stays in enqueued state indefinitely. [123329850]

Fixed

Bug

Status Update

No update yet.

Description

ar...@gmail.com

created issue #1

Jan 24, 2019 11:23AM

Component used: WorkManager
Version used: 1.0.0-beta02
Devices/Android versions reproduced on: Pixel/Pie, Pixel2/Pie, Pixel3/Pie, Motorola Moto-G/Lollipop

Steps to reproduce:
Create a OneTimeWorkRequest like below, while it's running, close the app from app drawer. The first assumption that the enqueued task will run in background even when the app is closed is not true (Task is not started again even after an hour). Also the enqueued OneTimeWorkRequest won't start again on next app launch and stays in ENQUEUED state indefinitely.

private void startTestWork() {
Constraints testConstraints = new Constraints.Builder()
.setRequiredNetworkType(NetworkType.CONNECTED)
.setRequiresBatteryNotLow(true)
.build();
isMyWorkerRunning(TEST_WORKER_TAG);
OneTimeWorkRequest testOneTimeWorkRequest = new OneTimeWorkRequest
.Builder(TestWorker.class)
.addTag(TEST_WORKER_TAG)
.setInitialDelay(0, TimeUnit.SECONDS)
.setConstraints(testConstraints)
.build();
WorkManager.getInstance().enqueueUniqueWork(TEST_WORKER_TAG, ExistingWorkPolicy.KEEP,
testOneTimeWorkRequest);
}

Comments

ra...@google.com <ra...@google.com> #2Jan 24, 2019 06:09PM

Status: Duplicate of

123211993

alpha01? That's so old! :D

We've found the issue in alpha10 and are working on a fix.

ra...@google.com <ra...@google.com> #3Jan 24, 2019 06:09PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 37ed64d4de87bd4a4365f5c0dfee7b33c8043013
Author: Daniel Santiago Rivera <danysantiago@google.com>
Date: Wed Jan 23 15:46:00 2019

Add missing import of parent Directions class in generated Safe Args.

When generating a parent direction action method in a child directions
class,correctly import the parent direction if its located in another
package. Both JavaPoet and KotlinPoet generate import statements but the
NavWriters were incorrectly creating the class name of the parent type,
specifically it missed the package name which caused the import to be
missing.

Bug: 123307342
Test: ./gradlew navigation:navigation-safe-args-gradle-plugin:test \
navigation:navigation-safe-args-generator:test

Change-Id: Ibeda7a7ec6f31bb1c860dfe1f5cd2a7e7ea6d47d

M navigation/safe-args-generator/src/main/kotlin/androidx/navigation/safe/args/generator/java/JavaNavWriter.kt
M navigation/safe-args-generator/src/main/kotlin/androidx/navigation/safe/args/generator/kotlin/KotlinNavWriter.kt
M navigation/safe-args-generator/src/tests/kotlin/androidx/navigation/safe/args/generator/NavGeneratorTest.kt
M navigation/safe-args-generator/src/tests/kotlin/androidx/navigation/safe/args/generator/NavParserTest.kt
M navigation/safe-args-generator/src/tests/test-data/expected/nav_generator_test/java/nested/LoginFragmentDirections.java
M navigation/safe-args-generator/src/tests/test-data/expected/nav_generator_test/java/nested/RegisterFragmentDirections.java
M navigation/safe-args-generator/src/tests/test-data/expected/nav_generator_test/java/nested_overridden_action/InnerSettingsFragmentDirections.java
M navigation/safe-args-generator/src/tests/test-data/expected/nav_generator_test/java/nested_overridden_action/SettingsFragmentDirections.java
M navigation/safe-args-generator/src/tests/test-data/expected/nav_generator_test/kotlin/nested/LoginFragmentDirections.kt
M navigation/safe-args-generator/src/tests/test-data/expected/nav_generator_test/kotlin/nested/RegisterFragmentDirections.kt
M navigation/safe-args-generator/src/tests/test-data/expected/nav_generator_test/kotlin/nested_overridden_action/InnerSettingsFragmentDirections.kt
M navigation/safe-args-generator/src/tests/test-data/expected/nav_generator_test/kotlin/nested_overridden_action/SettingsFragmentDirections.kt
M navigation/safe-args-generator/src/tests/test-data/nested_login_test.xml
M navigation/safe-args-gradle-plugin/src/test/test-data/app-project-kotlin/src/main/res/navigation/nav_nested_test.xml
A navigation/safe-args-gradle-plugin/src/test/test-data/app-project/src/main/res/navigation/nav_nested_test.xml

https://android-review.googlesource.com/883592

https://goto.google.com/android-sha1/37ed64d4de87bd4a4365f5c0dfee7b33c8043013

ar...@gmail.com <ar...@gmail.com> #4Jan 25, 2019 08:03AM

Hi, I'm still having the issue with 1.0.0-alpha11. Generated classes for fragments in nested navigation throws error for global actions.

ra...@google.com <ra...@google.com> #5Jan 25, 2019 06:24PM

I am also having the issue with 1.0.0-alpha11. I'm going to see what the Kotlin generator does with this.

en...@gmail.com <en...@gmail.com> #6Jan 28, 2019 09:17AM

Re #4 and #5 - please file a new bug with a sample project that reproduces your issue.

ra...@google.com <ra...@google.com> #7Jan 29, 2019 01:04AM

Re #6 will do. I think it has to do with naming arguments with capital first letters but I'll see if I can make a minimal example app to demonstrate, as a new bug.

en...@gmail.com <en...@gmail.com> #8Jan 29, 2019 01:05PM

How do i fix this?

ra...@google.com <ra...@google.com> #9Jan 29, 2019 06:34PM

Assigned to ra...@google.com.

If you're working with Jetpack Navigation in Android and the generated classes don't import MainNavDirections, it usually points to an issue with your setup or the https://lillestromflytt.no/lager-lillestrom/ navigation component.If after all these steps the issue persists, consider invalidating caches and restarting Android Studio (File > Invalidate Caches / Restart), as sometimes cached data can cause problems with code generation.

ra...@google.com <ra...@google.com> #10Jan 29, 2019 06:44PM

It sounds like you are dealing with a coding issue, possibly in a web development or React project. If MainNavDirections isn't being imported in generated classes, you may need to explicitly import it in your files. If you provide more specific details about your setup and the context https://www.exploria.pk/tours/hunza-tour-packages/ in which MainNavDirections is used, I can offer more targeted assistance.

en...@gmail.com <en...@gmail.com> #11Jan 30, 2019 09:07AM

deleted

log-workmanager-repro-verbose-3.txt

22 KB

View

Download

ra...@google.com <ra...@google.com> #12Jan 30, 2019 06:13PM

Thanks for providing more information.. This is in line with a fix that I am working on. This should be fixed in the next beta.

https://android-review.googlesource.com/c/platform/frameworks/support/+/889837

ap...@google.com <ap...@google.com> #13Jan 30, 2019 07:05PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit ebb4f87d732f66d01d1a4cf362bb11a815e80b74
Author: Rahul Ravikumar <rahulrav@google.com>
Date: Tue Jan 29 16:16:17 2019

Correctly retry work on process death when using AlarmManager based implementation.

* AlarmManager now schedules a Worker unless the WorkSpec#isFinished() is true.
* When AlarmManager gets worken up by ActivityManager to resume processing, we
correctly execute the Worker after a backoff period.
* We now correctly handle rescheduling in DelayMetCommandHandler. Previously the
only reason why this worked before was the call to Schedulers.schedule() in
WorkerWrapper inside the onWorkFinished() method.
* When delaying execution of Workers in WorkerWrapper we always reschedule givem
SystemJobScheduler does not schedule jobs where JobScheduler is already aware
of the jobId.
* Added a lot more logging in GreedyScheduler, SystemJobScheduler and SystemAlarmScheduler
to make debugging easier.
* Ran a lot of integration tests on API 22, 23 (double scheduling) and 28.
Look at

https://paste.googleplex.com/5709211287683072?raw
for more information. I also ran integration tests that cancel
workers to sanity check.

Fixes:

b/123329850

Test: Added additional test cases in SystemAlarmDispatcherTest.

Change-Id: I1bcff1ebf5f60928a02e3e94e2e6ccaed0de47b1

M work/integration-tests/testapp/src/main/java/androidx/work/integration/testapp/MainActivity.java
A work/integration-tests/testapp/src/main/java/androidx/work/integration/testapp/RetryWorker.java
M work/integration-tests/testapp/src/main/res/layout/activity_main.xml
M work/integration-tests/testapp/src/main/res/values/strings.xml
M work/workmanager/src/androidTest/java/androidx/work/impl/WorkerWrapperTest.java
M work/workmanager/src/androidTest/java/androidx/work/impl/background/systemalarm/SystemAlarmDispatcherTest.java
M work/workmanager/src/main/java/androidx/work/impl/WorkerWrapper.java
M work/workmanager/src/main/java/androidx/work/impl/background/greedy/GreedyScheduler.java
M work/workmanager/src/main/java/androidx/work/impl/background/systemalarm/CommandHandler.java
M work/workmanager/src/main/java/androidx/work/impl/background/systemalarm/DelayMetCommandHandler.java
M work/workmanager/src/main/java/androidx/work/impl/background/systemjob/SystemJobScheduler.java

https://android-review.googlesource.com/889837

https://goto.google.com/android-sha1/ebb4f87d732f66d01d1a4cf362bb11a815e80b74