Back arrow is not shown in release build with minifyEnabled [123449431]

Fixed

Bug

Status Update

No update yet.

Description

va...@gmail.com

created issue #1

Jan 27, 2019 05:58PM

Component used: Navigation
Version used: 1.0.0-alpha11
Devices/Android versions reproduced on: Android Pie, Pixel 2 XL

Back arrow is not shown in tool bar (set as support action bar) in release build with minifyEnabled. Hamburger icon is still shown and is functional (navigates back to previous fragment). The fragment having the issue is not set as a topLevelDestinationIds in AppBarConfiguration (used in setupActionBarWithNavController)

Works fine in
debug build
release build ( with minifyEnabled false, shrinkResources false and useProguard true )

Fails in
release build ( with minifyEnabled true, shrinkResources false and useProguard true )

Does navigation need something for release builds with minifyEnabled?

Comments

il...@google.com <il...@google.com> #2Jan 28, 2019 05:25PM

since these are in public API (:/) we need to do this in 1.2

va...@gmail.com <va...@gmail.com> #3Jan 28, 2019 08:27PM

since it is already marked as deprecated, we can probably do it by now.

il...@google.com <il...@google.com> Jan 28, 2019 09:38PM

Assigned to il...@google.com.

il...@google.com <il...@google.com> Jan 28, 2019 11:48PM

Accepted by il...@google.com.

ap...@google.com <ap...@google.com> #4Jan 29, 2019 01:20AM

Marked as fixed.

Opening diff shortly

il...@google.com <il...@google.com> #5Jan 29, 2019 09:42PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date: Tue Aug 11 09:30:34 2020

[GH] Hide deprecated internal API.

## Proposed Changes

* `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.

## Testing

Test: Ran unit tests locally

## Issues Fixed

Fixes: 76109329

This is an imported pull request from

https://github.com/androidx/androidx/pull/61.

Resolves #61
Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7

Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92

A room/runtime/api/current.ignore
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/RoomDatabase.java

https://android-review.googlesource.com/1396827

va...@gmail.com <va...@gmail.com> #6Jan 29, 2019 10:35PM

Sure, thanks for the quick fix.

va...@gmail.com <va...@gmail.com> #7Feb 1, 2019 10:59PM

I had to use the androidx version for proguard rules

-keepclassmembers class androidx.appcompat.graphics.drawable.DrawerArrowDrawable {
void setProgress(float);
}

il...@google.com <il...@google.com> #8Feb 1, 2019 11:10PM

Yep, Jetifier will automatically convert ProGuard rules packaged with libraries, but if you're adding the ProGuard files to your own project, you'll need to make sure to use the AndroidX equivalents if your project is using AndroidX.

br...@gmail.com <br...@gmail.com> #9Jan 7, 2020 10:32PM

This issue seems to be back again? ... I'm using v2.2.0-rc02 and have run into the issue. Using the proguard rule below (mentioned in #7 above) to work around the issue seems to fix it.

-keepclassmembers class androidx.appcompat.graphics.drawable.DrawerArrowDrawable {
void setProgress(float);
}

Looking at the commit linked above that fixed the issue originally, it adds a proguard rule to fix the issue for the old support library, but not a rule for the AndroidX equivalent. #8 suggests that Jetifier will handle the AndroidX conversion, but that doesn't seem to be the case? I'm using AndroidX and Jetifier and without the specfic -keep rule above for androidx, my back arrow icon gets removed in release (minified) builds.

il...@google.com <il...@google.com> #10Jan 13, 2020 09:50PM

Re #9 - I filed https://issuetracker.google.com/issues/147610424 to capture this regression (seems to be a problem for all Navigation 2.X releases)

jb...@google.com <jb...@google.com> #11Jan 14, 2020 06:29PM

Do you have jetifier enabled by adding android.enableJetifier=true in your gradle.properties file? If so it should work fine. We opened a bug to change the rule over so that enabling jetifier is not required in a future release (https://issuetracker.google.com/issues/137201343).

br...@gmail.com <br...@gmail.com> #12Jan 14, 2020 09:05PM

Re #11, I do have jetifier enabled, and still see the regression mentioned in #9