navigateUp() causes navgraph issue when moving from FragmentTypeB to FragmentTypeB [123552990]

Fixed

Bug

Status Update

No update yet.

Description

an...@seventhbeam.com

created issue #1

Jan 29, 2019 06:09AM

Component used: Navigation
Version used: 1.0.0-alpha11

I'm seeing some strange behaviour when pressing back button and transistion back to a fragment from a fragment of the same id.
My app uses some generic fragment structures that are driven by args passed in, as such there are places like:

FragmentA -> FragmentB -> FragmentB -> FragmentC

However if the back button is pressed on the second instance of FragmentB, FragmentA is replaced in the navhost while the navgraph correctly displays in the toolbar. Forward navigation from this point however is missing from the navgraph and results in an IllegalStateException with the action 'not found' in the graph, unless the back button is pressed again (pushing the navgraph destination back to FragmentA)

Is this intended behaviour? If so is there a way to declare FragmentB as 'stackable'?

Comments

so...@gmail.com <so...@gmail.com> #2Jan 29, 2019 10:56AM

since these are in public API (:/) we need to do this in 1.2

so...@gmail.com <so...@gmail.com> #3Jan 29, 2019 11:07AM

since it is already marked as deprecated, we can probably do it by now.

so...@gmail.com <so...@gmail.com> #4Jan 29, 2019 11:34AM

Opening diff shortly

il...@google.com <il...@google.com> Jan 29, 2019 04:05PM

Assigned to il...@google.com.

il...@google.com <il...@google.com> Jan 30, 2019 06:49PM

Accepted by il...@google.com.

ap...@google.com <ap...@google.com> #5Jan 30, 2019 07:50PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date: Tue Aug 11 09:30:34 2020

[GH] Hide deprecated internal API.

## Proposed Changes

* `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.

## Testing

Test: Ran unit tests locally

## Issues Fixed

Fixes: 76109329

This is an imported pull request from

https://github.com/androidx/androidx/pull/61.

Resolves #61
Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7

Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92

A room/runtime/api/current.ignore
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/RoomDatabase.java

https://android-review.googlesource.com/1396827

il...@google.com <il...@google.com> #6Jan 30, 2019 08:33PM

This was regression introduced when fixing

https://issuetracker.google.com/issues/110893637 - it is now fixed internally and will be available in the next release of Navigation.

ch...@gmail.com <ch...@gmail.com> #7Feb 5, 2019 06:44PM

This is still not fixed. Steps to reproduce:

- Be on the initial Fragment (FragmentA)
- Press device back button (the back press will be consumed but nothing appears to happen)
- Click on a view that will cause an attempt to navigate to FragmentB
- Crash

il...@google.com <il...@google.com> #8Feb 5, 2019 06:50PM

Re #7 - please file a new bug with a sample project that reproduces your issue.