Incorrect ResultReceiver mapping - Jetifier [123651524]

Fixed

Bug

[AOSP] assigned

Status Update

No update yet.

Description

ga...@gmail.com

created issue #1

Jan 31, 2019 11:35AM

I am using a third party dependency (provided as an aar) which makes use of ResultReceiver from the Support-v4 library (android.support.v4.os.ResultReceiver). After migrating my app to AndroidX, Jetifier is changing the import in the library to "androidx.core.os.ResultReceiver" which is causing a ClassNotFoundException during runtime because ResultReceiver has not yet been moved to the new AndroidX package.

Exception:
Caused by: java.lang.ClassNotFoundException: Didn't find class "androidx.core.os.ResultReceiver"

ResultReceiver in AndroidX Core, it is still in package android/support/v4/os:

https://android.googlesource.com/platform/frameworks/support/+/androidx-master-dev/core/src/main/java/android/support/v4/os

Sample project:

https://github.com/hibob224/jetifier-test

Android Studio:
Android Studio 3.3
Build #AI-182.5107.16.33.5199772, built on December 25, 2018
JRE: 1.8.0_152-release-1248-b01 x86_64
JVM: OpenJDK 64-Bit Server VM by JetBrains s.r.o
macOS 10.13.6

Comments

ad...@google.com <ad...@google.com> #2Jan 31, 2019 11:57AM

Assigned to ki...@google.com.

Actually, a multiplier of 8.67 gets me back to the approximate position it should be.

ki...@google.com <ki...@google.com> #3Feb 11, 2019 09:59PM

Reassigned to pa...@google.com.

This bug was fixed in 2.1.1. Thanks for the report!

al...@google.com <al...@google.com> #4Feb 11, 2019 10:11PM

While the behavior has changed, it is still incorrect, IIUC. Now the view is shifted up too much for the values entered. For instance, when I enter a bottom inset of 200, which is less than half of the total height (509) of the map, and so should have no effect on the default centering behavior, the marker is actually centered at 354.5 points from the bottom, which is the center of the map plus half of the bottom inset. This seems incorrect per my understanding of that API.

ap...@google.com <ap...@google.com> #5Feb 13, 2019 02:04PM

354.5 sounds exactly right to me.

hu...@google.com <hu...@google.com> #6Apr 1, 2019 04:39PM

FYI, in AGP 3.4.0-rc03 and 3.5.0-alpha09, the AGP has been updated to use Jetifier 1.0.0-beta04, which should have the fix for the above issue:

https://android.googlesource.com/platform/tools/base/+/f7fdfbb94aebb43b7e9515c683fd71b8c905ee79.

pa...@google.com <pa...@google.com> #7Oct 25, 2019 01:12PM

Marked as fixed.

Closing as fixed.

Issue 123651524