Incorrect ResultReceiver mapping - Jetifier [123651524]

Fixed

Bug

[AOSP] assigned

Status Update

No update yet.

Description

ga...@gmail.com

created issue #1

Jan 31, 2019 11:35AM

I am using a third party dependency (provided as an aar) which makes use of ResultReceiver from the Support-v4 library (android.support.v4.os.ResultReceiver). After migrating my app to AndroidX, Jetifier is changing the import in the library to "androidx.core.os.ResultReceiver" which is causing a ClassNotFoundException during runtime because ResultReceiver has not yet been moved to the new AndroidX package.

Exception:
Caused by: java.lang.ClassNotFoundException: Didn't find class "androidx.core.os.ResultReceiver"

ResultReceiver in AndroidX Core, it is still in package android/support/v4/os:

https://android.googlesource.com/platform/frameworks/support/+/androidx-master-dev/core/src/main/java/android/support/v4/os

Sample project:

https://github.com/hibob224/jetifier-test

Android Studio:
Android Studio 3.3
Build #AI-182.5107.16.33.5199772, built on December 25, 2018
JRE: 1.8.0_152-release-1248-b01 x86_64
JVM: OpenJDK 64-Bit Server VM by JetBrains s.r.o
macOS 10.13.6

Comments

ad...@google.com <ad...@google.com> #2Jan 31, 2019 11:57AM

Assigned to ki...@google.com.

From the other issue:

note that it is never the right approach to attach a <deeplink> to an <activity> destination as that will never give you the right behavior when using an implicit deep link on another app's task (where the system back should immediately take the user back to the app that triggered your deep link). Instead, you should attach your deep link directly to your second activity (either by manually writing the appropriate <intent-filter> or by adding the <deeplink> to the start destination of a nav host in that second activity).

A lint error saying as such when a <deepLink> element is added in Navigation XML would go a really long way to avoiding this case. Our guide to writing Lint checks in AndroidX is a good place to start to start a navigation-runtime-lint artifact that would contain this check.

ki...@google.com <ki...@google.com> #3Feb 11, 2019 09:59PM

Reassigned to pa...@google.com.

We have some public docs on writing library lint rules. Specifically the xml lint rule part should be pretty helpful.

al...@google.com <al...@google.com> #4Feb 11, 2019 10:11PM

CL is WIP: https://android-review.googlesource.com/c/platform/frameworks/support/+/2064176

ap...@google.com <ap...@google.com> #5Feb 13, 2019 02:04PM

Project: platform/frameworks/support
Branch: androidx-main

commit cd77b4bbe312dd8892dfbb3c662344d13a96c82d
Author: Julia McClellan <juliamcclellan@google.com>
Date: Thu Apr 14 15:31:46 2022

Deep link in activity destination in navigation lint

Test: Included tests of API version and the lint rule
Bug: 178403185

Change-Id: Ic15a5ec165620b7ef5b3f03538cc83b5576add8d

A navigation/navigation-runtime-lint/src/main/java/androidx/navigation/runtime/lint/DeepLinkInActivityDestinationDetector.kt
A navigation/navigation-runtime-lint/src/test/java/androidx/navigation/runtime/lint/ApiLintVersionsTest.kt
M settings.gradle
A navigation/navigation-runtime-lint/build.gradle
M navigation/navigation-runtime/build.gradle
A navigation/navigation-runtime-lint/src/main/java/androidx/navigation/runtime/lint/NavigationRuntimeIssueRegistry.kt
A navigation/navigation-runtime-lint/src/test/java/androidx/navigation/runtime/lint/DeepLinkInActivityDestinationDetectorTest.kt
A navigation/navigation-runtime-lint/src/main/resources/META-INF/services/com.android.tools.lint.client.api.IssueRegistry

https://android-review.googlesource.com/2064176

hu...@google.com <hu...@google.com> #6Apr 1, 2019 04:39PM

FYI, in AGP 3.4.0-rc03 and 3.5.0-alpha09, the AGP has been updated to use Jetifier 1.0.0-beta04, which should have the fix for the above issue:

https://android.googlesource.com/platform/tools/base/+/f7fdfbb94aebb43b7e9515c683fd71b8c905ee79.

pa...@google.com <pa...@google.com> #7Oct 25, 2019 01:12PM

Marked as fixed.

Closing as fixed.

Issue 123651524