Incorrect ResultReceiver mapping - Jetifier [123651524]

Fixed

Bug

[AOSP] assigned

Status Update

No update yet.

Description

ga...@gmail.com

created issue #1

Jan 31, 2019 11:35AM

I am using a third party dependency (provided as an aar) which makes use of ResultReceiver from the Support-v4 library (android.support.v4.os.ResultReceiver). After migrating my app to AndroidX, Jetifier is changing the import in the library to "androidx.core.os.ResultReceiver" which is causing a ClassNotFoundException during runtime because ResultReceiver has not yet been moved to the new AndroidX package.

Exception:
Caused by: java.lang.ClassNotFoundException: Didn't find class "androidx.core.os.ResultReceiver"

ResultReceiver in AndroidX Core, it is still in package android/support/v4/os:

https://android.googlesource.com/platform/frameworks/support/+/androidx-master-dev/core/src/main/java/android/support/v4/os

Sample project:

https://github.com/hibob224/jetifier-test

Android Studio:
Android Studio 3.3
Build #AI-182.5107.16.33.5199772, built on December 25, 2018
JRE: 1.8.0_152-release-1248-b01 x86_64
JVM: OpenJDK 64-Bit Server VM by JetBrains s.r.o
macOS 10.13.6

Comments

ad...@google.com <ad...@google.com> #2Jan 31, 2019 11:57AM

Assigned to ki...@google.com.

At least make BottomSheet can be launched from local like AlertDialog. Right now, it's too hard to have multiple BottomSheets on one screen with BottomSheetScaffold.

ki...@google.com <ki...@google.com> #3Feb 11, 2019 09:59PM

Reassigned to pa...@google.com.

(Maybe I don't where this lives in documentation) I'm looking for a similar behavior in SwiftUI where you can call `.sheet()` to invoke a bottom sheet at any point which overtakes the screen. This behaves just like `.alert` in SwiftUI.

al...@google.com <al...@google.com> #4Feb 11, 2019 10:11PM

Re comment#2 and comment#3 - this issue is only tracking the integration of bottom sheets into Navigation Compose so that you can use navController.navigate() to make a bottom sheet appear.

If you'd like to request changes to the ModalBottomSheetLayout and similar APIs, you'll want to file a separate request against Compose.

ap...@google.com <ap...@google.com> #5Feb 13, 2019 02:04PM

Fwiw this change does enable treating bottom sheets more like a window-esque thing, but they definitely won't be local.

hu...@google.com <hu...@google.com> #6Apr 1, 2019 04:39PM

Accompanist now supports this with Navigation Material.

pa...@google.com <pa...@google.com> #7Oct 25, 2019 01:12PM

Marked as fixed.

This feature will be super useful!

Issue 123651524