Fragment with `android:name` too long will cause safeArgs-kotlin plugin to generate invalid .kt file [123654948]

Fixed

Bug

Status Update

No update yet.

Description

[Deleted User]

created issue #1

Jan 31, 2019 05:06AM

Component used: Navigation
Version used: 1.0.0-alpha11
Devices/Android versions reproduced on: Android Studio 3.4 Beta2

The generated file will have the package split into two lines.

```
package
com.robotsandpencils.testapp.tab3.usingabiglongnamethatshouldbeover100characterswillgenerateinvalidkotlinsafeargsfile
```

Alpha11LongPackageBug.zip

194 B

Download

Comments

il...@google.com <il...@google.com> Jan 31, 2019 05:37PM

Assigned to da...@google.com.

da...@google.com <da...@google.com> #2Jan 31, 2019 06:08PM

This one should be fixed in Id83c73a91f966bd1f8a6950ffa9b7dfca1158dfb

[Deleted User] <[Deleted User]> #3Mar 1, 2019 08:29PM

It sounds like the fix is in AGP 8.2+, is that right?

il...@google.com <il...@google.com> Mar 15, 2019 10:10PM

Accepted by il...@google.com.

ap...@google.com <ap...@google.com> #4Mar 15, 2019 11:13PM

Marked as fixed.

Yes, should be in 8.2 Canary 6

il...@google.com <il...@google.com> #5Mar 15, 2019 11:14PM

This is fixed internally with Safe Args now relying on KotlinPoet 1.1.0 - expect it in Navigation 2.1.0-alpha01

Issue 123654948