Fragment with `android:name` too long will cause safeArgs-kotlin plugin to generate invalid .kt file [123654948]

Fixed

Bug

Status Update

No update yet.

Description

[Deleted User]

created issue #1

Jan 31, 2019 05:06AM

Component used: Navigation
Version used: 1.0.0-alpha11
Devices/Android versions reproduced on: Android Studio 3.4 Beta2

The generated file will have the package split into two lines.

```
package
com.robotsandpencils.testapp.tab3.usingabiglongnamethatshouldbeover100characterswillgenerateinvalidkotlinsafeargsfile
```

Alpha11LongPackageBug.zip

194 B

Download

Comments

il...@google.com <il...@google.com> Jan 31, 2019 05:37PM

Assigned to da...@google.com.

da...@google.com <da...@google.com> #2Jan 31, 2019 06:08PM

At least make BottomSheet can be launched from local like AlertDialog. Right now, it's too hard to have multiple BottomSheets on one screen with BottomSheetScaffold.

[Deleted User] <[Deleted User]> #3Mar 1, 2019 08:29PM

(Maybe I don't where this lives in documentation) I'm looking for a similar behavior in SwiftUI where you can call `.sheet()` to invoke a bottom sheet at any point which overtakes the screen. This behaves just like `.alert` in SwiftUI.

il...@google.com <il...@google.com> Mar 15, 2019 10:10PM

Accepted by il...@google.com.

ap...@google.com <ap...@google.com> #4Mar 15, 2019 11:13PM

Marked as fixed.

Re comment#2 and comment#3 - this issue is only tracking the integration of bottom sheets into Navigation Compose so that you can use navController.navigate() to make a bottom sheet appear.

If you'd like to request changes to the ModalBottomSheetLayout and similar APIs, you'll want to file a separate request against Compose.

il...@google.com <il...@google.com> #5Mar 15, 2019 11:14PM

Fwiw this change does enable treating bottom sheets more like a window-esque thing, but they definitely won't be local.

Issue 123654948