Fragment with `android:name` too long will cause safeArgs-kotlin plugin to generate invalid .kt file [123654948]

Fixed

Bug

Status Update

No update yet.

Description

[Deleted User]

created issue #1

Jan 31, 2019 05:06AM

Component used: Navigation
Version used: 1.0.0-alpha11
Devices/Android versions reproduced on: Android Studio 3.4 Beta2

The generated file will have the package split into two lines.

```
package
com.robotsandpencils.testapp.tab3.usingabiglongnamethatshouldbeover100characterswillgenerateinvalidkotlinsafeargsfile
```

Alpha11LongPackageBug.zip

194 B

Download

Comments

il...@google.com <il...@google.com> Jan 31, 2019 05:37PM

Assigned to da...@google.com.

da...@google.com <da...@google.com> #2Jan 31, 2019 06:08PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit bb5849831cc38dd1d229f2b80702b94d8f01de43
Author: Sumir Kataria <sumir@google.com>
Date: Thu May 02 14:02:53 2019

Correct some old terminology in PeriodicWorkRequest documentation.

Fixes: 131711394
Test: genDocs
Change-Id: Ie8469aa34d02185c6fca9ed18a9ecf4d8bb3c81d

M work/workmanager/src/main/java/androidx/work/PeriodicWorkRequest.java

https://android-review.googlesource.com/954493

https://goto.google.com/android-sha1/bb5849831cc38dd1d229f2b80702b94d8f01de43

[Deleted User] <[Deleted User]> #3Mar 1, 2019 08:29PM

New release of kotlinPoet

https://github.com/square/kotlinpoet/releases/tag/1.1.0

il...@google.com <il...@google.com> Mar 15, 2019 10:10PM

Accepted by il...@google.com.

ap...@google.com <ap...@google.com> #4Mar 15, 2019 11:13PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 73ef5e0d44bd3f8293faccd61f7a8a2f01ba81b5
Author: Ian Lake <ilake@google.com>
Date: Fri Mar 15 15:10:39 2019

Upgrade Safe Args to use KotlinPoet 1.1.0

Picks up bug fixes in KotlinPoet, namely support
for really long package names from

https://github.com/square/kotlinpoet/pull/597

Test: newly added tests
Fixes: 123654948
Change-Id: I8ed4e5082065877aa0f54d53007932c97bb7aa76

M buildSrc/src/main/kotlin/androidx/build/dependencies/Dependencies.kt
M navigation/safe-args-generator/src/tests/kotlin/androidx/navigation/safe/args/generator/JavaNavWriterTest.kt
M navigation/safe-args-generator/src/tests/kotlin/androidx/navigation/safe/args/generator/KotlinNavWriterTest.kt
A navigation/safe-args-generator/src/tests/test-data/a/b/secondreallyreallyreallyreallyreallyreallyreallyreallyreallyreallyreallyreallyreallyreallyreallyreallylongpackage/R.java
A navigation/safe-args-generator/src/tests/test-data/expected/java_nav_writer_test/LongPackageFragmentDirections.java
A navigation/safe-args-generator/src/tests/test-data/expected/kotlin_nav_writer_test/LongPackageFragmentDirections.kt

https://android-review.googlesource.com/930460

https://goto.google.com/android-sha1/73ef5e0d44bd3f8293faccd61f7a8a2f01ba81b5

il...@google.com <il...@google.com> #5Mar 15, 2019 11:14PM

This is fixed internally with Safe Args now relying on KotlinPoet 1.1.0 - expect it in Navigation 2.1.0-alpha01

Issue 123654948