Static inner classes used as argType generate invalid Safe Args code [123736741]

Fixed

Bug

Status Update

No update yet.

Description

il...@google.com

created issue #1

Feb 1, 2019 05:11PM

Component used: Navigation
Version used: 1.0.0-alpha11

When debugging

https://issuetracker.google.com/issues/123686419, I discovered that Safe Args generate invalid code (both Java and Kotlin) when the argType is a static inner class:

<argument android:name="innerData" app:argType="com.example.sandbox.OutterClass$InnerClass"/>

The dollar signs indicating a nested class are not transformed into a period in the generated code, leading to invalid code such as:

OutterClass$InnerClass innerData = (OutterClass$InnerClass) arguments.get("innerData");

Which should be

OutterClass.InnerClass innerData = (OutterClass.InnerClass) arguments.get("innerData");

Comments

il...@google.com <il...@google.com> #2Feb 1, 2019 05:12PM

I was able to repro locally using the snippet in #1. The slide should never be applied to the content for state == 0, i.e. the green box.

Will take a look. Thanks for the repro steps, Jeremy.

ap...@google.com <ap...@google.com> #3Feb 2, 2019 05:38AM

I'm having an issue with Compose navigation-animation which might be caused by this.

I have two screens: List and Details.

List screen uses default transitions.

Details screen uses the following transitions:

enterTransition = {
    slideIntoContainer(
        AnimatedContentScope.SlideDirection.Up,
        animationSpec = tween(400)
    )
},
popExitTransition = {
    slideOutOfContainer(
        AnimatedContentScope.SlideDirection.Down,
        animationSpec = tween(200)
    )
},

The video is showing the bug vs expected. It's hard to describe: after clicking the back button before the transition to the Details screen was completed, the List screen moves up a little.

il...@google.com <il...@google.com> #4Feb 2, 2019 05:42AM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 7e3b52b20e73c397019f474ab15eb8ea64a872d3
Author: Doris Liu <tianliu@google.com>
Date: Thu Sep 29 18:06:42 2022

Fix incorrect interruption animation in AnimatedContent

Bug: 238662479

Test: included
Change-Id: I86bb98800070f4584e30a1d0a4edec274b0c7e5c

A compose/animation/animation/integration-tests/animation-demos/src/main/java/androidx/compose/animation/demos/visualinspection/AnimatedContentWithInterruptions.kt
M compose/animation/animation/src/androidAndroidTest/kotlin/androidx/compose/animation/AnimatedContentTest.kt
M compose/animation/animation/src/commonMain/kotlin/androidx/compose/animation/EnterExitTransition.kt
M compose/animation/animation/src/commonMain/kotlin/androidx/compose/animation/AnimatedContent.kt
M compose/animation/animation/integration-tests/animation-demos/src/main/java/androidx/compose/animation/demos/AnimationDemos.kt

https://android-review.googlesource.com/2239235

Issue 123736741

Description

Issue summary

Comments

il...@google.com <il...@google.com> #2Feb 1, 2019 05:12PM

ap...@google.com <ap...@google.com> #3Feb 2, 2019 05:38AM

il...@google.com <il...@google.com> #4Feb 2, 2019 05:42AM

Add comment

Issue metadata