App crashing on rotation with: java.lang.IllegalStateException: unknown destination during restore [123803044]

Fixed

Bug

Status Update

No update yet.

Description

ar...@gmail.com

created issue #1

Feb 3, 2019 01:59AM

Component used: Navigation
Version used: 1.0.0-alpha11
Devices/Android versions reproduced on: Nexus 5X API 27

I've implemented conditional navigation for my login flow as described in this SO post:

https://stackoverflow.com/questions/51582674/navigation-architecture-component-login-screen

Now everything appears to be working, however after being navigated to the login screen and successfully logging in then navigating back to the main screen, on rotation the app crashes with the error: "java.lang.IllegalStateException: unknown destination during restore".

I've created a SO post containing the full error and navgraph for my project:

https://stackoverflow.com/q/54496008/7648952

I've also reproduced the error in this sample app:

https://github.com/sbearben/NavigationCrashSampleApp

For a bit of further information it appears this crash started to occur in version 1.0.0-alpha08.

Comments

il...@google.com <il...@google.com> Feb 3, 2019 06:19AM

Assigned to il...@google.com.

ar...@gmail.com <ar...@gmail.com> #2Feb 3, 2019 08:53PM

alpha01? That's so old! :D

We've found the issue in alpha10 and are working on a fix.

il...@google.com <il...@google.com> Feb 3, 2019 11:19PM

Accepted by il...@google.com.

ap...@google.com <ap...@google.com> #3Feb 4, 2019 05:18PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 37ed64d4de87bd4a4365f5c0dfee7b33c8043013
Author: Daniel Santiago Rivera <danysantiago@google.com>
Date: Wed Jan 23 15:46:00 2019

Add missing import of parent Directions class in generated Safe Args.

When generating a parent direction action method in a child directions
class,correctly import the parent direction if its located in another
package. Both JavaPoet and KotlinPoet generate import statements but the
NavWriters were incorrectly creating the class name of the parent type,
specifically it missed the package name which caused the import to be
missing.

Bug: 123307342
Test: ./gradlew navigation:navigation-safe-args-gradle-plugin:test \
navigation:navigation-safe-args-generator:test

Change-Id: Ibeda7a7ec6f31bb1c860dfe1f5cd2a7e7ea6d47d

M navigation/safe-args-generator/src/main/kotlin/androidx/navigation/safe/args/generator/java/JavaNavWriter.kt
M navigation/safe-args-generator/src/main/kotlin/androidx/navigation/safe/args/generator/kotlin/KotlinNavWriter.kt
M navigation/safe-args-generator/src/tests/kotlin/androidx/navigation/safe/args/generator/NavGeneratorTest.kt
M navigation/safe-args-generator/src/tests/kotlin/androidx/navigation/safe/args/generator/NavParserTest.kt
M navigation/safe-args-generator/src/tests/test-data/expected/nav_generator_test/java/nested/LoginFragmentDirections.java
M navigation/safe-args-generator/src/tests/test-data/expected/nav_generator_test/java/nested/RegisterFragmentDirections.java
M navigation/safe-args-generator/src/tests/test-data/expected/nav_generator_test/java/nested_overridden_action/InnerSettingsFragmentDirections.java
M navigation/safe-args-generator/src/tests/test-data/expected/nav_generator_test/java/nested_overridden_action/SettingsFragmentDirections.java
M navigation/safe-args-generator/src/tests/test-data/expected/nav_generator_test/kotlin/nested/LoginFragmentDirections.kt
M navigation/safe-args-generator/src/tests/test-data/expected/nav_generator_test/kotlin/nested/RegisterFragmentDirections.kt
M navigation/safe-args-generator/src/tests/test-data/expected/nav_generator_test/kotlin/nested_overridden_action/InnerSettingsFragmentDirections.kt
M navigation/safe-args-generator/src/tests/test-data/expected/nav_generator_test/kotlin/nested_overridden_action/SettingsFragmentDirections.kt
M navigation/safe-args-generator/src/tests/test-data/nested_login_test.xml
M navigation/safe-args-gradle-plugin/src/test/test-data/app-project-kotlin/src/main/res/navigation/nav_nested_test.xml
A navigation/safe-args-gradle-plugin/src/test/test-data/app-project/src/main/res/navigation/nav_nested_test.xml

https://android-review.googlesource.com/883592

https://goto.google.com/android-sha1/37ed64d4de87bd4a4365f5c0dfee7b33c8043013

ap...@google.com <ap...@google.com> #4Feb 4, 2019 05:19PM

Hi, I'm still having the issue with 1.0.0-alpha11. Generated classes for fragments in nested navigation throws error for global actions.

il...@google.com <il...@google.com> #5Feb 4, 2019 05:29PM

Marked as fixed.

I am also having the issue with 1.0.0-alpha11. I'm going to see what the Kotlin generator does with this.

ca...@gmail.com <ca...@gmail.com> #6Feb 8, 2019 12:36AM

Re #4 and #5 - please file a new bug with a sample project that reproduces your issue.

be...@gmail.com <be...@gmail.com> #7May 1, 2019 08:23PM

Re #6 will do. I think it has to do with naming arguments with capital first letters but I'll see if I can make a minimal example app to demonstrate, as a new bug.

il...@google.com <il...@google.com> #8May 1, 2019 08:27PM

How do i fix this?

be...@gmail.com <be...@gmail.com> #9May 1, 2019 09:24PM

If you're working with Jetpack Navigation in Android and the generated classes don't import MainNavDirections, it usually points to an issue with your setup or the https://lillestromflytt.no/lager-lillestrom/ navigation component.If after all these steps the issue persists, consider invalidating caches and restarting Android Studio (File > Invalidate Caches / Restart), as sometimes cached data can cause problems with code generation.