Fixed
Status Update
No update yet.
Comments
il...@google.com
ar...@gmail.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit bade7af890d31f0f4a4b094ff1fd475b24fff95c
Author: jbwoods <jbwoods@google.com>
Date: Mon Feb 25 15:49:05 2019
Fix typo in ActivityNavigator
Both popEnterAnim and popExitAnim were getting the intent extra intended
for popEnterAnim in the applyPopAnimationsToPendingTransition method. Made
popExitAnim get the proper extra.
Test: ran nav test app
BUG: 126237567
Change-Id: Iecdcdd62695f66e1a66eeb5ec84df09c1faaff24
M navigation/runtime/src/main/java/androidx/navigation/ActivityNavigator.java
https://android-review.googlesource.com/912259
https://goto.google.com/android-sha1/bade7af890d31f0f4a4b094ff1fd475b24fff95c
Branch: androidx-master-dev
commit bade7af890d31f0f4a4b094ff1fd475b24fff95c
Author: jbwoods <jbwoods@google.com>
Date: Mon Feb 25 15:49:05 2019
Fix typo in ActivityNavigator
Both popEnterAnim and popExitAnim were getting the intent extra intended
for popEnterAnim in the applyPopAnimationsToPendingTransition method. Made
popExitAnim get the proper extra.
Test: ran nav test app
BUG: 126237567
Change-Id: Iecdcdd62695f66e1a66eeb5ec84df09c1faaff24
M navigation/runtime/src/main/java/androidx/navigation/ActivityNavigator.java
il...@google.com
ap...@google.com
Fixed for Navigation 1.0.0-rc02
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit c775e5d1ae2ab4b194ee3c0f18523c603cf4d6ec
Author: Ian Lake <ilake@google.com>
Date: Sun Feb 03 15:04:21 2019
Return true when popping from FragmentNavigator
Since NavController only updates its back stack when
a Navigator returns true from popBackStack(), ensure
that all updates to the FragmentNavigator's back stack
(i.e., calling removeLast()) are paired with returning
true from popBackStack().
This ensures that the FragmentManager state and the
NavController states don't get out of sync.
Test: Updated FragmentNavigatorTest test
Test: tested in sample app from bug
BUG: 123803044
Change-Id: I8cfc87cba0a0369b5ae5c3ac610e31b5556ba04e
M navigation/fragment/src/androidTest/java/androidx/navigation/fragment/FragmentNavigatorTest.kt
M navigation/fragment/src/main/java/androidx/navigation/fragment/FragmentNavigator.java
https://android-review.googlesource.com/892996
https://goto.google.com/android-sha1/c775e5d1ae2ab4b194ee3c0f18523c603cf4d6ec
Branch: androidx-master-dev
commit c775e5d1ae2ab4b194ee3c0f18523c603cf4d6ec
Author: Ian Lake <ilake@google.com>
Date: Sun Feb 03 15:04:21 2019
Return true when popping from FragmentNavigator
Since NavController only updates its back stack when
a Navigator returns true from popBackStack(), ensure
that all updates to the FragmentNavigator's back stack
(i.e., calling removeLast()) are paired with returning
true from popBackStack().
This ensures that the FragmentManager state and the
NavController states don't get out of sync.
Test: Updated FragmentNavigatorTest test
Test: tested in sample app from bug
BUG: 123803044
Change-Id: I8cfc87cba0a0369b5ae5c3ac610e31b5556ba04e
M navigation/fragment/src/androidTest/java/androidx/navigation/fragment/FragmentNavigatorTest.kt
M navigation/fragment/src/main/java/androidx/navigation/fragment/FragmentNavigator.java
il...@google.com
This is actually an issue where the NavController's back stack state is going out of sync with the FragmentManager / FragmentNavigator's state. This has been fixed and will be available in the next release.
ca...@gmail.com
Nice job! A quick response!
be...@gmail.com
I still get this error using the lastest 1.0.0 release :
implementation 'android.arch.navigation:navigation-fragment-ktx:1.0.0'
implementation "android.arch.navigation:navigation-ui-ktx:1.0.0"
I'm using nested graphs.
implementation 'android.arch.navigation:navigation-fragment-ktx:1.0.0'
implementation "android.arch.navigation:navigation-ui-ktx:1.0.0"
I'm using nested graphs.
il...@google.com
Re #7 - please file a new bug with a sample app that reproduces your issue.
Description
Version used: 1.0.0-alpha11
Devices/Android versions reproduced on: Nexus 5X API 27
I've implemented conditional navigation for my login flow as described in this SO post:
Now everything appears to be working, however after being navigated to the login screen and successfully logging in then navigating back to the main screen, on rotation the app crashes with the error: "java.lang.IllegalStateException: unknown destination during restore".
I've created a SO post containing the full error and navgraph for my project:
I've also reproduced the error in this sample app:
For a bit of further information it appears this crash started to occur in version 1.0.0-alpha08.