Fixed
Status Update
Comments
ap...@google.com <ap...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 84cb8085e76a849cfd139a2d47a55adb916fdd1a
Author: Sumir Kataria <sumir@google.com>
Date: Mon Feb 04 10:39:25 2019
Fix potential NPE in checkWakeLocks.
Test: N/A
Bug: 123835104
Change-Id: I961d1809d8adc7c53ab86863931e9d274794923e
M work/workmanager/src/main/java/androidx/work/impl/utils/WakeLocks.java
https://android-review.googlesource.com/894733
https://goto.google.com/android-sha1/84cb8085e76a849cfd139a2d47a55adb916fdd1a
Branch: androidx-master-dev
commit 84cb8085e76a849cfd139a2d47a55adb916fdd1a
Author: Sumir Kataria <sumir@google.com>
Date: Mon Feb 04 10:39:25 2019
Fix potential NPE in checkWakeLocks.
Test: N/A
Bug: 123835104
Change-Id: I961d1809d8adc7c53ab86863931e9d274794923e
M work/workmanager/src/main/java/androidx/work/impl/utils/WakeLocks.java
ru...@gmail.com <ru...@gmail.com> #3
Thanks for fixing it quickly again :)
su...@google.com <su...@google.com>
ru...@gmail.com <ru...@gmail.com> #4
Seems like this didn't get the chance to be released on the latest beta-04 :/
Can we expect a new release next week?
Can we expect a new release next week?
su...@google.com <su...@google.com> #5
Yes. Thanks.
Description
Version used: 1.0.0-beta03
Devices/Android versions reproduced on: couldn't reproduce
Fatal Exception: java.lang.NullPointerException: Attempt to invoke virtual method 'boolean android.os.PowerManager$WakeLock.isHeld()' on a null object reference
at androidx.work.impl.utils.WakeLocks.checkWakeLocks(WakeLocks.java:89)
at androidx.work.impl.background.systemalarm.SystemAlarmService.onAllCommandsCompleted(SystemAlarmService.java:69)
at androidx.work.impl.background.systemalarm.SystemAlarmDispatcher.dequeueAndCheckForCompletion(SystemAlarmDispatcher.java:217)
at androidx.work.impl.background.systemalarm.SystemAlarmDispatcher$DequeueAndCheckForCompletion.run(SystemAlarmDispatcher.java:317)
at android.os.Handler.handleCallback(Handler.java:810)
at android.os.Handler.dispatchMessage(Handler.java:99)
at android.os.Looper.loop(Looper.java:189)
at android.app.ActivityThread.main(ActivityThread.java:5529)
at java.lang.reflect.Method.invoke(Method.java)
at java.lang.reflect.Method.invoke(Method.java:372)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:950)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:745)
Seems like the copy of wake locks can contain null keys. I couldn't reproduce this, but some devices on crashlytics are reporting this crash.