NPE on checking wake locks [123835104]

Fixed

Bug

Status Update

No update yet.

Description

ru...@gmail.com

created issue #1

Feb 4, 2019 03:03PM

Component used: WorkManager
Version used: 1.0.0-beta03
Devices/Android versions reproduced on: couldn't reproduce

Fatal Exception: java.lang.NullPointerException: Attempt to invoke virtual method 'boolean android.os.PowerManager$WakeLock.isHeld()' on a null object reference
at androidx.work.impl.utils.WakeLocks.checkWakeLocks(WakeLocks.java:89)
at androidx.work.impl.background.systemalarm.SystemAlarmService.onAllCommandsCompleted(SystemAlarmService.java:69)
at androidx.work.impl.background.systemalarm.SystemAlarmDispatcher.dequeueAndCheckForCompletion(SystemAlarmDispatcher.java:217)
at androidx.work.impl.background.systemalarm.SystemAlarmDispatcher$DequeueAndCheckForCompletion.run(SystemAlarmDispatcher.java:317)
at android.os.Handler.handleCallback(Handler.java:810)
at android.os.Handler.dispatchMessage(Handler.java:99)
at android.os.Looper.loop(Looper.java:189)
at android.app.ActivityThread.main(ActivityThread.java:5529)
at java.lang.reflect.Method.invoke(Method.java)
at java.lang.reflect.Method.invoke(Method.java:372)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:950)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:745)

Seems like the copy of wake locks can contain null keys. I couldn't reproduce this, but some devices on crashlytics are reporting this crash.

Comments

ap...@google.com <ap...@google.com> #2Feb 4, 2019 07:26PM

it was found that EXIF_TAGS includes IFD_TIFF_TAGS twice

This duplication has always been present in the AndroidX version of ExifInterface. It looks like it was inherited from the platform version, where it was added in 2016 in https://cs.android.com/android/_/android/platform/frameworks/base/+/1674546669b1f82955aeb86c17361c7a97d0ebb3.

ru...@gmail.com <ru...@gmail.com> #3Feb 4, 2019 07:39PM

The duplication of IFD_TIFF_TAGS is also discussed in internal b/249097443#comment5.

su...@google.com <su...@google.com> Feb 4, 2019 08:31PM

Marked as fixed, reassigned to su...@google.com.

ru...@gmail.com <ru...@gmail.com> #4Feb 5, 2019 09:37AM

Project: platform/frameworks/support
Branch: androidx-main

commit 77ac31b4e0d83f5cee16dc6c50da6f26a1f5a4d3
Author: Ian Baker <ibaker@google.com>
Date: Thu Mar 28 16:49:00 2024

Ensure XMP data isn't duplicated into Exif segment when saving

Test: ExifInterfaceTest
Bug: 309843390
Change-Id: I56b6defea9b5e800d426cb050b19bea03f614b15

M exifinterface/exifinterface/src/androidTest/java/androidx/exifinterface/media/ExifInterfaceTest.java
M exifinterface/exifinterface/src/main/java/androidx/exifinterface/media/ExifInterface.java

https://android-review.googlesource.com/3017513

su...@google.com <su...@google.com> #5Feb 5, 2019 05:38PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.exifinterface:exifinterface:1.4.0-alpha01

Issue 123835104