@RequiresApi with a reference to a constant turns off all Lint API level checks for that class [123945223]

Fixed

Bug

Status Update

No update yet.

Description

su...@google.com

created issue #1

Feb 5, 2019 09:51PM

This was a bug first seen here

https://issuetracker.google.com/123893059 in WorkManager.

We have the following class:

@RequiresApi(WorkManagerImpl.MIN_JOB_SCHEDULER_API_LEVEL)
public class SystemJobScheduler implements Scheduler {

...
}

with the constant resolving to:

public static final int MIN_JOB_SCHEDULER_API_LEVEL = 23;

Inside this class, we have a call to JobScheduler#getPendingJob (

https://developer.android.com/reference/android/app/job/JobScheduler.html#getPendingJob(int)), which requires API 24. This is not highlighted by the IDE as an error.

When I changed the annotation to @RequiresApi(23), the call starts getting flagged as an error.

This is a pretty bad bug and caused us to ship a crash.

Comments

tn...@google.com <tn...@google.com> #2Feb 5, 2019 10:35PM

Assigned to tn...@google.com.

Project: platform/frameworks/support
Branch: androidx-main

commit b6c7c78f9e7476b468dafe9d5f7dec6794d47f09
Author: Shahd AbuDaghash <shahddaghash@google.com>
Date: Mon Nov 27 11:16:51 2023

Introduce DecayAnimation in AnchoredDraggable

Decay animation allows more realistic settling of a component. This is performed by now passing a `DecayAnimationSpec` parameter to AnchoredDraggable and using it when animating to the target. The new animation implementation will be added in a chain CL.

Bug: 288084801
Test: Tests will be added in a chain CL
Relnote: This change adds a `decayAnimationSpec` parameter to AnchoredDraggable allowing to use decay animation when settling to one of the anchors. The change also includes renaming the existing `animationSpec` to `snapAnimationSpec` to help understanding the use case of each spec.
Change-Id: I44ccd408d919328fd6504d31d8db59cf1d07de43

M compose/foundation/foundation/api/current.txt
M compose/foundation/foundation/api/restricted_current.txt
M compose/foundation/foundation/samples/src/main/java/androidx/compose/foundation/samples/AnchoredDraggableSample.kt
M compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/anchoredDraggable/AnchoredDraggableGestureTest.kt
M compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/anchoredDraggable/AnchoredDraggableStateTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/gestures/AnchoredDraggable.kt

https://android-review.googlesource.com/2847074

tn...@google.com <tn...@google.com> #3Mar 21, 2019 01:44PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 365993d1a90c27704b71f6bee042a1749314a4b1
Author: Shahd AbuDaghash <shahddaghash@google.com>
Date: Tue Nov 28 10:49:56 2023

Add tests for Animation in AnchoredDraggable

Added tests to check for different settling behaviors.

Bug: 288084801
Test: Added tests to verify behavior.
Change-Id: I369b30c69f7c29f676ae0671fef25c38ff3c74cb

M compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/anchoredDraggable/AnchoredDraggableStateTest.kt

https://android-review.googlesource.com/2847475

Issue 123945223

Description

Issue summary

Comments

tn...@google.com <tn...@google.com> #2Feb 5, 2019 10:35PM

tn...@google.com <tn...@google.com> #3Mar 21, 2019 01:44PM

Add comment

Issue metadata