Periodic work request runs immediately even with flexInterval set (Android 4 only?) [124274584]

Fixed

Bug

Status Update

No update yet.

Description

dr...@gmail.com

created issue #1

Feb 12, 2019 07:17PM

I'm creating a work request based on setting an interval, and with a flexInterval of half the interval:

long interval = 900000; // 15 minutes
long flexInterval = (interval / 2);
workRequestBuilder = new PeriodicWorkRequest.Builder(MyWorker.class, interval, TimeUnit.MILLISECONDS, flexInterval, TimeUnit.MILLISECONDS);

When I enqueue this on my Android 7 device, the first periodic work does not fire immediately, but as expected only fires halfway through the interval, when the flex period starts.

But when this is enqueued on an Android 4 device (I'm using an Android 4.3 emulator but I noticed this first on a user's real Android 4.3 device), the first periodic work fires IMMEDIATELY.

Seems like flexInterval is not properly taken into account pre Android 5 (based on AlarmManager)??

Comments

ra...@google.com <ra...@google.com> Feb 12, 2019 10:37PM

Assigned to ra...@google.com.

ap...@google.com <ap...@google.com> #2Feb 13, 2019 02:52AM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 6f59e3d74d0da5a4bf79c8480f56964e3af47f1c
Author: Wojtek Kaliciński <wkal@google.com>
Date: Mon Jul 23 20:17:19 2018

Support more types for args

Provides support for Serializable, enums,
as well as arrays of primitive types and Parcelables
in Navigation arguments.

Only enums support default values other than @null,
in the form of the enum literal (without class name),
e.g. app:defaultValue="READ"

Test: unit tests updated
BUG: 111487504
BUG: 111316353
Change-Id: I7e5abbc8ed0950bfdef292342dbe1fb34a5c4b17

M navigation/runtime/src/androidTest/java/androidx/navigation/NavInflaterTest.kt
A navigation/runtime/src/androidTest/java/androidx/navigation/test/TestEnum.java
M navigation/runtime/src/androidTest/res/navigation/nav_default_arguments.xml
M navigation/runtime/src/main/java/androidx/navigation/NavInflater.java
M navigation/safe-args-generator/src/main/kotlin/androidx/navigation/safe/args/generator/NavParser.kt
M navigation/safe-args-generator/src/main/kotlin/androidx/navigation/safe/args/generator/NavParserErrors.kt
M navigation/safe-args-generator/src/main/kotlin/androidx/navigation/safe/args/generator/NavWriter.kt
M navigation/safe-args-generator/src/main/kotlin/androidx/navigation/safe/args/generator/Types.kt
M navigation/safe-args-generator/src/tests/kotlin/androidx/navigation/safe/args/generator/NavParserTest.kt
M navigation/safe-args-generator/src/tests/kotlin/androidx/navigation/safe/args/generator/NavWriterTest.kt
M navigation/safe-args-generator/src/tests/test-data/expected/nav_writer_test/MainFragmentArgs.java
M navigation/safe-args-generator/src/tests/test-data/expected/nav_writer_test/Next.java
M navigation/safe-args-generator/src/tests/test-data/naive_test.xml

https://android-review.googlesource.com/720246

https://goto.google.com/android-sha1/6f59e3d74d0da5a4bf79c8480f56964e3af47f1c

dr...@gmail.com <dr...@gmail.com> #3Feb 13, 2019 08:03AM

This is fixed internally and will be available in 1.0.0-alpha08

ap...@google.com <ap...@google.com> #4Feb 14, 2019 12:33AM

Thanks!

Issue 124274584

Description

Issue summary

Comments

ra...@google.com <ra...@google.com> Feb 12, 2019 10:37PM

ap...@google.com <ap...@google.com> #2Feb 13, 2019 02:52AM

dr...@gmail.com <dr...@gmail.com> #3Feb 13, 2019 08:03AM

ap...@google.com <ap...@google.com> #4Feb 14, 2019 12:33AM

Add comment

Issue metadata