Fixed
Status Update
No update yet.
Comments
il...@google.com
il...@google.com
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 7286459d899320ec36a745399c31cbf882e883c8
Author: Ian Lake <ilake@google.com>
Date: Tue Feb 12 15:57:28 2019
Fix FragmentNavigator singleTop operations
As singleTop operations don't end up adding
anything to the back stack, the generated
back stack name should only use the current
back stack's size (unlike an add operation,
which uses size + 1).
As part of this, ensured that we use the
popBackStack() that takes a back stack name to
avoid popping child Fragments off the back stack.
Rewrote the testSingleTop() to use Truth asserts
throughout instead of some of each.
Test: updated test
Fixes: 124294805
Change-Id: I87a41754d8718aced9a636e9b8d00fa2038137aa
M navigation/fragment/src/androidTest/java/androidx/navigation/fragment/FragmentNavigatorTest.kt
M navigation/fragment/src/main/java/androidx/navigation/fragment/FragmentNavigator.java
https://android-review.googlesource.com/903273
https://goto.google.com/android-sha1/7286459d899320ec36a745399c31cbf882e883c8
Branch: androidx-master-dev
commit 7286459d899320ec36a745399c31cbf882e883c8
Author: Ian Lake <ilake@google.com>
Date: Tue Feb 12 15:57:28 2019
Fix FragmentNavigator singleTop operations
As singleTop operations don't end up adding
anything to the back stack, the generated
back stack name should only use the current
back stack's size (unlike an add operation,
which uses size + 1).
As part of this, ensured that we use the
popBackStack() that takes a back stack name to
avoid popping child Fragments off the back stack.
Rewrote the testSingleTop() to use Truth asserts
throughout instead of some of each.
Test: updated test
Fixes: 124294805
Change-Id: I87a41754d8718aced9a636e9b8d00fa2038137aa
M navigation/fragment/src/androidTest/java/androidx/navigation/fragment/FragmentNavigatorTest.kt
M navigation/fragment/src/main/java/androidx/navigation/fragment/FragmentNavigator.java
il...@google.com
Unfortunately, Navigation 1.0.0-beta02 was pushed just a few hours before you reported this issue. It has been fixed internally and it'll be available in the next release!
Description
Version used:android.arch.navigation:navigation-ui:1.0.0-beta01
Devices/Android versions reproduced on: any
Navigation to a fragment destination with SingleTop option breaks back stack. The issue was introduced in beta01 update in commit 45818ac652ba3a43b07f980cf22ab78be886d81d by Ian Lake <ilake@google.com> on Wed Jan 30 10:45:37 2019 -0800.
I believe that the root of the issue is unnecessary "+ 1" in line 25 of androidx.navigation.fragment.FragmentNavigator.java:
ft.addToBackStack(generateBackStackName(mBackStack.size() + 1, destId));
When navigation is performed in SingleTop mode, the last fragment is being replaced making back stack 1 frame smaller.