Status Update
No update yet.
Comments
il...@google.com
ap...@google.com
So there does seem to be a bug in Navigation that causes this to fail.
When it navigates with popUpTo and removes SecondFragment, that removal in fragment is set for a frame later and before it is actually removed the navigate call in the onViewCreated of SecondFragment enqueues another call to add it back. But we still need to destroy SecondDetailFragment which ends up marking the NavBackStackEntry associated with SecondFragment as complete before navigation has received the call from the fragment that it has been added back. So by the time it hits this check, the SecondFragment is in the correct state, but Navigation has no way of referencing it so it assumes that it is not associated with an entry.
But this is not the way this type of situation should be implemented. Instead of having the destinations as part of the NavGraph, they should:
- be managed by the childFragmentManager of
SecondFragment. So instead of going back toSecondFragmentjust to go somewhere else, each of the fragments take the entire content ofSecondFragmentand are swapped out. - for some sort of a/b testing, set different graphs in the Activity. The graphs would keep the same
SecondFragmentid, but swap out the names and then you choose the correct graph based on the condition.
Description
Version used: 1.0.0-rc01
I recently worked on an app with package name 'in.bitotsav', and used navigation architecture component to implement a single activity structure. I had been using safeargs using
apply plugin: "androidx.navigation.safeargs"
But just now, I discovered the availability of "androidx.navigation.safeargs.kotlin", so I tried applying it. But it leads to compilation error due to the 'in' part of the package name not being escaped in the generated code, for statements like:
override fun getActionId(): Int = in.bitotsav.R.id.action_global_destEventDetail
and
fun actionDestLoginToDestRegistration(): NavDirections =
ActionOnlyNavDirections(in.bitotsav.R.id.action_destLogin_to_destRegistration)
This can be fixed if the 'in' is escaped with backticks, as:
override fun getActionId(): Int = `in`.bitotsav.R.id.action_global_destEventDetail
This is also what is done by android studio in imports.
Version Info:
minSdkVersion 21
targetSdkVersion 28
Android Studio 3.5 Canary 3
Build #AI-183.5153.38.35.5256920, built on January 24, 2019
JRE: 1.8.0_152-release-1248-b01 amd64
JVM: OpenJDK 64-Bit Server VM by JetBrains s.r.o
Linux 4.20.8-arch1-1-ARCH