UP action doesn't work if a destination was started as implicit deeplink [126082008]

Fixed

Bug

Status Update

No update yet.

Description

ja...@gmail.com

created issue #1

Feb 24, 2019 06:37PM

Component used: Navigation
Version used: 1.0.0-rc01
Devices/Android versions reproduced on: 7.0, 9.0 (Emulators)

According to

https://developer.android.com/topic/libraries/architecture/navigation/navigation-deep-link ,
if a destination is opened with IMPLICIT deeplink and WITHOUT Intent.FLAG_ACTIVITY_NEW_TASK flag, then the destination is opened in the same task. After that if user clicks UP, then the actual parent should be recreated in a separate task, but it doesn't work. The UP button in this case does nothing, as well as manual navigateUp() method call.

I tried to modify the code to check both Toolbar and ActionBar approaches and also tried to create the NavHostFragment via xml and code. In all this cases, the behavior of UP button remained the same.

I attached a simple project that shows this situation. It contains 2 modules:
- app - an app with 2 fragments (root and child). The child fragment's destination supports a deeplink.
- deeplinkstarter - one button app, that starts an implicit deeplink to the child fragment of the 'app'.

I consider this as major defect because the library doesn't behave as it is explicitly said in the documentation.
Please, improve.

NavigationTest.zip

208 KB

Download

Comments

ja...@gmail.com <ja...@gmail.com> #2Feb 24, 2019 06:50PM

Some movements happening on KAPT with regards to this:

https://github.com/JetBrains/kotlin/pull/2179

la...@gmail.com <la...@gmail.com> #3Feb 24, 2019 07:34PM

Yes, kapt incremental compilation support is available since 1.3.40-dev-795
Is there already some plan to add support to Room?

ja...@gmail.com <ja...@gmail.com> #4Feb 25, 2019 07:22AM

#3 incremental kapt is available in 1.3.30 released yesterday too.

il...@google.com <il...@google.com> Feb 25, 2019 08:49PM

Assigned to il...@google.com.

il...@google.com <il...@google.com> #5Feb 25, 2019 11:46PM

Accepted by il...@google.com.

Is there already some ETA?

ap...@google.com <ap...@google.com> #6Feb 26, 2019 12:33AM

We are working on it and aiming for Room 2.2

il...@google.com <il...@google.com> #7Feb 26, 2019 12:36AM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit e4fbb7fb77a4789ab40bff03cc131479779d3e69
Author: Daniel Santiago Rivera <danysantiago@google.com>
Date: Tue Apr 09 23:20:59 2019

Create integration test for Room that uses gradle test kit.

Useful for testing Room incremental annotation processing in Gradle.

Also consolidated some of the path definitions in various build.gradle
into methods in buildSrc/SupportConfig.

Bug: 112110217
Test: ./gradlew room:integration-tests:room-i-a-p:test
Change-Id: I34f6772675712c6edd500e9149ab7f21ade4f012

M buildSrc/src/main/kotlin/androidx/build/SupportConfig.kt
M lifecycle/integration-tests/incrementality/build.gradle
M navigation/safe-args-gradle-plugin/build.gradle
A room/integration-tests/incremental-annotation-processing/build.gradle
A room/integration-tests/incremental-annotation-processing/src/test/data/simple-project/src/main/AndroidManifest.xml
A room/integration-tests/incremental-annotation-processing/src/test/data/simple-project/src/main/java/room/testapp/TestDao.java
A room/integration-tests/incremental-annotation-processing/src/test/data/simple-project/src/main/java/room/testapp/TestDatabase.java
A room/integration-tests/incremental-annotation-processing/src/test/data/simple-project/src/main/java/room/testapp/TestEntity.java
A room/integration-tests/incremental-annotation-processing/src/test/kotlin/androidx/room/gradle/CompileTest.kt
M settings.gradle

https://android-review.googlesource.com/941741

https://goto.google.com/android-sha1/e4fbb7fb77a4789ab40bff03cc131479779d3e69

ja...@gmail.com <ja...@gmail.com> #8Feb 26, 2019 03:16PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit a68222dc929ae5e2a3445f9df69a63636854852e
Author: Hung Nguyen <hungnv@google.com>
Date: Fri Mar 29 11:39:50 2019

Prepare Room for incremental annotation processing.

In Java projects, with non-incremental annotation processing, the inputs
to an annotation processor includes only Java source files.

With incremental annotation processing, however, the inputs may include
both Java source files and class files (to avoid recompiling source
files that haven't changed).

Therefore, all Room annotations need to have retention policy CLASS or
RUNTIME (not SOURCE), so that Room can find the elements annotated with
those annotations from class files. This requirement is also stated at

https://docs.gradle.org/current/userguide/java_plugin.html#sec:incremental_annotation_processing.

Bug: 112110217
Test: Existing tests + New AnnotationRetentionPolicyTest
Change-Id: I1e3a433bf69503ef15cfc2e53cbe97616a6f13b8

M room/common/api/2.2.0-alpha01.txt
M room/common/api/current.txt
M room/common/build.gradle
M room/common/src/main/java/androidx/room/ColumnInfo.java
M room/common/src/main/java/androidx/room/ForeignKey.java
M room/common/src/main/java/androidx/room/OnConflictStrategy.java
M room/common/src/main/java/androidx/room/Update.java
A room/common/src/test/java/androidx/room/AnnotationRetentionPolicyTest.kt

https://android-review.googlesource.com/958284

https://goto.google.com/android-sha1/a68222dc929ae5e2a3445f9df69a63636854852e