UP action doesn't work if a destination was started as implicit deeplink [126082008]

Fixed

Bug

Status Update

No update yet.

Description

ja...@gmail.com

created issue #1

Feb 24, 2019 06:37PM

Component used: Navigation
Version used: 1.0.0-rc01
Devices/Android versions reproduced on: 7.0, 9.0 (Emulators)

According to

https://developer.android.com/topic/libraries/architecture/navigation/navigation-deep-link ,
if a destination is opened with IMPLICIT deeplink and WITHOUT Intent.FLAG_ACTIVITY_NEW_TASK flag, then the destination is opened in the same task. After that if user clicks UP, then the actual parent should be recreated in a separate task, but it doesn't work. The UP button in this case does nothing, as well as manual navigateUp() method call.

I tried to modify the code to check both Toolbar and ActionBar approaches and also tried to create the NavHostFragment via xml and code. In all this cases, the behavior of UP button remained the same.

I attached a simple project that shows this situation. It contains 2 modules:
- app - an app with 2 fragments (root and child). The child fragment's destination supports a deeplink.
- deeplinkstarter - one button app, that starts an implicit deeplink to the child fragment of the 'app'.

I consider this as major defect because the library doesn't behave as it is explicitly said in the documentation.
Please, improve.

NavigationTest.zip

208 KB

Download

Comments

ja...@gmail.com <ja...@gmail.com> #2Feb 24, 2019 06:50PM

Hi. Thanks for reporting this. Fixed in this changelist. This should be available in alpha-04

la...@gmail.com <la...@gmail.com> #3Feb 24, 2019 07:34PM

Project: platform/frameworks/support
Branch: androidx-main

commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Mon Jan 02 15:27:40 2023

fix: tab row crashes when only 1 tab is added

Bug:

b/264018028

Test: Added unit test

Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f

M tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt

https://android-review.googlesource.com/2373449

ja...@gmail.com <ja...@gmail.com> #4Feb 25, 2019 07:22AM

deleted

il...@google.com <il...@google.com> Feb 25, 2019 08:49PM

Assigned to il...@google.com.

il...@google.com <il...@google.com> #5Feb 25, 2019 11:46PM

Accepted by il...@google.com.

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.tv:tv-material:1.0.0-alpha04

ap...@google.com <ap...@google.com> #6Feb 26, 2019 12:33AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 781d0178da33d84f615b409b17975c8ba290401c
Author: Ian Lake <ilake@google.com>
Date: Mon Feb 25 15:38:23 2019

Fix navigateUp() logic when on another app's task

When using deep linking on another app's task,
only the final destination is created, ensuring that
hitting the system back button goes back to the
other app. The Up button, via navigateUp(), should
take users to your own task on the parent destination.

Recent changes made it so that we always add the
parent NavGraphs to the back stack, meaning the simple
check of back stack size == 1 does not properly handle
this change in behavior so instead we need to check for
the number of non-NavGraph destinations on the back
stack.

Test: new NavControllerActivityTest
BUG: 126082008
Change-Id: I7bf18d38e1cdd3818e7414ba44d84df0abd81b88

M navigation/runtime/src/androidTest/AndroidManifest.xml
A navigation/runtime/src/androidTest/java/androidx/navigation/NavControllerActivityTest.kt
M navigation/runtime/src/main/java/androidx/navigation/NavController.java

https://android-review.googlesource.com/912258

https://goto.google.com/android-sha1/781d0178da33d84f615b409b17975c8ba290401c

il...@google.com <il...@google.com> #7Feb 26, 2019 12:36AM

Marked as fixed.

A fix will be available in Navigation 1.0.0-rc02. Thanks for reporting it and the great sample app!

ja...@gmail.com <ja...@gmail.com> #8Feb 26, 2019 03:16PM

Thanks, Ian.