UP action doesn't work if a destination was started as implicit deeplink [126082008]

Fixed

Bug

Status Update

No update yet.

Description

ja...@gmail.com

created issue #1

Feb 24, 2019 06:37PM

Component used: Navigation
Version used: 1.0.0-rc01
Devices/Android versions reproduced on: 7.0, 9.0 (Emulators)

According to

https://developer.android.com/topic/libraries/architecture/navigation/navigation-deep-link ,
if a destination is opened with IMPLICIT deeplink and WITHOUT Intent.FLAG_ACTIVITY_NEW_TASK flag, then the destination is opened in the same task. After that if user clicks UP, then the actual parent should be recreated in a separate task, but it doesn't work. The UP button in this case does nothing, as well as manual navigateUp() method call.

I tried to modify the code to check both Toolbar and ActionBar approaches and also tried to create the NavHostFragment via xml and code. In all this cases, the behavior of UP button remained the same.

I attached a simple project that shows this situation. It contains 2 modules:
- app - an app with 2 fragments (root and child). The child fragment's destination supports a deeplink.
- deeplinkstarter - one button app, that starts an implicit deeplink to the child fragment of the 'app'.

I consider this as major defect because the library doesn't behave as it is explicitly said in the documentation.
Please, improve.

NavigationTest.zip

208 KB

Download

Comments

ja...@gmail.com <ja...@gmail.com> #2Feb 24, 2019 06:50PM

What about Enums? Enum is a type-safe way to pass navigation arguments.
Will Enums be covered in this issue as part of Serializable or will have own handled separately?
Because for enum you can provide a reasonable default value but for Parcelable or Serializable only @null

la...@gmail.com <la...@gmail.com> #3Feb 24, 2019 07:34PM

Please add support for Serializable objects so Enums can be used.

ja...@gmail.com <ja...@gmail.com> #4Feb 25, 2019 07:22AM

Support of Serializable objects is not enough for enums, you definitely need also the support of default values.

il...@google.com <il...@google.com> Feb 25, 2019 08:49PM

Assigned to il...@google.com.

il...@google.com <il...@google.com> #5Feb 25, 2019 11:46PM

Accepted by il...@google.com.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 6f59e3d74d0da5a4bf79c8480f56964e3af47f1c
Author: Wojtek Kaliciński <wkal@google.com>
Date: Mon Jul 23 20:17:19 2018

Support more types for args

Provides support for Serializable, enums,
as well as arrays of primitive types and Parcelables
in Navigation arguments.

Only enums support default values other than @null,
in the form of the enum literal (without class name),
e.g. app:defaultValue="READ"

Test: unit tests updated
BUG: 111487504
BUG: 111316353
Change-Id: I7e5abbc8ed0950bfdef292342dbe1fb34a5c4b17

M navigation/runtime/src/androidTest/java/androidx/navigation/NavInflaterTest.kt
A navigation/runtime/src/androidTest/java/androidx/navigation/test/TestEnum.java
M navigation/runtime/src/androidTest/res/navigation/nav_default_arguments.xml
M navigation/runtime/src/main/java/androidx/navigation/NavInflater.java
M navigation/safe-args-generator/src/main/kotlin/androidx/navigation/safe/args/generator/NavParser.kt
M navigation/safe-args-generator/src/main/kotlin/androidx/navigation/safe/args/generator/NavParserErrors.kt
M navigation/safe-args-generator/src/main/kotlin/androidx/navigation/safe/args/generator/NavWriter.kt
M navigation/safe-args-generator/src/main/kotlin/androidx/navigation/safe/args/generator/Types.kt
M navigation/safe-args-generator/src/tests/kotlin/androidx/navigation/safe/args/generator/NavParserTest.kt
M navigation/safe-args-generator/src/tests/kotlin/androidx/navigation/safe/args/generator/NavWriterTest.kt
M navigation/safe-args-generator/src/tests/test-data/expected/nav_writer_test/MainFragmentArgs.java
M navigation/safe-args-generator/src/tests/test-data/expected/nav_writer_test/Next.java
M navigation/safe-args-generator/src/tests/test-data/naive_test.xml

https://android-review.googlesource.com/720246

https://goto.google.com/android-sha1/6f59e3d74d0da5a4bf79c8480f56964e3af47f1c

ap...@google.com <ap...@google.com> #6Feb 26, 2019 12:33AM

This is fixed internally and will be available in 1.0.0-alpha08

il...@google.com <il...@google.com> #7Feb 26, 2019 12:36AM

Marked as fixed.

What happened if I declaire app:argType="androidx.navigation.test.TestEnum" and turn on proguard/R8? Because both ProGuard and R8 will optimize trivial enums into ints.

ja...@gmail.com <ja...@gmail.com> #8Feb 26, 2019 03:16PM

Since you need to explicitly keep argTypes as per

https://issuetracker.google.com/issues/122634648, they'll be kept.