applyPopAnimationsToPendingTransition doesn't apply the pop exit anim [126237567]

Fixed

Bug

Status Update

No update yet.

Description

il...@google.com

created issue #1

Feb 25, 2019 10:01PM

Component used: Navigation
Version used: 1.0.0-rc01

From

https://issuetracker.google.com/issues/79957185#comment7

Regarding this issue, as of 1.0.0-rc01, popEnterAnim works but popExitAnim doesn't. I was curious why, and noticed there is a small typo in the source code here:

https://github.com/aosp-mirror/platform_frameworks_support/blob/androidx-master-dev/navigation/runtime/src/main/java/androidx/navigation/ActivityNavigator.java#L80
it should be EXTRA_POP_EXIT_ANIM instead of EXTRA_POP_ENTER_ANIM.
Don't think that'll fix the issue, but it's still a small fix

Comments

ap...@google.com <ap...@google.com> #2Feb 26, 2019 12:32AM

apologies, i meant "navigate(To...)"

il...@google.com <il...@google.com> #3Feb 26, 2019 12:35AM

Marked as fixed.

Yep, it appears that navigateUp() returns true, even when nothing visually changes on the screen. This seems to be caused by popBackStack(), which is always returning true even when popping the root Fragment.

Issue 126237567

Description

Issue summary

Comments

ap...@google.com <ap...@google.com> #2Feb 26, 2019 12:32AM

il...@google.com <il...@google.com> #3Feb 26, 2019 12:35AM

Add comment

Issue metadata