applyPopAnimationsToPendingTransition doesn't apply the pop exit anim [126237567]

Fixed

Bug

Status Update

No update yet.

Description

il...@google.com

created issue #1

Feb 25, 2019 10:01PM

Component used: Navigation
Version used: 1.0.0-rc01

From

https://issuetracker.google.com/issues/79957185#comment7

Regarding this issue, as of 1.0.0-rc01, popEnterAnim works but popExitAnim doesn't. I was curious why, and noticed there is a small typo in the source code here:

https://github.com/aosp-mirror/platform_frameworks_support/blob/androidx-master-dev/navigation/runtime/src/main/java/androidx/navigation/ActivityNavigator.java#L80
it should be EXTRA_POP_EXIT_ANIM instead of EXTRA_POP_ENTER_ANIM.
Don't think that'll fix the issue, but it's still a small fix

Comments

ap...@google.com <ap...@google.com> #2Feb 26, 2019 12:32AM

This has been fixed internally in

https://android-review.googlesource.com/870975 and will be available in Navigation 1.0.0-alpha10.

Now, instead of crashing, we ignore invalid deep links, printing a log message saying as much.

il...@google.com <il...@google.com> #3Feb 26, 2019 12:35AM

Marked as fixed.

Hi team.
The problem still occurs on version 2.2.0-rc04

Issue 126237567

Description

Issue summary

Comments

ap...@google.com <ap...@google.com> #2Feb 26, 2019 12:32AM

il...@google.com <il...@google.com> #3Feb 26, 2019 12:35AM

Add comment

Issue metadata