applyPopAnimationsToPendingTransition doesn't apply the pop exit anim [126237567] - Issue Tracker

Android Public Tracker >

App Development >

Jetpack (androidx) >

applyPopAnimationsToPendingTransition doesn't apply the pop exit anim

Fixed

Bug

P1

Status Update

No update yet.

Description

il...@google.com

created issue #1

Feb 25, 2019 10:01PM

Component used: Navigation
Version used: 1.0.0-rc01

From

https://issuetracker.google.com/issues/79957185#comment7

Regarding this issue, as of 1.0.0-rc01, popEnterAnim works but popExitAnim doesn't. I was curious why, and noticed there is a small typo in the source code here:

https://github.com/aosp-mirror/platform_frameworks_support/blob/androidx-master-dev/navigation/runtime/src/main/java/androidx/navigation/ActivityNavigator.java#L80
it should be EXTRA_POP_EXIT_ANIM instead of EXTRA_POP_ENTER_ANIM.
Don't think that'll fix the issue, but it's still a small fix

Comments

ap...@google.com <ap...@google.com> #2Feb 26, 2019 12:32AM

The fix: https://github.com/androidx/androidx/pull/212

il...@google.com <il...@google.com> #3Feb 26, 2019 12:35AM

Marked as fixed.

Amended the behavior slightly to find the best match from the requested style.

Reporter

il...@google.com

Type

Priority

Severity

Status

Access

Default access

View

Expanded Access

Assignee

jb...@google.com

Verifier

--

Collaborators

CC

an...@google.com

il...@google.com

Code Changes

--

Pending Code Changes

--

Staffing

--

AOSP ID

--

Estimate

--

Found In

--

Targeted To

--

Verified In

--

In Prod

ReportedBy