popUpTo with root of graph doesn't work if the graph doesn't have an ID [126251695]

Fixed

Bug

Status Update

No update yet.

Description

il...@google.com

created issue #1

Feb 25, 2019 11:32PM

Component used: Navigation
Version used: 1.0.0-rc01

When doing a navigate() call that is supposed to pop the root of the graph (i.e.,

navController.graph.id), it doesn't actually pop anything if the graph doesn't have an ID - i.e., id is 0.

Comments

il...@google.com <il...@google.com> #2Feb 25, 2019 11:33PM

Accepted by il...@google.com.

Great

ap...@google.com <ap...@google.com> #3Feb 26, 2019 12:33AM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit a735aaa4d06c90454de772fae5a02f6cbde210b3
Author: Jeremy Woods <jbwoods@google.com>
Date: Tue Feb 28 22:58:23 2023

Ensure FragmentNavigator destroys intermediate entries on popUpTo

We need to make sure that when Fragment are destroyed their entries are
also always destroyed.

RelNote: "Fixes a regressions in previous release that caused the wrong
BottomNav menu item to be highlighted when using system back to go
between tabs."
Test: Added FragmentNavigatorTest
Bug: 270447657

Change-Id: I634f6047b7016bcb8b690047605a6f66b2dc1438

M navigation/navigation-fragment/src/androidTest/java/androidx/navigation/fragment/FragmentNavigatorTest.kt
M navigation/navigation-fragment/src/main/java/androidx/navigation/fragment/FragmentNavigator.kt

https://android-review.googlesource.com/2461556

il...@google.com <il...@google.com> #4Feb 26, 2019 12:36AM

This has been fixed internally and will be available in the Navigation 2.6.0-alpha07 release.

Issue 126251695

Description

Issue summary

Comments

il...@google.com <il...@google.com> #2Feb 25, 2019 11:33PM

ap...@google.com <ap...@google.com> #3Feb 26, 2019 12:33AM

il...@google.com <il...@google.com> #4Feb 26, 2019 12:36AM

Add comment

Issue metadata