Testing with Robolectric 4.0 on DataBinding enabled lib modules will throw `java.lang.NoClassDefFoundError: androidx/databinding/DataBinderMapperImpl` [126775542]

Fixed

Bug

Reviewed (L1)

Status Update

No update yet.

Description

[Deleted User]

created issue #1

Mar 1, 2019 02:44AM

Running the exact Instrumentation tests and robolectric tests will yield different result if databinding is enabled on library modules. Currently the same exception is not thrown for `app` modules.

Sample repo:

https://github.com/malvinstn/Robolectric-Databinding-Lib/tree/master

To reproduce:

- Run `ConnectedMainActivityTest` = OK
- Run `MainActivityTest` = OK
- Run `ConnectedLibActivityTest` = OK
- Run `LibActivityTest` = Error

------
Build: $VERSION, AI-183.5429.30.34.5310756, 201902141945,

AI-183.5429.30.34.5310756, JRE 1.8.0_152-release-1248-b22x64 JetBrains s.r.o, OS Mac OS X(x86_64) v10.14, screens 1680x1050, 1920x1080; Retina

Android Gradle Plugin: 3.4.0-beta05
Gradle: 5.1.1
NDK: from local.properties: (not specified); latest from SDK: (not found);
LLDB: pinned revision 3.1 not found; latest from SDK: (package not found);
CMake: from local.properties: (not specified); latest from SDK: (not found); from PATH: (not found);

IMPORTANT: Please read

https://developer.android.com/studio/report-bugs.html carefully and supply all required information.

Comments

da...@google.com <da...@google.com> #2Mar 1, 2019 04:11AM

./gradlew :app:lintDebug --no-daemon is used for running lint. But Android Studio also doesn't show any error on expected lines.

Message last modified on Mar 5, 2019 10:20PM

[Deleted User] <[Deleted User]> #3Mar 1, 2019 05:43AM

I opened a PR to improve NonNullableMutableLiveDataDetector's type references check.

https://github.com/androidx/androidx/pull/161

ju...@gmail.com <ju...@gmail.com> #4Mar 1, 2019 05:47AM

Project: platform/frameworks/support
Branch: androidx-main

commit 655e08dca6e27aa15c862132914cb61b0ec29fdf
Author: Sinan Kozak <kozaxinan@gmail.com>
Date: Wed May 05 16:38:12 2021

[GH] [Lifecycle] [Lint] fixes

b/184830263

Lint should use check reference too

## Proposed Changes

- Fix NonNullableMutableLiveDataDetector for [different cases](

https://issuetracker.google.com/issues/184830263). It is possible to only set type reference and omit call's generic argument.
- Added check for generic values because default upper bound of generic (if none specified) is Any?. If generic is not specified as `<T : Any>`, `T` can be defined null at call site.

https://kotlinlang.org/docs/generics.html#upper-bounds

## Testing

Test: Run NonNullableMutableLiveDataDetectorTest with new edge cases.
`nullLiteralFailMultipleFields` : Added type reference
`justKotlinObject` : Add additional test to prevent ArrayIndexOutOfBoundsException. It is fixed in

https://github.com/androidx/androidx/commit/428f0ec685ff80035c0511c0cdb12b9770b6159c but not tested. It is reported here with [

b/184830262

](

https://issuetracker.google.com/issues/184830262)
`genericParameterDefinition` : Generics are assumed as nullable, lint should ignore.

## Issues Fixed

Fixes: The bug on [

b/184830263

](

https://issuetracker.google.com/issues/184830263) being fixed
Fixes: Tests [

b/184830262

](

https://issuetracker.google.com/issues/184830263)

This is an imported pull request from

https://github.com/androidx/androidx/pull/161.

Resolves #161
Github-Pr-Head-Sha: e96b4a8e860002feccd455e9ad8dcdd868dff2df
GitOrigin-RevId: eb21c2ef19da5465be438c928d9b6ba2498b72e8
Change-Id: Id6cd01e9ec6b79a3f14b569b53d79627c79b9866

M lifecycle/lifecycle-livedata-core-ktx-lint/src/main/java/androidx/lifecycle/lint/NonNullableMutableLiveDataDetector.kt
M lifecycle/lifecycle-livedata-core-ktx-lint/src/test/java/androidx/lifecycle/lint/NonNullableMutableLiveDataDetectorTest.kt

https://android-review.googlesource.com/1697465

[Deleted User] <[Deleted User]> #5Mar 1, 2019 08:34AM

[Deleted User] <[Deleted User]> #6Mar 3, 2019 10:24PM

that works - no ideal, but works, thanks!

uc...@google.com <uc...@google.com> Mar 5, 2019 07:15PM

Assigned to da...@google.com.

da...@google.com <da...@google.com> #7Mar 5, 2019 10:50PM

Gradle folks, when we enabled data binding in the Gradle plugin, I assume it's responsible for contributing generated data binding classes to the classpath. Should this also work when running tests? It seems like this is just a classpath issue.

je...@google.com <je...@google.com> Mar 5, 2019 10:52PM

Reassigned to hu...@google.com.

pa...@gmail.com <pa...@gmail.com> #8Mar 7, 2019 02:15PM

Another possible workaround is to create a class DataBinderMapperImpl in androidx.databinding package in a separate module. Add this module as a dependency using testImplementation configuration.

Here is how DataBinderMapperImpl would look like:

https://github.com/annypatel/databinding-test/blob/master/binding-mapper/src/main/java/androidx/databinding/DataBinderMapperImpl.kt

hu...@google.com <hu...@google.com> #9Mar 26, 2019 06:08PM

Thanks a lot for the sample project, it is very useful.

I have sent out a fix for review: Change-Id: I4f0c802764729a415b968520c75fa052671b646c

[Deleted User] <[Deleted User]> #10Mar 27, 2019 02:04AM

Hi, thanks a lot!
Is there any chance that this will be included in the next canary release?

hu...@google.com <hu...@google.com> #11Mar 27, 2019 06:35PM

It won't be in the next immediate canary release. I'll update this bug when I know what release it will be in.

[Deleted User] <[Deleted User]> #12May 23, 2019 05:15AM

Hi, any update for this issue? We noticed that in the latest beta of 3.5. It breaks even the DataBinding test inside lib modules. :/

hu...@google.com <hu...@google.com> #13May 24, 2019 04:28PM

This issue was almost fixed, but then a new feature was introduced in the mean time (generating R classes directly in R.jar without generating R.java sources), and the current fix is not enough. We are working on fixing that.

[Deleted User] <[Deleted User]> #14Jun 26, 2019 11:47PM

A beer for whoever fixes this thing, next time they come to Sydney!

hu...@google.com <hu...@google.com> #15Jul 16, 2019 09:26AM

@14: That sounds good. The new fix is ready, we'll likely to close this bug within a week or two.

[Deleted User] <[Deleted User]> #16Jul 17, 2019 01:42AM

@15: excellent - ping me when ready to collect :D

hu...@google.com <hu...@google.com> #17Jul 24, 2019 09:32AM

Marked as fixed.

We have fixed this issue:

https://android.googlesource.com/platform/tools/base/+/538c140511065ec5ca30d67e40a000f45d9be515

It will be available in AGP 3.6.0-alpha07.

Thanks for this report (and the beer promise)! :)

[Deleted User] <[Deleted User]> #18Jul 24, 2019 09:45AM

Thank you so much! Cheers!! :DD

[Deleted User] <[Deleted User]> #19Jul 25, 2019 12:12AM

yay! looking forward to test driving the fix

ka...@gmail.com <ka...@gmail.com> #20Oct 2, 2019 10:39AM

I needed to add kaptTest "androidx.databinding:databinding-compiler:3.6.0-alpha07" to get it working

ma...@cyberagent.co.jp <ma...@cyberagent.co.jp> #21Oct 30, 2019 03:22AM

I also needed to add kaptAndroidTest "androidx.databinding:databinding-compiler:x.x.x" to get it working.
It seems that when we have other kapt tasks (dagger, et al.), then this error occurred in the unitTest and androidTest.
Test with (AS 4.0 alpha 01).

hu...@google.com <hu...@google.com> #22Oct 31, 2019 11:30AM

@20, 21: This sounds like a different issue, please file a new bug with us.

Message last modified on Mar 9, 2021 09:38PM

ch...@gmail.com <ch...@gmail.com> #23Nov 1, 2019 04:23AM

FYI, we still need to `kaptTest "androidx.databinding:databinding-compiler:3.6.0-beta02"` when using Kotlin.

hu...@google.com <hu...@google.com> #24Nov 1, 2019 10:49AM

@20, 21, 23: Ah, that seems to be a duplicate of

Issue 117145132

, where the root cause has been tracked to this Kotlin issue (not yet fixed):

https://youtrack.jetbrains.com/issue/KT-27404.

Message last modified on Mar 9, 2021 09:38PM

ma...@gmail.com <ma...@gmail.com> #25Jun 8, 2020 09:44AM

Is this fix available on newer AGP versions like 3.6.3? Because when I try this on that I still get the same error.

da...@google.com <da...@google.com> #26Jun 8, 2020 05:29PM

Comment #25, note that the team member who works on this is OOO for a few days and may not respond for a little while. According to the comments above, yes, AGP 3.6.3 should include the fix.

Do you have repro steps? Just to help ensure that this is, in fact, the same issue reported here? There might be multiple paths to produce the same error, etc. etc. If you're certain it's the same issue as here, then repro steps will help us determine if we should reopen this. Otherwise, it might be best to file a new bug since this one seems to have quite a bit of history on it.

Meanwhile, there are 20 +1's on this bug. Can anyone else who was experiencing this report that it was actually fixed for them starting in 3.6.0?

Thanks! David

sa...@dfarooq.com <sa...@dfarooq.com> #27Mar 4, 2021 07:35PM

Hey David,

I think this may have regressed. I created a fork of the original sample project with AGP 4.1.2.

https://github.com/saadfarooq/Robolectric-Databinding-Lib

The Robolectric test fails with the same error. If kotlin-kapt plugin is removed, the test passes. But then the buildFeatures databinding config says If you plan to use data binding in a Kotlin project, you should apply the kotlin-kapt plugin.

So possibly something to do with kapt?

Message last modified on Mar 4, 2021 07:37PM

da...@google.com <da...@google.com> #28Mar 4, 2021 08:04PM

Status: Assigned (reopened)

Ooof :) Hung, are you swamped? Would you be able to take a look?

da...@google.com <da...@google.com> #29Mar 4, 2021 08:06PM

Comment #27, in the meanwhile, it may be worth trying things out with a more recent version of AGP (e.g. using beta or canary) to see if this remains broken after 4.1.2, or if this was a temporary regression.

Hung: I meant to say, I reopned this bug, but if it ends up being a different cause, or just because this bug already has so much history, feel free to reclose it and create a new one.

sa...@dfarooq.com <sa...@dfarooq.com> #30Mar 4, 2021 11:56PM

I tried 4.2.0-beta05 and 7.0.0-alpha8 in Arctic Fox Canary 08 and the behavior is the same. Remove kapt, test passes. Added it back, get the NoClassDefFound error.

hu...@google.com <hu...@google.com> #31Mar 9, 2021 09:56PM