Fixed
Status Update
No update yet.
Comments
il...@google.com
il...@google.com
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit e005db789e4c6b6c75fb8ca03a0c4e326868fb91
Author: Jeremy Woods <jbwoods@google.com>
Date: Wed Sep 02 14:20:41 2020
Move nav_default animation out of animation sets
All of the nav_default animations are simple fades and do not need to be
inside of a animation set. Moving them out also ensures that if they are
placed in an additional set (i.e. like the new fragment state manager
does to listen for when the animation finishes) they will not flash.
Bug: 167430145
Test: Tested in sample app
Change-Id: I071e922a52301863ba2461ff05b60bb64566430c
M navigation/navigation-ui/src/main/res/anim/nav_default_enter_anim.xml
M navigation/navigation-ui/src/main/res/anim/nav_default_exit_anim.xml
M navigation/navigation-ui/src/main/res/anim/nav_default_pop_enter_anim.xml
M navigation/navigation-ui/src/main/res/anim/nav_default_pop_exit_anim.xml
https://android-review.googlesource.com/1418719
Branch: androidx-master-dev
commit e005db789e4c6b6c75fb8ca03a0c4e326868fb91
Author: Jeremy Woods <jbwoods@google.com>
Date: Wed Sep 02 14:20:41 2020
Move nav_default animation out of animation sets
All of the nav_default animations are simple fades and do not need to be
inside of a animation set. Moving them out also ensures that if they are
placed in an additional set (i.e. like the new fragment state manager
does to listen for when the animation finishes) they will not flash.
Bug: 167430145
Test: Tested in sample app
Change-Id: I071e922a52301863ba2461ff05b60bb64566430c
M navigation/navigation-ui/src/main/res/anim/nav_default_enter_anim.xml
M navigation/navigation-ui/src/main/res/anim/nav_default_exit_anim.xml
M navigation/navigation-ui/src/main/res/anim/nav_default_pop_enter_anim.xml
M navigation/navigation-ui/src/main/res/anim/nav_default_pop_exit_anim.xml
il...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 1e9ed84322fddd9228df1f96bc8cb76748e0a4fe
Author: Jeremy Woods <jbwoods@google.com>
Date: Fri Sep 11 15:58:27 2020
Add nav default animator resources
Animators are recommeneded over Animations for doing effects in fragment
and Navigation. We need to make default animator resources for
Navigation.
Test: Tested in sample apps
Bug: 167430145
Change-Id: I904d78268d8b8574c799ae1b0f5887e518fdb5f6
M navigation/navigation-ui/src/main/java/androidx/navigation/ui/NavigationUI.java
M navigation/navigation-ui/src/main/res-public/values/public_anim.xml
A navigation/navigation-ui/src/main/res/animator/nav_default_enter_anim.xml
A navigation/navigation-ui/src/main/res/animator/nav_default_exit_anim.xml
A navigation/navigation-ui/src/main/res/animator/nav_default_pop_enter_anim.xml
A navigation/navigation-ui/src/main/res/animator/nav_default_pop_exit_anim.xml
https://android-review.googlesource.com/1424849
Branch: androidx-master-dev
commit 1e9ed84322fddd9228df1f96bc8cb76748e0a4fe
Author: Jeremy Woods <jbwoods@google.com>
Date: Fri Sep 11 15:58:27 2020
Add nav default animator resources
Animators are recommeneded over Animations for doing effects in fragment
and Navigation. We need to make default animator resources for
Navigation.
Test: Tested in sample apps
Bug: 167430145
Change-Id: I904d78268d8b8574c799ae1b0f5887e518fdb5f6
M navigation/navigation-ui/src/main/java/androidx/navigation/ui/NavigationUI.java
M navigation/navigation-ui/src/main/res-public/values/public_anim.xml
A navigation/navigation-ui/src/main/res/animator/nav_default_enter_anim.xml
A navigation/navigation-ui/src/main/res/animator/nav_default_exit_anim.xml
A navigation/navigation-ui/src/main/res/animator/nav_default_pop_enter_anim.xml
A navigation/navigation-ui/src/main/res/animator/nav_default_pop_exit_anim.xml
Description
Currently, the `Navigation` class has 2 signatures for `createNavigateOnClickListener`:
`createNavigateOnClickListener(final int resId)`
`createNavigateOnClickListener(final int resId, finalBundle args)`
I propose a third overload:
`createNavigateOnClickListener(NavDirections)`
This overload could trampoline to the other two, as necessary, but it would allow for users to avoid having to manually extract the ActionID and Bundle from the NavDirections. It would be a nicety on top of an already nice library :)