Fixed
Status Update
No update yet.
Comments
il...@google.com
il...@google.com
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 44991c9a6f7d832decb7a19b9d795f8644bc8503
Author: jbwoods <jbwoods@google.com>
Date: Fri Mar 15 10:58:23 2019
Add NavDirections overload for createOnClickListener in Navigation
Gives developers the convenient option of just passing navDirections to
createOnClickListener instead of manually exactings the ActionID and
Bundle.
Test: ./gradlew checkApi
BUG: 127631752
Change-Id: Icfc3762570ccf5efac83afc0375cbdb8c0acee11
M navigation/runtime/api/2.1.0-alpha01.txt
M navigation/runtime/api/current.txt
M navigation/runtime/src/main/java/androidx/navigation/Navigation.java
https://android-review.googlesource.com/930453
https://goto.google.com/android-sha1/44991c9a6f7d832decb7a19b9d795f8644bc8503
Branch: androidx-master-dev
commit 44991c9a6f7d832decb7a19b9d795f8644bc8503
Author: jbwoods <jbwoods@google.com>
Date: Fri Mar 15 10:58:23 2019
Add NavDirections overload for createOnClickListener in Navigation
Gives developers the convenient option of just passing navDirections to
createOnClickListener instead of manually exactings the ActionID and
Bundle.
Test: ./gradlew checkApi
BUG: 127631752
Change-Id: Icfc3762570ccf5efac83afc0375cbdb8c0acee11
M navigation/runtime/api/2.1.0-alpha01.txt
M navigation/runtime/api/current.txt
M navigation/runtime/src/main/java/androidx/navigation/Navigation.java
il...@google.com
This has been added internally and will be available in Navigation 2.1.0-alpha01
Description
Currently, the `Navigation` class has 2 signatures for `createNavigateOnClickListener`:
`createNavigateOnClickListener(final int resId)`
`createNavigateOnClickListener(final int resId, finalBundle args)`
I propose a third overload:
`createNavigateOnClickListener(NavDirections)`
This overload could trampoline to the other two, as necessary, but it would allow for users to avoid having to manually extract the ActionID and Bundle from the NavDirections. It would be a nicety on top of an already nice library :)