Fixed
Status Update
No update yet.
Comments
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 1e5efa0794e826bc1b3b153796ed5659fb97fca2
Author: Ian Lake <ilake@google.com>
Date: Fri Feb 08 10:23:54 2019
Prefer exact matching deep links
Instead of only taking into account the
number of matching arguments for deep link
matching, always prefer exact matches.
Test: updated tests
BUG: 123969518
Change-Id: Ibd8ab5b6ba251991fa994ebd297bcb9ffb5851bd
M navigation/common/src/androidTest/java/androidx/navigation/NavDestinationAndroidTest.kt
M navigation/common/src/androidTest/java/androidx/navigation/NavGraphAndroidTest.kt
M navigation/common/src/main/java/androidx/navigation/NavDeepLink.java
M navigation/common/src/main/java/androidx/navigation/NavDestination.java
https://android-review.googlesource.com/898367
https://goto.google.com/android-sha1/1e5efa0794e826bc1b3b153796ed5659fb97fca2
Branch: androidx-master-dev
commit 1e5efa0794e826bc1b3b153796ed5659fb97fca2
Author: Ian Lake <ilake@google.com>
Date: Fri Feb 08 10:23:54 2019
Prefer exact matching deep links
Instead of only taking into account the
number of matching arguments for deep link
matching, always prefer exact matches.
Test: updated tests
BUG: 123969518
Change-Id: Ibd8ab5b6ba251991fa994ebd297bcb9ffb5851bd
M navigation/common/src/androidTest/java/androidx/navigation/NavDestinationAndroidTest.kt
M navigation/common/src/androidTest/java/androidx/navigation/NavGraphAndroidTest.kt
M navigation/common/src/main/java/androidx/navigation/NavDeepLink.java
M navigation/common/src/main/java/androidx/navigation/NavDestination.java
ap...@google.com
This is fixed internally and will be available in Navigation 1.0.0-beta02 - we'll always prefer an exact deep match link (where exact means your deep link does not contain any .* or {param} tags)
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit e4aebd475e161a64e7ae13e9f060c0384f741e17
Author: Ian Lake <ilake@google.com>
Date: Thu Mar 14 16:09:16 2019
Use shared ANDROIDX_COLLECTION dependency version
Instead of Navigation keeping its own dependency
version for collection, use the general
ANDROIDX_COLLECTION dependency variable.
Test: ./gradlew bOS
BUG: 128632612
Change-Id: Ia6d47d266daa005f78db91cebcb6374af4b86c19
M buildSrc/src/main/kotlin/androidx/build/dependencies/Dependencies.kt
M navigation/common/build.gradle
M navigation/common/ktx/build.gradle
https://android-review.googlesource.com/929946
https://goto.google.com/android-sha1/e4aebd475e161a64e7ae13e9f060c0384f741e17
Branch: androidx-master-dev
commit e4aebd475e161a64e7ae13e9f060c0384f741e17
Author: Ian Lake <ilake@google.com>
Date: Thu Mar 14 16:09:16 2019
Use shared ANDROIDX_COLLECTION dependency version
Instead of Navigation keeping its own dependency
version for collection, use the general
ANDROIDX_COLLECTION dependency variable.
Test: ./gradlew bOS
BUG: 128632612
Change-Id: Ia6d47d266daa005f78db91cebcb6374af4b86c19
M buildSrc/src/main/kotlin/androidx/build/dependencies/Dependencies.kt
M navigation/common/build.gradle
M navigation/common/ktx/build.gradle
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 9c678e9b5dd80259ca3906ef13f4ccd52c7c0a93
Author: Ian Lake <ilake@google.com>
Date: Thu Mar 14 16:06:00 2019
Remove core-utils dependency from navigation-runtime
navigation-runtime no longer needs a dependency on
legacy-support-core-utils, so we can remove it.
Test: ./gradlew bOS
BUG: 128632612
Change-Id: I1b6400df0f068c5aa0ccbc4347e8ac284f781d6b
M buildSrc/src/main/kotlin/androidx/build/dependencies/Dependencies.kt
M navigation/runtime/build.gradle
https://android-review.googlesource.com/929945
https://goto.google.com/android-sha1/9c678e9b5dd80259ca3906ef13f4ccd52c7c0a93
Branch: androidx-master-dev
commit 9c678e9b5dd80259ca3906ef13f4ccd52c7c0a93
Author: Ian Lake <ilake@google.com>
Date: Thu Mar 14 16:06:00 2019
Remove core-utils dependency from navigation-runtime
navigation-runtime no longer needs a dependency on
legacy-support-core-utils, so we can remove it.
Test: ./gradlew bOS
BUG: 128632612
Change-Id: I1b6400df0f068c5aa0ccbc4347e8ac284f781d6b
M buildSrc/src/main/kotlin/androidx/build/dependencies/Dependencies.kt
M navigation/runtime/build.gradle
il...@google.com
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 7bbbab7dca4edda160e6b2169d38a25b81698f47
Author: Ian Lake <ilake@google.com>
Date: Fri Mar 15 09:59:23 2019
Centralize MATERIAL dependency
Remove references to SUPPORT_DESIGN and switch
to the full dependency instead of the previously
used @aar dependency.
Also removes the no longer needed exclude_for_material
exclusion since all libraries are now on AndroidX.
Removed ViewPager2 implementation on AppCompat,
replacing it with an androidTestImplementation since it
is not actually used in the library itself. This fixes
an error when including a ToT implementation dependency
along with the fixed dependency from MATERIAL that
appears when switching to the full dependency.
Test: ./gradlew bOS, ran all affected sample apps
Fixes: 128632612
Change-Id: I44579630cdc3eae58fc23924d8c4d45d2d457f2b
M buildSrc/dependencies.gradle
M buildSrc/src/main/kotlin/androidx/build/dependencies/Dependencies.kt
M car/core/build.gradle
M navigation/ui/build.gradle
M samples/SupportContentDemos/build.gradle
M samples/SupportDesignDemos/build.gradle
M viewpager2/build.gradle
M viewpager2/integration-tests/testapp/build.gradle
M work/integration-tests/testapp/build.gradle
https://android-review.googlesource.com/929949
https://goto.google.com/android-sha1/7bbbab7dca4edda160e6b2169d38a25b81698f47
Branch: androidx-master-dev
commit 7bbbab7dca4edda160e6b2169d38a25b81698f47
Author: Ian Lake <ilake@google.com>
Date: Fri Mar 15 09:59:23 2019
Centralize MATERIAL dependency
Remove references to SUPPORT_DESIGN and switch
to the full dependency instead of the previously
used @aar dependency.
Also removes the no longer needed exclude_for_material
exclusion since all libraries are now on AndroidX.
Removed ViewPager2 implementation on AppCompat,
replacing it with an androidTestImplementation since it
is not actually used in the library itself. This fixes
an error when including a ToT implementation dependency
along with the fixed dependency from MATERIAL that
appears when switching to the full dependency.
Test: ./gradlew bOS, ran all affected sample apps
Fixes: 128632612
Change-Id: I44579630cdc3eae58fc23924d8c4d45d2d457f2b
M buildSrc/dependencies.gradle
M buildSrc/src/main/kotlin/androidx/build/dependencies/Dependencies.kt
M car/core/build.gradle
M navigation/ui/build.gradle
M samples/SupportContentDemos/build.gradle
M samples/SupportDesignDemos/build.gradle
M viewpager2/build.gradle
M viewpager2/integration-tests/testapp/build.gradle
M work/integration-tests/testapp/build.gradle
il...@google.com
Navigation now depends on:
- core 1.0.1
- fragment 1.1.0-alpha05 (latest)
- material 1.0.0
And no longer depends on legacy-support-core-utils at all.
- core 1.0.1
- fragment 1.1.0-alpha05 (latest)
- material 1.0.0
And no longer depends on legacy-support-core-utils at all.
Description
Version used: 2.0.0
Devices/Android versions reproduced on:
Now that Navigation depends on AndroidX, we should switch to the latest versions of our dependencies where it makes sense and remove our dependency on the catch all legacy-support-core-utils artifact.