Update dependencies to the latest versions [128632612]

Fixed

Bug

Status Update

No update yet.

Description

il...@google.com

created issue #1

Mar 14, 2019 10:53PM

Component used: Navigation
Version used: 2.0.0
Devices/Android versions reproduced on:

Now that Navigation depends on AndroidX, we should switch to the latest versions of our dependencies where it makes sense and remove our dependency on the catch all legacy-support-core-utils artifact.

Comments

ap...@google.com <ap...@google.com> #2Mar 15, 2019 01:45AM

Using navigation version 2.6.0 and 2.7.1 the issue still persists.

After further investigation, the behaviour can be corrected by filtering on backstack entries where current state is at least started. In my opinion the name visibleEntries is misleading if it contains entries that are not actually visible or in transition.

ap...@google.com <ap...@google.com> #3Mar 15, 2019 02:46AM

Note that as per the visibleEntries documentation, it is expected that there are entries that are in the CREATED state - those are the entries that are in the process of being removed (i.e., they are no longer in the back stack, but have not yet marked their transition as complete).

It is a bug that those entries aren't removed when their exit animation completes and that's what we'll be looking into.

ap...@google.com <ap...@google.com> #4Mar 15, 2019 02:46AM

Project: platform/frameworks/support
Branch: androidx-main

commit f61da31809827bfac89af629c88ad9b8423e88b6
Author: Clara Fok <clarafok@google.com>
Date: Wed Sep 06 14:14:11 2023

Fix entry not marked complete after view is destroyed

As part of a fix for

b/279644470

in aosp/2566210, when the fragment view is destroyed, we would mark the transitioning (outgoing) entry as complete only if the entry has also been removed from backstack. However, in the simple navigate() case where the outgoing entry is not popped and remains in the backstack, this entry is not marked complete and ends up in the visibleEntries even though the view has been destroyed.

Now the backstack check in ON_DESTROY is no longer necessary to fix the original

b/279644470

bug -- the view being destroyed should be the right signal for completing entries regardless of whether transitioning effects are used. So this check is removed.

Test: ./gradlew navigation:navigation-fragment:cC
Test: ./gradlew navigation:navigation-runtime:cC
Bug: 288520638
Change-Id: I5caa9af1b5bd7084e76d7daf9515f7430bf2489d

M navigation/navigation-fragment/src/androidTest/java/androidx/navigation/fragment/FragmentNavigatorTest.kt
M navigation/navigation-fragment/src/androidTest/java/androidx/navigation/fragment/NavControllerWithFragmentTest.kt
M navigation/navigation-fragment/src/main/java/androidx/navigation/fragment/FragmentNavigator.kt
M navigation/navigation-runtime/src/androidTest/java/androidx/navigation/NavControllerTest.kt
M navigation/navigation-runtime/src/main/java/androidx/navigation/NavController.kt

https://android-review.googlesource.com/2743918

ap...@google.com <ap...@google.com> #5Mar 15, 2019 02:46AM

Fixed internally and will be available in navigation 2.7.3

il...@google.com <il...@google.com> Mar 15, 2019 05:12PM

Accepted by il...@google.com.

ap...@google.com <ap...@google.com> #6Mar 15, 2019 10:14PM

Marked as fixed.

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.navigation:navigation-fragment:2.7.3
androidx.navigation:navigation-runtime:2.7.3

il...@google.com <il...@google.com> #7Mar 15, 2019 10:24PM

The issue no longer persists in version 2.7.3. Thank you all for the update.