Fixed
Status Update
Comments
ap...@google.com <ap...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
https://android-review.googlesource.com/1123258
https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
ap...@google.com <ap...@google.com> #3
ap...@google.com <ap...@google.com> #4
Project: platform/frameworks/support
Branch: androidx-master-dev
commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020
Re-factor how errors are dismissed when query is re-written
This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically ( b/140759491 ).
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.
This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.
Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f
M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
https://android-review.googlesource.com/1288456
Branch: androidx-master-dev
commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020
Re-factor how errors are dismissed when query is re-written
This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.
This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.
Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f
M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
ap...@google.com <ap...@google.com> #5
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 9c678e9b5dd80259ca3906ef13f4ccd52c7c0a93
Author: Ian Lake <ilake@google.com>
Date: Thu Mar 14 16:06:00 2019
Remove core-utils dependency from navigation-runtime
navigation-runtime no longer needs a dependency on
legacy-support-core-utils, so we can remove it.
Test: ./gradlew bOS
BUG: 128632612
Change-Id: I1b6400df0f068c5aa0ccbc4347e8ac284f781d6b
M buildSrc/src/main/kotlin/androidx/build/dependencies/Dependencies.kt
M navigation/runtime/build.gradle
https://android-review.googlesource.com/929945
https://goto.google.com/android-sha1/9c678e9b5dd80259ca3906ef13f4ccd52c7c0a93
Branch: androidx-master-dev
commit 9c678e9b5dd80259ca3906ef13f4ccd52c7c0a93
Author: Ian Lake <ilake@google.com>
Date: Thu Mar 14 16:06:00 2019
Remove core-utils dependency from navigation-runtime
navigation-runtime no longer needs a dependency on
legacy-support-core-utils, so we can remove it.
Test: ./gradlew bOS
BUG: 128632612
Change-Id: I1b6400df0f068c5aa0ccbc4347e8ac284f781d6b
M buildSrc/src/main/kotlin/androidx/build/dependencies/Dependencies.kt
M navigation/runtime/build.gradle
il...@google.com <il...@google.com>
ap...@google.com <ap...@google.com> #6
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 7bbbab7dca4edda160e6b2169d38a25b81698f47
Author: Ian Lake <ilake@google.com>
Date: Fri Mar 15 09:59:23 2019
Centralize MATERIAL dependency
Remove references to SUPPORT_DESIGN and switch
to the full dependency instead of the previously
used @aar dependency.
Also removes the no longer needed exclude_for_material
exclusion since all libraries are now on AndroidX.
Removed ViewPager2 implementation on AppCompat,
replacing it with an androidTestImplementation since it
is not actually used in the library itself. This fixes
an error when including a ToT implementation dependency
along with the fixed dependency from MATERIAL that
appears when switching to the full dependency.
Test: ./gradlew bOS, ran all affected sample apps
Fixes: 128632612
Change-Id: I44579630cdc3eae58fc23924d8c4d45d2d457f2b
M buildSrc/dependencies.gradle
M buildSrc/src/main/kotlin/androidx/build/dependencies/Dependencies.kt
M car/core/build.gradle
M navigation/ui/build.gradle
M samples/SupportContentDemos/build.gradle
M samples/SupportDesignDemos/build.gradle
M viewpager2/build.gradle
M viewpager2/integration-tests/testapp/build.gradle
M work/integration-tests/testapp/build.gradle
https://android-review.googlesource.com/929949
https://goto.google.com/android-sha1/7bbbab7dca4edda160e6b2169d38a25b81698f47
Branch: androidx-master-dev
commit 7bbbab7dca4edda160e6b2169d38a25b81698f47
Author: Ian Lake <ilake@google.com>
Date: Fri Mar 15 09:59:23 2019
Centralize MATERIAL dependency
Remove references to SUPPORT_DESIGN and switch
to the full dependency instead of the previously
used @aar dependency.
Also removes the no longer needed exclude_for_material
exclusion since all libraries are now on AndroidX.
Removed ViewPager2 implementation on AppCompat,
replacing it with an androidTestImplementation since it
is not actually used in the library itself. This fixes
an error when including a ToT implementation dependency
along with the fixed dependency from MATERIAL that
appears when switching to the full dependency.
Test: ./gradlew bOS, ran all affected sample apps
Fixes: 128632612
Change-Id: I44579630cdc3eae58fc23924d8c4d45d2d457f2b
M buildSrc/dependencies.gradle
M buildSrc/src/main/kotlin/androidx/build/dependencies/Dependencies.kt
M car/core/build.gradle
M navigation/ui/build.gradle
M samples/SupportContentDemos/build.gradle
M samples/SupportDesignDemos/build.gradle
M viewpager2/build.gradle
M viewpager2/integration-tests/testapp/build.gradle
M work/integration-tests/testapp/build.gradle
il...@google.com <il...@google.com> #7
Navigation now depends on:
- core 1.0.1
- fragment 1.1.0-alpha05 (latest)
- material 1.0.0
And no longer depends on legacy-support-core-utils at all.
- core 1.0.1
- fragment 1.1.0-alpha05 (latest)
- material 1.0.0
And no longer depends on legacy-support-core-utils at all.
Description
Version used: 2.0.0
Devices/Android versions reproduced on:
Now that Navigation depends on AndroidX, we should switch to the latest versions of our dependencies where it makes sense and remove our dependency on the catch all legacy-support-core-utils artifact.