Workers executed when constraint is met crashing on Android 4.4-5.1 (WorkManager scheduling instead of JobService) [129226383]

Fixed

Bug

Status Update

No update yet.

Description

jo...@gmail.com

created issue #1

Mar 25, 2019 09:29AM

Component used: androidx.work:work-runtime
Version used: 2.0.0
Devices/Android versions reproduced on: reported on Android 5.0/5.1 (Play Console) / Android 4.4.2/4.4.4/5.0-5.1.1 (Firebase Crashlytics). Multiple devices from various manufacturers, including Samsung, Lenovo, LG, Motorola, HTC, Sony and Asus.

After updating our app from android.arch.work:work-runtime:1.0.0-rc02 to androidx.work:work-runtime:2.0.0, we're seeing crashes when WorkManager starts a job for a significant amount of our users, which doesn't make much sense because the code should be similar to the previous version but it is still a problem.
Unfortunately, we haven't been able to replicate the issue on our 4.4.2 test device. Because the issue is limited to Android versions where JobService isn't used (and the stack trace, see below), it seems like the issue is caused by WorkManager's scheduling and not the job itself.

The worker is set up by a periodic request:

Constraints workerConstraints = new Constraints.Builder().setRequiredNetworkType(NetworkType.CONNECTED).build();
PeriodicWorkRequest userUpdateWorker = new PeriodicWorkRequest.Builder(UserUpdateWorker.class, 8, TimeUnit.HOURS)
.addTag(UserUpdateWorker.class.getName())
.setConstraints(workerConstraints)
.build();
WorkManager.getInstance().enqueue(userUpdateWorker);

Stack trace from the Crashlytics/Play Console crash reports:

Fatal Exception: java.lang.RuntimeException: Error receiving broadcast Intent { act=android.net.conn.CONNECTIVITY_CHANGE flg=0x4000010 (has extras) } in androidx.work.impl.constraints.trackers.NetworkStateTracker$NetworkStateBroadcastReceiver@42849958
at android.app.LoadedApk$ReceiverDispatcher$Args.run (LoadedApk.java:941)
at android.os.Handler.handleCallback (Handler.java:739)
at android.os.Handler.dispatchMessage (Handler.java:95)
at android.os.Looper.loop (Looper.java:145)
at android.app.ActivityThread.main (ActivityThread.java:6117)
at java.lang.reflect.Method.invoke (Method.java)
at java.lang.reflect.Method.invoke (Method.java:372)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run (ZygoteInit.java:1399)
at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:1194)
Caused by java.util.concurrent.RejectedExecutionException: Task java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask@2ac263d0 rejected from java.util.concurrent.ScheduledThreadPoolExecutor@320e0fc9[Terminated, pool size = 0, active threads = 0, queued tasks = 0, completed tasks = 0]
at java.util.concurrent.ThreadPoolExecutor$AbortPolicy.rejectedExecution (ThreadPoolExecutor.java:2011)
at java.util.concurrent.ThreadPoolExecutor.reject (ThreadPoolExecutor.java:793)
at java.util.concurrent.ScheduledThreadPoolExecutor.delayedExecute (ScheduledThreadPoolExecutor.java:298)
at java.util.concurrent.ScheduledThreadPoolExecutor.schedule (ScheduledThreadPoolExecutor.java:503)
at java.util.concurrent.Executors$DelegatedScheduledExecutorService.schedule (Executors.java:644)
at androidx.work.impl.background.systemalarm.WorkTimer.startTimer (WorkTimer.java:82)
at androidx.work.impl.background.systemalarm.DelayMetCommandHandler.onAllConstraintsMet (DelayMetCommandHandler.java:100)
at androidx.work.impl.constraints.WorkConstraintsTracker.onConstraintMet (WorkConstraintsTracker.java:150)
at androidx.work.impl.constraints.controllers.ConstraintController.updateCallback (ConstraintController.java:134)
at androidx.work.impl.constraints.controllers.ConstraintController.onConstraintChanged (ConstraintController.java:141)
at androidx.work.impl.constraints.trackers.ConstraintTracker.setState (ConstraintTracker.java:103)
at androidx.work.impl.constraints.trackers.NetworkStateTracker$NetworkStateBroadcastReceiver.onReceive (NetworkStateTracker.java:170)
at android.app.LoadedApk$ReceiverDispatcher$Args.run (LoadedApk.java:931)
at android.os.Handler.handleCallback (Handler.java:739)
at android.os.Handler.dispatchMessage (Handler.java:95)
at android.os.Looper.loop (Looper.java:145)
at android.app.ActivityThread.main (ActivityThread.java:6117)
at java.lang.reflect.Method.invoke (Method.java)
at java.lang.reflect.Method.invoke (Method.java:372)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run (ZygoteInit.java:1399)
at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:1194)

Comments

jo...@gmail.com <jo...@gmail.com> #2Mar 25, 2019 09:48AM

Some movements happening on KAPT with regards to this:

https://github.com/JetBrains/kotlin/pull/2179

je...@gmail.com <je...@gmail.com> #3Mar 25, 2019 03:26PM

Yes, kapt incremental compilation support is available since 1.3.40-dev-795
Is there already some plan to add support to Room?

ra...@google.com <ra...@google.com> Mar 25, 2019 09:05PM

Assigned to ra...@google.com.

ap...@google.com <ap...@google.com> #4Mar 26, 2019 12:05AM

Marked as fixed.

#3 incremental kapt is available in 1.3.30 released yesterday too.

jo...@gmail.com <jo...@gmail.com> #5Mar 26, 2019 05:53AM

Is there already some ETA?

ra...@google.com <ra...@google.com> #6Mar 26, 2019 05:25PM

We are working on it and aiming for Room 2.2

di...@gmail.com <di...@gmail.com> #7Apr 1, 2019 07:20PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit e4fbb7fb77a4789ab40bff03cc131479779d3e69
Author: Daniel Santiago Rivera <danysantiago@google.com>
Date: Tue Apr 09 23:20:59 2019

Create integration test for Room that uses gradle test kit.

Useful for testing Room incremental annotation processing in Gradle.

Also consolidated some of the path definitions in various build.gradle
into methods in buildSrc/SupportConfig.

Bug: 112110217
Test: ./gradlew room:integration-tests:room-i-a-p:test
Change-Id: I34f6772675712c6edd500e9149ab7f21ade4f012

M buildSrc/src/main/kotlin/androidx/build/SupportConfig.kt
M lifecycle/integration-tests/incrementality/build.gradle
M navigation/safe-args-gradle-plugin/build.gradle
A room/integration-tests/incremental-annotation-processing/build.gradle
A room/integration-tests/incremental-annotation-processing/src/test/data/simple-project/src/main/AndroidManifest.xml
A room/integration-tests/incremental-annotation-processing/src/test/data/simple-project/src/main/java/room/testapp/TestDao.java
A room/integration-tests/incremental-annotation-processing/src/test/data/simple-project/src/main/java/room/testapp/TestDatabase.java
A room/integration-tests/incremental-annotation-processing/src/test/data/simple-project/src/main/java/room/testapp/TestEntity.java
A room/integration-tests/incremental-annotation-processing/src/test/kotlin/androidx/room/gradle/CompileTest.kt
M settings.gradle

https://android-review.googlesource.com/941741

https://goto.google.com/android-sha1/e4fbb7fb77a4789ab40bff03cc131479779d3e69

[Deleted User] <[Deleted User]> #8Apr 1, 2019 07:32PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit a68222dc929ae5e2a3445f9df69a63636854852e
Author: Hung Nguyen <hungnv@google.com>
Date: Fri Mar 29 11:39:50 2019

Prepare Room for incremental annotation processing.

In Java projects, with non-incremental annotation processing, the inputs
to an annotation processor includes only Java source files.

With incremental annotation processing, however, the inputs may include
both Java source files and class files (to avoid recompiling source
files that haven't changed).

Therefore, all Room annotations need to have retention policy CLASS or
RUNTIME (not SOURCE), so that Room can find the elements annotated with
those annotations from class files. This requirement is also stated at

https://docs.gradle.org/current/userguide/java_plugin.html#sec:incremental_annotation_processing.

Bug: 112110217
Test: Existing tests + New AnnotationRetentionPolicyTest
Change-Id: I1e3a433bf69503ef15cfc2e53cbe97616a6f13b8

M room/common/api/2.2.0-alpha01.txt
M room/common/api/current.txt
M room/common/build.gradle
M room/common/src/main/java/androidx/room/ColumnInfo.java
M room/common/src/main/java/androidx/room/ForeignKey.java
M room/common/src/main/java/androidx/room/OnConflictStrategy.java
M room/common/src/main/java/androidx/room/Update.java
A room/common/src/test/java/androidx/room/AnnotationRetentionPolicyTest.kt

https://android-review.googlesource.com/958284

https://goto.google.com/android-sha1/a68222dc929ae5e2a3445f9df69a63636854852e

dr...@gmail.com <dr...@gmail.com> #9Apr 6, 2019 09:13AM

Project: platform/prebuilts/jdk/jdk8
Branch: androidx-master-dev

commit fe743aa0d39ef9bab51c612a957acdd4588d069c
Author: Daniel Santiago Rivera <danysantiago@google.com>
Date: Wed Jun 05 14:03:32 2019

Update JDK prebuilts

This build contains fix for

https://bugs.openjdk.java.net/browse/JDK-8194268
which is needed for

b/112110217

(Room incremental annotation processing).

This JDK was taken from platform/prebuilts/studio/jdk in studio-master-dev
as it contains the cherry-picked fixes (ag/7057968).

Test: ./gradlew bOS
Bug: 134470119
Change-Id: I11e4ac20e8cca61ebff5640af7d9b535e5af4ba3

D darwin-x86/MODULE_LICENSE_GPL
M darwin-x86/THIRD_PARTY_README
M darwin-x86/bin/appletviewer
A darwin-x86/bin/clhsdb
M darwin-x86/bin/extcheck
A darwin-x86/bin/hsdb
M darwin-x86/bin/idlj
M darwin-x86/bin/jar
M darwin-x86/bin/jarsigner
M darwin-x86/bin/java
M darwin-x86/bin/javac
M darwin-x86/bin/javadoc
M darwin-x86/bin/javah
M darwin-x86/bin/javap
M darwin-x86/bin/jcmd
M darwin-x86/bin/jconsole
M darwin-x86/bin/jdb
M darwin-x86/bin/jdeps
M darwin-x86/bin/jhat
M darwin-x86/bin/jinfo
M darwin-x86/bin/jjs
M darwin-x86/bin/jmap
M darwin-x86/bin/jps
M darwin-x86/bin/jrunscript
M darwin-x86/bin/jsadebugd
M darwin-x86/bin/jstack
M darwin-x86/bin/jstat
M darwin-x86/bin/jstatd
M darwin-x86/bin/keytool
M darwin-x86/bin/native2ascii
M darwin-x86/bin/orbd
M darwin-x86/bin/pack200
M darwin-x86/bin/policytool
M darwin-x86/bin/rmic
M darwin-x86/bin/rmid
M darwin-x86/bin/rmiregistry
M darwin-x86/bin/schemagen
M darwin-x86/bin/serialver
M darwin-x86/bin/servertool
M darwin-x86/bin/tnameserv
M darwin-x86/bin/unpack200
M darwin-x86/bin/wsgen
M darwin-x86/bin/wsimport
M darwin-x86/bin/xjc
M darwin-x86/jre/THIRD_PARTY_README
A darwin-x86/jre/bin/clhsdb
A darwin-x86/jre/bin/hsdb
M darwin-x86/jre/bin/java
M darwin-x86/jre/bin/jjs
M darwin-x86/jre/bin/keytool
M darwin-x86/jre/bin/orbd
M darwin-x86/jre/bin/pack200
M darwin-x86/jre/bin/policytool
M darwin-x86/jre/bin/rmid
M darwin-x86/jre/bin/rmiregistry
M darwin-x86/jre/bin/servertool
M darwin-x86/jre/bin/tnameserv
M darwin-x86/jre/bin/unpack200
M darwin-x86/jre/lib/charsets.jar
M darwin-x86/jre/lib/ext/cldrdata.jar
M darwin-x86/jre/lib/ext/dnsns.jar
M darwin-x86/jre/lib/ext/jaccess.jar
M darwin-x86/jre/lib/ext/localedata.jar
M darwin-x86/jre/lib/ext/nashorn.jar
M darwin-x86/jre/lib/ext/sunec.jar
M darwin-x86/jre/lib/ext/sunjce_provider.jar
M darwin-x86/jre/lib/ext/sunpkcs11.jar
M darwin-x86/jre/lib/ext/zipfs.jar
M darwin-x86/jre/lib/fontconfig.bfc
M darwin-x86/jre/lib/fontconfig.properties.src
A darwin-x86/jre/lib/fonts/DroidSansFallbackFull.ttf
M darwin-x86/jre/lib/jce.jar
M darwin-x86/jre/lib/jli/libjli.dylib
M darwin-x86/jre/lib/jspawnhelper
M darwin-x86/jre/lib/jsse.jar
M darwin-x86/jre/lib/libAppleScriptEngine.dylib
M darwin-x86/jre/lib/libattach.dylib
M darwin-x86/jre/lib/libawt.dylib
M darwin-x86/jre/lib/libawt_lwawt.dylib
M darwin-x86/jre/lib/libdt_socket.dylib
M darwin-x86/jre/lib/libfontmanager.dylib
M darwin-x86/jre/lib/libfreetype.dylib.6
M darwin-x86/jre/lib/libhprof.dylib
M darwin-x86/jre/lib/libinstrument.dylib
M darwin-x86/jre/lib/libj2gss.dylib
M darwin-x86/jre/lib/libj2pcsc.dylib
M darwin-x86/jre/lib/libj2pkcs11.dylib
M darwin-x86/jre/lib/libjaas_unix.dylib
M darwin-x86/jre/lib/libjava.dylib
M darwin-x86/jre/lib/libjava_crw_demo.dylib
M darwin-x86/jre/lib/libjawt.dylib
M darwin-x86/jre/lib/libjdwp.dylib
M darwin-x86/jre/lib/libjpeg.dylib
M darwin-x86/jre/lib/libjsdt.dylib
M darwin-x86/jre/lib/libjsig.dylib
M darwin-x86/jre/lib/libjsound.dylib
M darwin-x86/jre/lib/liblcms.dylib
M darwin-x86/jre/lib/libmanagement.dylib
M darwin-x86/jre/lib/libmlib_image.dylib
M darwin-x86/jre/lib/libnet.dylib
M darwin-x86/jre/lib/libnio.dylib
M darwin-x86/jre/lib/libnpt.dylib
M darwin-x86/jre/lib/libosx.dylib
M darwin-x86/jre/lib/libosxapp.dylib
M darwin-x86/jre/lib/libosxkrb5.dylib
M darwin-x86/jre/lib/libosxui.dylib
M darwin-x86/jre/lib/libsaproc.dylib
M darwin-x86/jre/lib/libsplashscreen.dylib
M darwin-x86/jre/lib/libsunec.dylib
M darwin-x86/jre/lib/libunpack.dylib
M darwin-x86/jre/lib/libverify.dylib
M darwin-x86/jre/lib/libzip.dylib
M darwin-x86/jre/lib/management-agent.jar
M darwin-x86/jre/lib/resources.jar
M darwin-x86/jre/lib/rt.jar
M darwin-x86/jre/lib/security/java.security
M darwin-x86/jre/lib/security/policy/limited/US_export_policy.jar
M darwin-x86/jre/lib/security/policy/limited/local_policy.jar
M darwin-x86/jre/lib/security/policy/unlimited/US_export_policy.jar
M darwin-x86/jre/lib/security/policy/unlimited/local_policy.jar
M darwin-x86/jre/lib/server/libjsig.dylib
M darwin-x86/jre/lib/server/libjvm.dylib
M darwin-x86/jre/lib/tzdb.dat
M darwin-x86/lib/ct.sym
M darwin-x86/lib/dt.jar
M darwin-x86/lib/jconsole.jar
M darwin-x86/lib/sa-jdi.jar
M darwin-x86/lib/tools.jar
M darwin-x86/release
D darwin-x86/sample/README
D darwin-x86/sample/annotations/DependencyChecker/PluginChecker/src/checker/Device.java
D darwin-x86/sample/annotations/DependencyChecker/PluginChecker/src/checker/Kettle.xml
D darwin-x86/sample/annotations/DependencyChecker/PluginChecker/src/checker/Module.java
D darwin-x86/sample/annotations/DependencyChecker/PluginChecker/src/checker/PluginChecker.java
D darwin-x86/sample/annotations/DependencyChecker/PluginChecker/src/checker/Require.java
D darwin-x86/sample/annotations/DependencyChecker/PluginChecker/src/checker/RequireContainer.java
D darwin-x86/sample/annotations/DependencyChecker/Plugins/src/plugins/BoilerPlugin.java
D darwin-x86/sample/annotations/DependencyChecker/Plugins/src/plugins/ExtendedBoilerPlugin.java
D darwin-x86/sample/annotations/DependencyChecker/Plugins/src/plugins/TimerPlugin.java
D darwin-x86/sample/annotations/Validator/src/PositiveIntegerSupplier.java
D darwin-x86/sample/annotations/Validator/src/SupplierValidator.java
D darwin-x86/sample/annotations/Validator/src/Validate.java
D darwin-x86/sample/annotations/Validator/src/Validator.java
D darwin-x86/sample/annotations/index.html
D darwin-x86/sample/dtrace/README.txt
D darwin-x86/sample/dtrace/helpers/dtrace_helper.d
D darwin-x86/sample/dtrace/hotspot/README.txt
D darwin-x86/sample/dtrace/hotspot/class_loading_stat.d
D darwin-x86/sample/dtrace/hotspot/gc_time_stat.d
D darwin-x86/sample/dtrace/hotspot/hotspot_calls_tree.d
D darwin-x86/sample/dtrace/hotspot/method_compile_stat.d
D darwin-x86/sample/dtrace/hotspot/method_invocation_stat.d
D darwin-x86/sample/dtrace/hotspot/method_invocation_stat_filter.d
D darwin-x86/sample/dtrace/hotspot/method_invocation_tree.d
D darwin-x86/sample/dtrace/hotspot/monitors.d
D darwin-x86/sample/dtrace/hotspot/object_allocation_stat.d
D darwin-x86/sample/dtrace/hotspot_jni/CriticalSection.d
D darwin-x86/sample/dtrace/hotspot_jni/CriticalSection_slow.d
D darwin-x86/sample/dtrace/hotspot_jni/README.txt
D darwin-x86/sample/dtrace/hotspot_jni/hotspot_jni_calls_stat.d
D darwin-x86/sample/dtrace/hotspot_jni/hotspot_jni_calls_tree.d
D darwin-x86/sample/forkjoin/mergesort/MergeDemo.java
D darwin-x86/sample/forkjoin/mergesort/MergeSort.java
D darwin-x86/sample/jmx/jmx-scandir/build.properties
D darwin-x86/sample/jmx/jmx-scandir/build.xml
D darwin-x86/sample/jmx/jmx-scandir/docfiles/connect-local-ant-run.jpg
D darwin-x86/sample/jmx/jmx-scandir/docfiles/connect-local-java-jar.jpg
D darwin-x86/sample/jmx/jmx-scandir/docfiles/connect-local.jpg
D darwin-x86/sample/jmx/jmx-scandir/docfiles/remote-connection-failed.jpg
D darwin-x86/sample/jmx/jmx-scandir/docfiles/remote-connection.jpg
D darwin-x86/sample/jmx/jmx-scandir/docfiles/scandir-config.jpg
D darwin-x86/sample/jmx/jmx-scandir/docfiles/scandir-result.jpg
D darwin-x86/sample/jmx/jmx-scandir/docfiles/scandir-start.jpg
D darwin-x86/sample/jmx/jmx-scandir/index.html
D darwin-x86/sample/jmx/jmx-scandir/keystore
D darwin-x86/sample/jmx/jmx-scandir/logging.properties
D darwin-x86/sample/jmx/jmx-scandir/manifest.mf
D darwin-x86/sample/jmx/jmx-scandir/nbproject/file-targets.xml
D darwin-x86/sample/jmx/jmx-scandir/nbproject/jdk.xml
D darwin-x86/sample/jmx/jmx-scandir/nbproject/netbeans-targets.xml
D darwin-x86/sample/jmx/jmx-scandir/nbproject/project.xml
D darwin-x86/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/DirectoryScanner.java
D darwin-x86/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/DirectoryScannerMXBean.java
D darwin-x86/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/ResultLogManager.java
D darwin-x86/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/ResultLogManagerMXBean.java
D darwin-x86/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/ScanDirAgent.java
D darwin-x86/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/ScanDirClient.java
D darwin-x86/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/ScanDirConfig.java
D darwin-x86/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/ScanDirConfigMXBean.java
D darwin-x86/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/ScanManager.java
D darwin-x86/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/ScanManagerMXBean.java
D darwin-x86/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/config/DirectoryScannerConfig.java
D darwin-x86/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/config/FileMatch.java
D darwin-x86/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/config/ResultLogConfig.java
D darwin-x86/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/config/ResultRecord.java
D darwin-x86/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/config/ScanManagerConfig.java
D darwin-x86/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/config/XmlConfigUtils.java
D darwin-x86/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/config/package.html
D darwin-x86/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/package.html
D darwin-x86/sample/jmx/jmx-scandir/src/etc/access.properties
D darwin-x86/sample/jmx/jmx-scandir/src/etc/management.properties
D darwin-x86/sample/jmx/jmx-scandir/src/etc/password.properties
D darwin-x86/sample/jmx/jmx-scandir/src/etc/testconfig.xml
D darwin-x86/sample/jmx/jmx-scandir/test/com/sun/jmx/examples/scandir/DirectoryScannerTest.java
D darwin-x86/sample/jmx/jmx-scandir/test/com/sun/jmx/examples/scandir/ScanDirConfigTest.java
D darwin-x86/sample/jmx/jmx-scandir/test/com/sun/jmx/examples/scandir/ScanManagerTest.java
D darwin-x86/sample/jmx/jmx-scandir/test/com/sun/jmx/examples/scandir/TestUtils.java
D darwin-x86/sample/jmx/jmx-scandir/test/com/sun/jmx/examples/scandir/config/XmlConfigUtilsTest.java
D darwin-x86/sample/jmx/jmx-scandir/truststore
D darwin-x86/sample/lambda/BulkDataOperations/index.html
D darwin-x86/sample/lambda/BulkDataOperations/src/CSVProcessor.java
D darwin-x86/sample/lambda/BulkDataOperations/src/Grep.java
D darwin-x86/sample/lambda/BulkDataOperations/src/PasswordGenerator.java
D darwin-x86/sample/lambda/BulkDataOperations/src/WC.java
D darwin-x86/sample/lambda/DefaultMethods/ArrayIterator.java
D darwin-x86/sample/lambda/DefaultMethods/DiamondInheritance.java
D darwin-x86/sample/lambda/DefaultMethods/Inheritance.java
D darwin-x86/sample/lambda/DefaultMethods/MixIn.java
D darwin-x86/sample/lambda/DefaultMethods/Reflection.java
D darwin-x86/sample/lambda/DefaultMethods/SimplestUsage.java
D darwin-x86/sample/nbproject/project.xml
D darwin-x86/sample/nio/chatserver/ChatServer.java
D darwin-x86/sample/nio/chatserver/Client.java
D darwin-x86/sample/nio/chatserver/ClientReader.java
D darwin-x86/sample/nio/chatserver/DataReader.java
D darwin-x86/sample/nio/chatserver/MessageReader.java
D darwin-x86/sample/nio/chatserver/NameReader.java
D darwin-x86/sample/nio/chatserver/README.txt
D darwin-x86/sample/nio/file/AclEdit.java
D darwin-x86/sample/nio/file/Chmod.java
D darwin-x86/sample/nio/file/Copy.java
D darwin-x86/sample/nio/file/DiskUsage.java
D darwin-x86/sample/nio/file/FileType.java
D darwin-x86/sample/nio/file/WatchDir.java
D darwin-x86/sample/nio/file/Xdd.java
D darwin-x86/sample/nio/multicast/MulticastAddress.java
D darwin-x86/sample/nio/multicast/Reader.java
D darwin-x86/sample/nio/multicast/Sender.java
D darwin-x86/sample/nio/server/AcceptHandler.java
D darwin-x86/sample/nio/server/Acceptor.java
D darwin-x86/sample/nio/server/B1.java
D darwin-x86/sample/nio/server/BN.java
D darwin-x86/sample/nio/server/BP.java
D darwin-x86/sample/nio/server/ChannelIO.java
D darwin-x86/sample/nio/server/ChannelIOSecure.java
D darwin-x86/sample/nio/server/Content.java
D darwin-x86/sample/nio/server/Dispatcher.java
D darwin-x86/sample/nio/server/Dispatcher1.java
D darwin-x86/sample/nio/server/DispatcherN.java
D darwin-x86/sample/nio/server/FileContent.java
D darwin-x86/sample/nio/server/Handler.java
D darwin-x86/sample/nio/server/MalformedRequestException.java
D darwin-x86/sample/nio/server/N1.java
D darwin-x86/sample/nio/server/N2.java
D darwin-x86/sample/nio/server/README.txt
D darwin-x86/sample/nio/server/Reply.java
D darwin-x86/sample/nio/server/Request.java
D darwin-x86/sample/nio/server/RequestHandler.java
D darwin-x86/sample/nio/server/RequestServicer.java
D darwin-x86/sample/nio/server/Sendable.java
D darwin-x86/sample/nio/server/Server.java
D darwin-x86/sample/nio/server/StringContent.java
D darwin-x86/sample/nio/server/URLDumper.java
D darwin-x86/sample/scripting/scriptpad/README.txt
D darwin-x86/sample/scripting/scriptpad/build.properties
D darwin-x86/sample/scripting/scriptpad/build.xml
D darwin-x86/sample/scripting/scriptpad/nbproject/file-targets.xml
D darwin-x86/sample/scripting/scriptpad/nbproject/jdk.xml
D darwin-x86/sample/scripting/scriptpad/nbproject/netbeans-targets.xml
D darwin-x86/sample/scripting/scriptpad/nbproject/project.xml
D darwin-x86/sample/scripting/scriptpad/src/META-INF/manifest.mf
D darwin-x86/sample/scripting/scriptpad/src/com/sun/sample/scriptpad/Main.java
D darwin-x86/sample/scripting/scriptpad/src/resources/Main.js
D darwin-x86/sample/scripting/scriptpad/src/resources/conc.js
D darwin-x86/sample/scripting/scriptpad/src/resources/gui.js
D darwin-x86/sample/scripting/scriptpad/src/resources/mm.js
D darwin-x86/sample/scripting/scriptpad/src/resources/scriptpad.js
D darwin-x86/sample/scripting/scriptpad/src/scripts/README.txt
D darwin-x86/sample/scripting/scriptpad/src/scripts/browse.js
D darwin-x86/sample/scripting/scriptpad/src/scripts/insertfile.js
D darwin-x86/sample/scripting/scriptpad/src/scripts/linewrap.js
D darwin-x86/sample/scripting/scriptpad/src/scripts/mail.js
D darwin-x86/sample/scripting/scriptpad/src/scripts/memmonitor.js
D darwin-x86/sample/scripting/scriptpad/src/scripts/memory.bat
D darwin-x86/sample/scripting/scriptpad/src/scripts/memory.js
D darwin-x86/sample/scripting/scriptpad/src/scripts/memory.sh
D darwin-x86/sample/scripting/scriptpad/src/scripts/textcolor.js
D darwin-x86/sample/try-with-resources/index.html
D darwin-x86/sample/try-with-resources/src/CustomAutoCloseableSample.java
D darwin-x86/sample/try-with-resources/src/Unzip.java
D darwin-x86/sample/try-with-resources/src/ZipCat.java
M darwin-x86/src.zip
D linux-x86/MODULE_LICENSE_GPL
M linux-x86/THIRD_PARTY_README
M linux-x86/bin/appletviewer
A linux-x86/bin/clhsdb
M linux-x86/bin/extcheck
A linux-x86/bin/hsdb
M linux-x86/bin/idlj
M linux-x86/bin/jar
M linux-x86/bin/jarsigner
M linux-x86/bin/java
M linux-x86/bin/javac
M linux-x86/bin/javadoc
M linux-x86/bin/javah
M linux-x86/bin/javap
M linux-x86/bin/jcmd
M linux-x86/bin/jconsole
M linux-x86/bin/jdb
M linux-x86/bin/jdeps
M linux-x86/bin/jhat
M linux-x86/bin/jinfo
M linux-x86/bin/jjs
M linux-x86/bin/jmap
M linux-x86/bin/jps
M linux-x86/bin/jrunscript
M linux-x86/bin/jsadebugd
M linux-x86/bin/jstack
M linux-x86/bin/jstat
M linux-x86/bin/jstatd
M linux-x86/bin/keytool
M linux-x86/bin/native2ascii
M linux-x86/bin/orbd
M linux-x86/bin/pack200
M linux-x86/bin/policytool
M linux-x86/bin/rmic
M linux-x86/bin/rmid
M linux-x86/bin/rmiregistry
M linux-x86/bin/schemagen
M linux-x86/bin/serialver
M linux-x86/bin/servertool
M linux-x86/bin/tnameserv
M linux-x86/bin/unpack200
M linux-x86/bin/wsgen
M linux-x86/bin/wsimport
M linux-x86/bin/xjc
M linux-x86/jre/THIRD_PARTY_README
A linux-x86/jre/bin/clhsdb
A linux-x86/jre/bin/hsdb
M linux-x86/jre/bin/java
M linux-x86/jre/bin/jjs
M linux-x86/jre/bin/keytool
M linux-x86/jre/bin/orbd
M linux-x86/jre/bin/pack200
M linux-x86/jre/bin/policytool
M linux-x86/jre/bin/rmid
M linux-x86/jre/bin/rmiregistry
M linux-x86/jre/bin/servertool
M linux-x86/jre/bin/tnameserv
M linux-x86/jre/bin/unpack200
M linux-x86/jre/lib/amd64/jli/libjli.so
M linux-x86/jre/lib/amd64/libattach.so
M linux-x86/jre/lib/amd64/libawt.so
M linux-x86/jre/lib/amd64/libawt_headless.so
M linux-x86/jre/lib/amd64/libawt_xawt.so
M linux-x86/jre/lib/amd64/libdt_socket.so
M linux-x86/jre/lib/amd64/libfontmanager.so
M linux-x86/jre/lib/amd64/libhprof.so
M linux-x86/jre/lib/amd64/libinstrument.so
M linux-x86/jre/lib/amd64/libj2gss.so
M linux-x86/jre/lib/amd64/libj2pcsc.so
M linux-x86/jre/lib/amd64/libj2pkcs11.so
M linux-x86/jre/lib/amd64/libjaas_unix.so
M linux-x86/jre/lib/amd64/libjava.so
M linux-x86/jre/lib/amd64/libjava_crw_demo.so
M linux-x86/jre/lib/amd64/libjawt.so
M linux-x86/jre/lib/amd64/libjdwp.so
M linux-x86/jre/lib/amd64/libjpeg.so
M linux-x86/jre/lib/amd64/libjsdt.so
M linux-x86/jre/lib/amd64/libjsig.so
M linux-x86/jre/lib/amd64/libjsound.so
M linux-x86/jre/lib/amd64/libjsoundalsa.so
M linux-x86/jre/lib/amd64/liblcms.so
M linux-x86/jre/lib/amd64/libmanagement.so
M linux-x86/jre/lib/amd64/libmlib_image.so
M linux-x86/jre/lib/amd64/libnet.so
M linux-x86/jre/lib/amd64/libnio.so
M linux-x86/jre/lib/amd64/libnpt.so
M linux-x86/jre/lib/amd64/libsaproc.so
M linux-x86/jre/lib/amd64/libsctp.so
M linux-x86/jre/lib/amd64/libsplashscreen.so
M linux-x86/jre/lib/amd64/libsunec.so
M linux-x86/jre/lib/amd64/libunpack.so
M linux-x86/jre/lib/amd64/libverify.so
M linux-x86/jre/lib/amd64/libzip.so
M linux-x86/jre/lib/amd64/server/libjsig.so
M linux-x86/jre/lib/amd64/server/libjvm.so
M linux-x86/jre/lib/charsets.jar
M linux-x86/jre/lib/ext/cldrdata.jar
M linux-x86/jre/lib/ext/dnsns.jar
M linux-x86/jre/lib/ext/jaccess.jar
M linux-x86/jre/lib/ext/localedata.jar
M linux-x86/jre/lib/ext/nashorn.jar
M linux-x86/jre/lib/ext/sunec.jar
M linux-x86/jre/lib/ext/sunjce_provider.jar
M linux-x86/jre/lib/ext/sunpkcs11.jar
M linux-x86/jre/lib/ext/zipfs.jar
A linux-x86/jre/lib/fonts/DroidSansFallbackFull.ttf
M linux-x86/jre/lib/jce.jar
M linux-x86/jre/lib/jexec
M linux-x86/jre/lib/jsse.jar
M linux-x86/jre/lib/management-agent.jar
M linux-x86/jre/lib/resources.jar
M linux-x86/jre/lib/rt.jar
M linux-x86/jre/lib/security/java.security
M linux-x86/jre/lib/security/policy/limited/US_export_policy.jar
M linux-x86/jre/lib/security/policy/limited/local_policy.jar
M linux-x86/jre/lib/security/policy/unlimited/US_export_policy.jar
M linux-x86/jre/lib/security/policy/unlimited/local_policy.jar
M linux-x86/jre/lib/tzdb.dat
M linux-x86/lib/amd64/jli/libjli.so
M linux-x86/lib/amd64/libjawt.so
M linux-x86/lib/ct.sym
M linux-x86/lib/dt.jar
M linux-x86/lib/jconsole.jar
M linux-x86/lib/jexec
M linux-x86/lib/sa-jdi.jar
M linux-x86/lib/tools.jar
M linux-x86/release
D linux-x86/sample/README
D linux-x86/sample/annotations/DependencyChecker/PluginChecker/src/checker/Device.java
D linux-x86/sample/annotations/DependencyChecker/PluginChecker/src/checker/Kettle.xml
D linux-x86/sample/annotations/DependencyChecker/PluginChecker/src/checker/Module.java
D linux-x86/sample/annotations/DependencyChecker/PluginChecker/src/checker/PluginChecker.java
D linux-x86/sample/annotations/DependencyChecker/PluginChecker/src/checker/Require.java
D linux-x86/sample/annotations/DependencyChecker/PluginChecker/src/checker/RequireContainer.java
D linux-x86/sample/annotations/DependencyChecker/Plugins/src/plugins/BoilerPlugin.java
D linux-x86/sample/annotations/DependencyChecker/Plugins/src/plugins/ExtendedBoilerPlugin.java
D linux-x86/sample/annotations/DependencyChecker/Plugins/src/plugins/TimerPlugin.java
D linux-x86/sample/annotations/Validator/src/PositiveIntegerSupplier.java
D linux-x86/sample/annotations/Validator/src/SupplierValidator.java
D linux-x86/sample/annotations/Validator/src/Validate.java
D linux-x86/sample/annotations/Validator/src/Validator.java
D linux-x86/sample/annotations/index.html
D linux-x86/sample/forkjoin/mergesort/MergeDemo.java
D linux-x86/sample/forkjoin/mergesort/MergeSort.java
D linux-x86/sample/jmx/jmx-scandir/build.properties
D linux-x86/sample/jmx/jmx-scandir/build.xml
D linux-x86/sample/jmx/jmx-scandir/docfiles/connect-local-ant-run.jpg
D linux-x86/sample/jmx/jmx-scandir/docfiles/connect-local-java-jar.jpg
D linux-x86/sample/jmx/jmx-scandir/docfiles/connect-local.jpg
D linux-x86/sample/jmx/jmx-scandir/docfiles/remote-connection-failed.jpg
D linux-x86/sample/jmx/jmx-scandir/docfiles/remote-connection.jpg
D linux-x86/sample/jmx/jmx-scandir/docfiles/scandir-config.jpg
D linux-x86/sample/jmx/jmx-scandir/docfiles/scandir-result.jpg
D linux-x86/sample/jmx/jmx-scandir/docfiles/scandir-start.jpg
D linux-x86/sample/jmx/jmx-scandir/index.html
D linux-x86/sample/jmx/jmx-scandir/keystore
D linux-x86/sample/jmx/jmx-scandir/logging.properties
D linux-x86/sample/jmx/jmx-scandir/manifest.mf
D linux-x86/sample/jmx/jmx-scandir/nbproject/file-targets.xml
D linux-x86/sample/jmx/jmx-scandir/nbproject/jdk.xml
D linux-x86/sample/jmx/jmx-scandir/nbproject/netbeans-targets.xml
D linux-x86/sample/jmx/jmx-scandir/nbproject/project.xml
D linux-x86/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/DirectoryScanner.java
D linux-x86/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/DirectoryScannerMXBean.java
D linux-x86/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/ResultLogManager.java
D linux-x86/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/ResultLogManagerMXBean.java
D linux-x86/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/ScanDirAgent.java
D linux-x86/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/ScanDirClient.java
D linux-x86/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/ScanDirConfig.java
D linux-x86/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/ScanDirConfigMXBean.java
D linux-x86/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/ScanManager.java
D linux-x86/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/ScanManagerMXBean.java
D linux-x86/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/config/DirectoryScannerConfig.java
D linux-x86/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/config/FileMatch.java
D linux-x86/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/config/ResultLogConfig.java
D linux-x86/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/config/ResultRecord.java
D linux-x86/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/config/ScanManagerConfig.java
D linux-x86/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/config/XmlConfigUtils.java
D linux-x86/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/config/package.html
D linux-x86/sample/jmx/jmx-scandir/src/com/sun/jmx/examples/scandir/package.html
D linux-x86/sample/jmx/jmx-scandir/src/etc/access.properties
D linux-x86/sample/jmx/jmx-scandir/src/etc/management.properties
D linux-x86/sample/jmx/jmx-scandir/src/etc/password.properties
D linux-x86/sample/jmx/jmx-scandir/src/etc/testconfig.xml
D linux-x86/sample/jmx/jmx-scandir/test/com/sun/jmx/examples/scandir/DirectoryScannerTest.java
D linux-x86/sample/jmx/jmx-scandir/test/com/sun/jmx/examples/scandir/ScanDirConfigTest.java
D linux-x86/sample/jmx/jmx-scandir/test/com/sun/jmx/examples/scandir/ScanManagerTest.java
D linux-x86/sample/jmx/jmx-scandir/test/com/sun/jmx/examples/scandir/TestUtils.java
D linux-x86/sample/jmx/jmx-scandir/test/com/sun/jmx/examples/scandir/config/XmlConfigUtilsTest.java
D linux-x86/sample/jmx/jmx-scandir/truststore
D linux-x86/sample/lambda/BulkDataOperations/index.html
D linux-x86/sample/lambda/BulkDataOperations/src/CSVProcessor.java
D linux-x86/sample/lambda/BulkDataOperations/src/Grep.java
D linux-x86/sample/lambda/BulkDataOperations/src/PasswordGenerator.java
D linux-x86/sample/lambda/BulkDataOperations/src/WC.java
D linux-x86/sample/lambda/DefaultMethods/ArrayIterator.java
D linux-x86/sample/lambda/DefaultMethods/DiamondInheritance.java
D linux-x86/sample/lambda/DefaultMethods/Inheritance.java
D linux-x86/sample/lambda/DefaultMethods/MixIn.java
D linux-x86/sample/lambda/DefaultMethods/Reflection.java
D linux-x86/sample/lambda/DefaultMethods/SimplestUsage.java
D linux-x86/sample/nbproject/project.xml
D linux-x86/sample/nio/chatserver/ChatServer.java
D linux-x86/sample/nio/chatserver/Client.java
D linux-x86/sample/nio/chatserver/ClientReader.java
D linux-x86/sample/nio/chatserver/DataReader.java
D linux-x86/sample/nio/chatserver/MessageReader.java
D linux-x86/sample/nio/chatserver/NameReader.java
D linux-x86/sample/nio/chatserver/README.txt
D linux-x86/sample/nio/file/AclEdit.java
D linux-x86/sample/nio/file/Chmod.java
D linux-x86/sample/nio/file/Copy.java
D linux-x86/sample/nio/file/DiskUsage.java
D linux-x86/sample/nio/file/FileType.java
D linux-x86/sample/nio/file/WatchDir.java
D linux-x86/sample/nio/file/Xdd.java
D linux-x86/sample/nio/multicast/MulticastAddress.java
D linux-x86/sample/nio/multicast/Reader.java
D linux-x86/sample/nio/multicast/Sender.java
D linux-x86/sample/nio/server/AcceptHandler.java
D linux-x86/sample/nio/server/Acceptor.java
D linux-x86/sample/nio/server/B1.java
D linux-x86/sample/nio/server/BN.java
D linux-x86/sample/nio/server/BP.java
D linux-x86/sample/nio/server/ChannelIO.java
D linux-x86/sample/nio/server/ChannelIOSecure.java
D linux-x86/sample/nio/server/Content.java
D linux-x86/sample/nio/server/Dispatcher.java
D linux-x86/sample/nio/server/Dispatcher1.java
D linux-x86/sample/nio/server/DispatcherN.java
D linux-x86/sample/nio/server/FileContent.java
D linux-x86/sample/nio/server/Handler.java
D linux-x86/sample/nio/server/MalformedRequestException.java
D linux-x86/sample/nio/server/N1.java
D linux-x86/sample/nio/server/N2.java
D linux-x86/sample/nio/server/README.txt
D linux-x86/sample/nio/server/Reply.java
D linux-x86/sample/nio/server/Request.java
D linux-x86/sample/nio/server/RequestHandler.java
D linux-x86/sample/nio/server/RequestServicer.java
D linux-x86/sample/nio/server/Sendable.java
D linux-x86/sample/nio/server/Server.java
D linux-x86/sample/nio/server/StringContent.java
D linux-x86/sample/nio/server/URLDumper.java
D linux-x86/sample/scripting/scriptpad/README.txt
D linux-x86/sample/scripting/scriptpad/build.properties
D linux-x86/sample/scripting/scriptpad/build.xml
D linux-x86/sample/scripting/scriptpad/nbproject/file-targets.xml
D linux-x86/sample/scripting/scriptpad/nbproject/jdk.xml
D linux-x86/sample/scripting/scriptpad/nbproject/netbeans-targets.xml
D linux-x86/sample/scripting/scriptpad/nbproject/project.xml
D linux-x86/sample/scripting/scriptpad/src/META-INF/manifest.mf
D linux-x86/sample/scripting/scriptpad/src/com/sun/sample/scriptpad/Main.java
D linux-x86/sample/scripting/scriptpad/src/resources/Main.js
D linux-x86/sample/scripting/scriptpad/src/resources/conc.js
D linux-x86/sample/scripting/scriptpad/src/resources/gui.js
D linux-x86/sample/scripting/scriptpad/src/resources/mm.js
D linux-x86/sample/scripting/scriptpad/src/resources/scriptpad.js
D linux-x86/sample/scripting/scriptpad/src/scripts/README.txt
D linux-x86/sample/scripting/scriptpad/src/scripts/browse.js
D linux-x86/sample/scripting/scriptpad/src/scripts/insertfile.js
D linux-x86/sample/scripting/scriptpad/src/scripts/linewrap.js
D linux-x86/sample/scripting/scriptpad/src/scripts/mail.js
D linux-x86/sample/scripting/scriptpad/src/scripts/memmonitor.js
D linux-x86/sample/scripting/scriptpad/src/scripts/memory.bat
D linux-x86/sample/scripting/scriptpad/src/scripts/memory.js
D linux-x86/sample/scripting/scriptpad/src/scripts/memory.sh
D linux-x86/sample/scripting/scriptpad/src/scripts/textcolor.js
D linux-x86/sample/try-with-resources/index.html
D linux-x86/sample/try-with-resources/src/CustomAutoCloseableSample.java
D linux-x86/sample/try-with-resources/src/Unzip.java
D linux-x86/sample/try-with-resources/src/ZipCat.java
M linux-x86/src.zip

https://android-review.googlesource.com/978088

https://goto.google.com/android-sha1/fe743aa0d39ef9bab51c612a957acdd4588d069c

li...@gmail.com <li...@gmail.com> #10May 17, 2019 02:14AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 6f65f09de487c04fa40b4734d88b92a79fe2c545
Author: Hung Nguyen <hungnv@google.com>
Date: Wed May 08 15:49:58 2019

Make Room an isolating incremental annotation processor.

This CL introduces an annotation processor option called
`room.incremental`
which the user can set to try out incremental annotation processing with
Room. It is currently off by default.

The user can pass the option through the Android Gradle plugin's DSL,
for example:

android {
defaultConfig
javaCompileOptions {
annotationProcessorOptions {
argument 'room.incremental', 'true'
}
}
}
}

Caveat: There is a JDK bug

https://bugs.openjdk.java.net/browse/JDK-8007720 that prevents Room from
being incremental (details are discussed in the code comment).
Therefore, if the JDK version being used does not already have this fix,
Room cannot be incremental and we will print out a warning to ask the
user to use a JDK version having the fix.

Note that Room currently does not track the annotation processor option
`room.schemaLocation` properly as an @OutputDirectory, and this could
impact build correctness. However, this issue impacts both
non-incremental and incremental builds, and it already existed before,
so we will fix it separately (tracked at

bug 132245929

).

Additionally, Room is currently not using the
javax.annotation.processing.Filer API to let Gradle know the originating
element of a generated schema file, so the schema files may not get
deleted properly when certain source files are deleted (tracked at bug
134472065).

Bug: 112110217
Test: New RoomIncrementalAnnotationProcessingTest
Change-Id: I0076e596b1c05bcc51afea21a4f6a9a90fb6c7be

M room/compiler/src/main/kotlin/androidx/room/RoomProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/processor/Context.kt
M room/compiler/src/main/kotlin/androidx/room/processor/ProcessorErrors.kt
A room/compiler/src/main/kotlin/androidx/room/util/SimpleJavaVersion.kt
M room/compiler/src/main/kotlin/androidx/room/vo/Warning.kt
M room/compiler/src/main/kotlin/androidx/room/writer/DaoWriter.kt
M room/compiler/src/main/kotlin/androidx/room/writer/DatabaseWriter.kt
A room/compiler/src/main/resources/META-INF/gradle/incremental.annotation.processors
M room/compiler/src/test/kotlin/androidx/room/processor/BaseDaoTest.kt
A room/compiler/src/test/kotlin/androidx/room/util/SimpleJavaVersionTest.kt
M room/compiler/src/test/kotlin/androidx/room/writer/DaoWriterTest.kt
M room/integration-tests/incremental-annotation-processing/src/test/data/simple-project/src/main/java/room/testapp/Dao1.java
M room/integration-tests/incremental-annotation-processing/src/test/data/simple-project/src/main/java/room/testapp/Dao2.java
M room/integration-tests/incremental-annotation-processing/src/test/data/simple-project/src/main/java/room/testapp/Database1.java
M room/integration-tests/incremental-annotation-processing/src/test/data/simple-project/src/main/java/room/testapp/Database2.java
M room/integration-tests/incremental-annotation-processing/src/test/data/simple-project/src/main/java/room/testapp/Entity1.java
M room/integration-tests/incremental-annotation-processing/src/test/data/simple-project/src/main/java/room/testapp/Entity2.java
D room/integration-tests/incremental-annotation-processing/src/test/kotlin/androidx/room/gradle/CompileTest.kt
A room/integration-tests/incremental-annotation-processing/src/test/kotlin/androidx/room/gradle/RoomIncrementalAnnotationProcessingTest.kt

https://android-review.googlesource.com/958285

https://goto.google.com/android-sha1/6f65f09de487c04fa40b4734d88b92a79fe2c545

ra...@google.com <ra...@google.com> #11May 17, 2019 06:03PM

Room 2.2.0 will be an incremental annotation processing when enabled via the option 'room.incremental = true'

ar...@gmail.com <ar...@gmail.com> #12Jun 10, 2019 01:18PM

When will be some alpha or at least snapshot build with this support, please?

ra...@google.com <ra...@google.com> #13Jun 10, 2019 04:05PM

in a couple of weeks, we should have it.

[Deleted User] <[Deleted User]> #14Feb 25, 2020 12:36PM

I updated to 2.2.0 stable release and added the option "room.incremental = true" to my gradle properties.
But I am still seeing this warning:
w: [kapt] Incremental annotation processing requested, but support is disabled because the following processors are not incremental: androidx.room.RoomProcessor (DYNAMIC).

Message last modified on Feb 25, 2020 12:39PM

mi...@charter.com <mi...@charter.com> #15Apr 1, 2020 11:28PM

Sorry about my last comment. I just saw I configured it wrong. It is not supposed to be se tin the gradle.properties, but in the annotationProcessorOptions.

android {
...
defaultConfig {
...
javaCompileOptions {
annotationProcessorOptions {
arguments = [
"room.schemaLocation":"$projectDir/schemas".toString(),
"room.incremental":"true",
"room.expandProjection":"true"]
}
}
}
}

Message last modified on Apr 2, 2020 03:11PM

il...@google.com <il...@google.com> #16Apr 1, 2020 11:37PM

@Yigit Will a future version of room have this enabled by default?

mi...@charter.com <mi...@charter.com> #17Apr 2, 2020 03:18PM

yes, it will be but we are looking for some feedback before we make the switch just to be safe and not break other people.