Workers executed when constraint is met crashing on Android 4.4-5.1 (WorkManager scheduling instead of JobService) [129226383]

Fixed

Bug

Status Update

No update yet.

Description

jo...@gmail.com

created issue #1

Mar 25, 2019 09:29AM

Component used: androidx.work:work-runtime
Version used: 2.0.0
Devices/Android versions reproduced on: reported on Android 5.0/5.1 (Play Console) / Android 4.4.2/4.4.4/5.0-5.1.1 (Firebase Crashlytics). Multiple devices from various manufacturers, including Samsung, Lenovo, LG, Motorola, HTC, Sony and Asus.

After updating our app from android.arch.work:work-runtime:1.0.0-rc02 to androidx.work:work-runtime:2.0.0, we're seeing crashes when WorkManager starts a job for a significant amount of our users, which doesn't make much sense because the code should be similar to the previous version but it is still a problem.
Unfortunately, we haven't been able to replicate the issue on our 4.4.2 test device. Because the issue is limited to Android versions where JobService isn't used (and the stack trace, see below), it seems like the issue is caused by WorkManager's scheduling and not the job itself.

The worker is set up by a periodic request:

Constraints workerConstraints = new Constraints.Builder().setRequiredNetworkType(NetworkType.CONNECTED).build();
PeriodicWorkRequest userUpdateWorker = new PeriodicWorkRequest.Builder(UserUpdateWorker.class, 8, TimeUnit.HOURS)
.addTag(UserUpdateWorker.class.getName())
.setConstraints(workerConstraints)
.build();
WorkManager.getInstance().enqueue(userUpdateWorker);

Stack trace from the Crashlytics/Play Console crash reports:

Fatal Exception: java.lang.RuntimeException: Error receiving broadcast Intent { act=android.net.conn.CONNECTIVITY_CHANGE flg=0x4000010 (has extras) } in androidx.work.impl.constraints.trackers.NetworkStateTracker$NetworkStateBroadcastReceiver@42849958
at android.app.LoadedApk$ReceiverDispatcher$Args.run (LoadedApk.java:941)
at android.os.Handler.handleCallback (Handler.java:739)
at android.os.Handler.dispatchMessage (Handler.java:95)
at android.os.Looper.loop (Looper.java:145)
at android.app.ActivityThread.main (ActivityThread.java:6117)
at java.lang.reflect.Method.invoke (Method.java)
at java.lang.reflect.Method.invoke (Method.java:372)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run (ZygoteInit.java:1399)
at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:1194)
Caused by java.util.concurrent.RejectedExecutionException: Task java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask@2ac263d0 rejected from java.util.concurrent.ScheduledThreadPoolExecutor@320e0fc9[Terminated, pool size = 0, active threads = 0, queued tasks = 0, completed tasks = 0]
at java.util.concurrent.ThreadPoolExecutor$AbortPolicy.rejectedExecution (ThreadPoolExecutor.java:2011)
at java.util.concurrent.ThreadPoolExecutor.reject (ThreadPoolExecutor.java:793)
at java.util.concurrent.ScheduledThreadPoolExecutor.delayedExecute (ScheduledThreadPoolExecutor.java:298)
at java.util.concurrent.ScheduledThreadPoolExecutor.schedule (ScheduledThreadPoolExecutor.java:503)
at java.util.concurrent.Executors$DelegatedScheduledExecutorService.schedule (Executors.java:644)
at androidx.work.impl.background.systemalarm.WorkTimer.startTimer (WorkTimer.java:82)
at androidx.work.impl.background.systemalarm.DelayMetCommandHandler.onAllConstraintsMet (DelayMetCommandHandler.java:100)
at androidx.work.impl.constraints.WorkConstraintsTracker.onConstraintMet (WorkConstraintsTracker.java:150)
at androidx.work.impl.constraints.controllers.ConstraintController.updateCallback (ConstraintController.java:134)
at androidx.work.impl.constraints.controllers.ConstraintController.onConstraintChanged (ConstraintController.java:141)
at androidx.work.impl.constraints.trackers.ConstraintTracker.setState (ConstraintTracker.java:103)
at androidx.work.impl.constraints.trackers.NetworkStateTracker$NetworkStateBroadcastReceiver.onReceive (NetworkStateTracker.java:170)
at android.app.LoadedApk$ReceiverDispatcher$Args.run (LoadedApk.java:931)
at android.os.Handler.handleCallback (Handler.java:739)
at android.os.Handler.dispatchMessage (Handler.java:95)
at android.os.Looper.loop (Looper.java:145)
at android.app.ActivityThread.main (ActivityThread.java:6117)
at java.lang.reflect.Method.invoke (Method.java)
at java.lang.reflect.Method.invoke (Method.java:372)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run (ZygoteInit.java:1399)
at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:1194)

Comments

jo...@gmail.com <jo...@gmail.com> #2Mar 25, 2019 09:48AM

There is no error when I use kotlin versions: 1.6.21, but issue/error starts appearing when kotlin version is 1.7.0

je...@gmail.com <je...@gmail.com> #3Mar 25, 2019 03:26PM

I have the same problem, i think no stable version of room 2.4.2 with kotlin 1.7.0

ra...@google.com <ra...@google.com> Mar 25, 2019 09:05PM

Assigned to ra...@google.com.

ap...@google.com <ap...@google.com> #4Mar 26, 2019 12:05AM

Marked as fixed.

usage implementation 'androidx.room:room-ktx:2.5.0-alpha02'

jo...@gmail.com <jo...@gmail.com> #5Mar 26, 2019 05:53AM

me too

ra...@google.com <ra...@google.com> #6Mar 26, 2019 05:25PM

Thanks for the report I was able to reproduce the issue and indeed it occurs when using Kotlin 1.7.0. Sadly I don't have a workaround yet, but will investigate further.

di...@gmail.com <di...@gmail.com> #7Apr 1, 2019 07:20PM

and just to clarify, we see the issue when using Room 2.4.2, but not with Room 2.5.0-alpha02.

[Deleted User] <[Deleted User]> #8Apr 1, 2019 07:32PM

it occurs when kotlin version 1.7.0 and room 2.5.0-alpha02 as well to me. I solved the problem by downgrading kotlin version to 1.6.20

dr...@gmail.com <dr...@gmail.com> #9Apr 6, 2019 09:13AM

The same if you trying this Google-Developer Project:

https://github.com/google-developer-training/android-basics-kotlin-sql-basics-app
I updated everything - It wasn't running.
With ext.kotlin_version = "1.6.21" - it is running.

li...@gmail.com <li...@gmail.com> #10May 17, 2019 02:14AM

As a workaround, you can remove the "suspend" in the dao, but you need to explicitly specify the Dispatchers.IO when launching the coroutine.

ra...@google.com <ra...@google.com> #11May 17, 2019 06:03PM

Hey all, looks like the issue is related to a change in Kotlin's @Metadata annotation and the way Room reads it, Room 2.4.2 is using an older version of the kotlinx-metadata-jvm library which does not support reading Kotlin 1.7 information, where as in Room 2.5.0 we updated the library.

To workaround this issue please force upgrade the dependency by adding it to your annotation processor path, i.e. add kapt "org.jetbrains.kotlinx:kotlinx-metadata-jvm:0.5.0" if you are using Room 2.4.x.

Meanwhile, I'll work on releasing a Room 2.4.3 that is compatible with Kotlin 1.7 since Room 2.5.x is still in development.

ar...@gmail.com <ar...@gmail.com> #12Jun 10, 2019 01:18PM

Thanks a lot. Now its working good for me.

ra...@google.com <ra...@google.com> #13Jun 10, 2019 04:05PM

Thanks! Do you think 2.4.3 is something that will be released in the next couple weeks? Trying to decide if I want to use the workaround or just wait until it is released.

[Deleted User] <[Deleted User]> #14Feb 25, 2020 12:36PM

We have an upcoming androidx release in July 20, I am trying to aim for that.

I also wanted to mention that if you migrate to using KSP instead of KAPT you won't run into this issue, as long as you use the KSP version that is compatible with Kotlin 1.7.0 which is 1.7.0-1.0.6.

Message last modified on Feb 25, 2020 12:39PM

mi...@charter.com <mi...@charter.com> #15Apr 1, 2020 11:28PM

It seems to be working with Kotlin 1.7.10

Message last modified on Apr 2, 2020 03:11PM

il...@google.com <il...@google.com> #16Apr 1, 2020 11:37PM

thanks a lot..

mi...@charter.com <mi...@charter.com> #17Apr 2, 2020 03:18PM

Maybe reopen this.

@Query("SELECT * FROM ${SetupData.TABLE_NAME}")
suspend fun selectAll(): Cursor

[ksp] SetupDataDao.kt:24: Not sure how to convert a Cursor to this method's return type (android.database.Cursor).

Duh!

Room 2.5.2
Kotlin 1.9
KSP 1.9.0-1.0.11