WorkManager 2.0.0 introduces crash on startup on Motorola devices running Android 6.0 and 7.0 [130182503]

Fixed

Bug

Status Update

No update yet.

Description

b....@gmail.com

created issue #1

Apr 9, 2019 03:13AM

Rolling back to 1.0.0 fixed this issue for us, issue was also present in 2.0.1-rc1. Attached is the tombstone, the crash didn't happen the first time but once it starts crashing it continues to crash on startup. Our crash reporting shows it only affects Motorola devices.

Tombstone.txt

264 KB

View

Download

Screen Shot 2019-04-09 at 1.13.04 pm.png

76 KB

View

Download

Screen Shot 2019-04-09 at 1.12.41 pm.png

124 KB

View

Download

Comments

da...@google.com <da...@google.com> #2Apr 9, 2019 04:24PM

Hi, thanks for report!

Could you attach a bit more information about the heap at this point (e.g. a heap dump) if the leak is not reproducible in trivial project?

b....@gmail.com <b....@gmail.com> #3Apr 9, 2019 08:53PM

Attached!

su...@google.com <su...@google.com> Apr 9, 2019 10:18PM

Assigned to da...@google.com.

b....@gmail.com <b....@gmail.com> #4Apr 9, 2019 10:54PM

I looked into the heap dump, seems like we are not disposing certain snapshots. Current snapshot id seems to be around 42k, but we have 108, 116 and 14123 in invalid SnapshotIdSet for current global snapshot. It is hard to figure out what caused it without repro though, as those snapshots seem to be already collected by GC.

su...@google.com <su...@google.com> #5Apr 9, 2019 11:35PM

I managed to repro it after a bunch of debugging. The bad news is that it's caused when using Coil within a LazyColumn, so that library is doing something that's causing you to leak snapshots... somehow.

Repro:

Add implementation io.coil-kt:coil-compose:2.1.0 to build.gradle
Add the following composable:

@Composable fun Leak() {
    val lazyListState = rememberLazyListState()
    val items by remember { mutableStateOf(List(10000) { it }) }

    LazyColumn(state = lazyListState) {
        items(items) {
            Box(Modifier.fillMaxWidth()) {
                AsyncImage(
                    model = "https://i.picsum.photos/id/104/200/200.jpg?hmac=3XxEVXVjwoI45-6sum_iMwNZ52GT-SJacVWr4fh4hqI",
                    contentDescription = null
                )
            }
        }
    }
}

Scroll
Memory 📈

b....@gmail.com <b....@gmail.com> #6Apr 9, 2019 11:46PM

Project: platform/frameworks/support
Branch: androidx-main

commit e82b3518094e5451dd4697f31a412c10075b28c5
Author: Andrei Shikov <ashikov@google.com>
Date: Wed Jul 20 23:43:58 2022

Dispose nested snapshots created from transparent snapshots

Adds a flag to transparent snapshots to "manage" wrapped snapshots which forces dispose of the wrapped snapshot whenever transparent one is disposed.
This flag is only enabled for the snapshots taken inside transparent snapshots, fixing memory leaks in certain conditions.

Fixes a minor bug where transparent snapshot wasn't receiving reads from nested snapshots as well.

Fixes: 239603305
Test: SnapshotTests#testNestedWithinTransparentSnapshotDisposedCorrectly

Change-Id: I62eddd279c8cf44b032d852d646c9ba21ad08a39

M compose/runtime/runtime/src/commonMain/kotlin/androidx/compose/runtime/snapshots/Snapshot.kt
M compose/runtime/runtime/src/commonTest/kotlin/androidx/compose/runtime/snapshots/SnapshotTests.kt

https://android-review.googlesource.com/2160780

su...@google.com <su...@google.com> #7Apr 9, 2019 11:50PM

Thanks for the quick turnaround!

b....@gmail.com <b....@gmail.com> #8Apr 10, 2019 12:06AM

The following release(s) address this bug:

androidx.compose.runtime:runtime:1.3.0

In_case_you_need_more.txt

17 KB

View

Download

da...@google.com <da...@google.com> #9Apr 10, 2019 12:44AM

The logs are too short its just the crash and not much else before. :(

If the phone happens to be rooted and you are OK with sharing DB queries then you can enable SQL logging so we can see the queries that are occurring:
adb shell setprop log.tag.SQLiteStatements VERBOSE
adb shell stop
adb shell start

It would also be great if you can send us a bigger set of logs, or even better yet a bugreport after the crash occurs. (

https://developer.android.com/studio/debug/bug-report)

b....@gmail.com <b....@gmail.com> #10Apr 10, 2019 01:36AM

We can't root the phone sorry, we might be able to send a bug report though

b....@gmail.com <b....@gmail.com> #11Apr 10, 2019 01:43AM

We have a bug report from the crash already actually

bugreport-2019-04-09-12-06-43.zip

2.1 MB

Download

b....@gmail.com <b....@gmail.com> #12Apr 10, 2019 03:29AM

We haven't been able to get the crash to happen on 1.0.1 so far

da...@google.com <da...@google.com> #13Apr 10, 2019 06:26PM

With a version of WorkManager that you are able to reproduce the issue, can you try adding Room 2.1.0-alpha06 as a dependency, effectively upgrading WorkManager's runtime dependency of Room?

Can you also enable WorkManager logs using setMinimumLoggingLevel(Log.DEBUG)

https://developer.android.com/topic/libraries/architecture/workmanager/advanced/custom-configuration

If you observe the crash please do take a bug report. If possible also dump dbinfo for the app's package: adb shell dumpsys dbinfo <package-name>

b....@gmail.com <b....@gmail.com> #14Apr 11, 2019 11:23AM

We have gone back to 2.0.0 and haven't been able to make it crash again unfortunately. Will keep trying. We are rolling out an update next week that reverts to 1.0.0 and will let you know if the crash goes away in production as well

su...@google.com <su...@google.com> #15Apr 11, 2019 05:58PM

I just want to distinguish between which versions you are using/experiencing this on.

1. The bug title lists 2.0.0
2. The first update lists 2.0.1-rc01
3. #14 lists 2.0.0

Can you reproduce at all with any version of WorkManager 2.x at this point? And if so, which ones work and which ones don't?

b....@gmail.com <b....@gmail.com> #16Apr 11, 2019 10:10PM

Our store version had 2.0.0 and is what the screenshots come from, we reproduced locally using that. We upgraded to 2.0.1rc1 and the phone was still crashing. We downgraded to 1.0.0 and the crash went away. To help with this testing we went back to 2.0.0 to try and get it to crash again but we haven't been able to get it to happen again.

b....@gmail.com <b....@gmail.com> #17Apr 15, 2019 10:21PM

We rolled out an update to the Play Store using WorkManager 1.0.0 and the issue has persisted unfortunately

b....@gmail.com <b....@gmail.com> #18Apr 17, 2019 12:02AM

Not sure it helps but this trace has a few more lines in it.

backtrace:
#00 pc 0000000000000000 <unknown>
#01 pc 0000000000025cdd /system/lib/libsqlite.so
#02 pc 0000000000025011 /system/lib/libsqlite.so
#03 pc 000000000000eb95 /system/lib/libsqlite.so
#04 pc 000000000002d60d /system/lib/libsqlite.so
#05 pc 000000000003b409 /system/lib/libsqlite.so
#06 pc 0000000000010931 /system/lib/libsqlite.so (sqlite3_step+536)
#07 pc 000000000007f175 /system/lib/libandroid_runtime.so
#08 pc 00000000018a0a33 /system/framework/arm/boot-framework.oat (android.database.sqlite.SQLiteConnection.nativeExecute+102)
#09 pc 00000000018a34b9 /system/framework/arm/boot-framework.oat (android.database.sqlite.SQLiteConnection.execute+260)
#10 pc 00000000018b3741 /system/framework/arm/boot-framework.oat (android.database.sqlite.SQLiteSession.endTransactionUnchecked+364)
#11 pc 00000000018b3ee5 /system/framework/arm/boot-framework.oat (android.database.sqlite.SQLiteSession.endTransaction+144)
#12 pc 00000000018ac61d /system/framework/arm/boot-framework.oat (android.database.sqlite.SQLiteDatabase.endTransaction+72)
#13 pc 00000000000a91c1 /system/lib/libart.so (art_quick_invoke_stub_internal+64)
#14 pc 00000000004031e9 /system/lib/libart.so (art_quick_invoke_stub+232)
#15 pc 00000000000b0455 /system/lib/libart.so (_ZN3art9ArtMethod6InvokeEPNS_6ThreadEPjjPNS_6JValueEPKc+136)
#16 pc 00000000001ec389 /system/lib/libart.so (_ZN3art11interpreter34ArtInterpreterToCompiledCodeBridgeEPNS_6ThreadEPNS_9ArtMethodEPKNS_7DexFile8CodeItemEPNS_11ShadowFrameEPNS_6JValueE+200)
#17 pc 00000000001e6939 /system/lib/libart.so (_ZN3art11interpreter6DoCallILb0ELb0EEEbPNS_9ArtMethodEPNS_6ThreadERNS_11ShadowFrameEPKNS_11InstructionEtPNS_6JValueE+492)
#18 pc 00000000003fd663 /system/lib/libart.so (MterpInvokeVirtualQuick+322)
#19 pc 000000000009fd94 /system/lib/libart.so (ExecuteMterpImpl+29972)
#20 pc 00000000001ca783 /system/lib/libart.so (_ZN3art11interpreterL7ExecuteEPNS_6ThreadEPKNS_7DexFile8CodeItemERNS_11ShadowFrameENS_6JValueEb+290)
#21 pc 00000000001cf2eb /system/lib/libart.so (_ZN3art11interpreter33ArtInterpreterToInterpreterBridgeEPNS_6ThreadEPKNS_7DexFile8CodeItemEPNS_11ShadowFrameEPNS_6JValueE+114)
#22 pc 00000000001e691f /system/lib/libart.so (_ZN3art11interpreter6DoCallILb0ELb0EEEbPNS_9ArtMethodEPNS_6ThreadERNS_11ShadowFrameEPKNS_11InstructionEtPNS_6JValueE+466)
#23 pc 00000000003fb92b /system/lib/libart.so (MterpInvokeInterface+826)
#24 pc 000000000009c214 /system/lib/libart.so (ExecuteMterpImpl+14740)
#25 pc 00000000001ca783 /system/lib/libart.so (_ZN3art11interpreterL7ExecuteEPNS_6ThreadEPKNS_7DexFile8CodeItemERNS_11ShadowFrameENS_6JValueEb+290)
#26 pc 00000000001cf2eb /system/lib/libart.so (_ZN3art11interpreter33ArtInterpreterToInterpreterBridgeEPNS_6ThreadEPKNS_7DexFile8CodeItemEPNS_11ShadowFrameEPNS_6JValueE+114)
#27 pc 00000000001e691f /system/lib/libart.so (_ZN3art11interpreter6DoCallILb0ELb0EEEbPNS_9ArtMethodEPNS_6ThreadERNS_11ShadowFrameEPKNS_11InstructionEtPNS_6JValueE+466)
#28 pc 00000000003fd663 /system/lib/libart.so (MterpInvokeVirtualQuick+322)
#29 pc 000000000009fd94 /system/lib/libart.so (ExecuteMterpImpl+29972)
#30 pc 00000000001ca783 /system/lib/libart.so (_ZN3art11interpreterL7ExecuteEPNS_6ThreadEPKNS_7DexFile8CodeItemERNS_11ShadowFrameENS_6JValueEb+290)
#31 pc 00000000001cf255 /system/lib/libart.so (_ZN3art11interpreter30EnterInterpreterFromEntryPointEPNS_6ThreadEPKNS_7DexFile8CodeItemEPNS_11ShadowFrameE+92)
#32 pc 00000000003f269f /system/lib/libart.so (artQuickToInterpreterBridge+706)
#33 pc 00000000000adc13 /system/lib/libart.so (art_quick_to_interpreter_bridge+34)
#34 pc 000000000064b125 /system/framework/arm/boot-core-libart.oat (java.util.concurrent.ThreadPoolExecutor.runWorker+344)
#35 pc 0000000000652b47 /system/framework/arm/boot-core-libart.oat (java.util.concurrent.ThreadPoolExecutor$Worker.run+42)
#36 pc 00000000005f749d /system/framework/arm/boot.oat (java.lang.Thread.run+48)
#37 pc 00000000000a91c1 /system/lib/libart.so (art_quick_invoke_stub_internal+64)
#38 pc 00000000004031e9 /system/lib/libart.so (art_quick_invoke_stub+232)
#39 pc 00000000000b0455 /system/lib/libart.so (_ZN3art9ArtMethod6InvokeEPNS_6ThreadEPjjPNS_6JValueEPKc+136)
#40 pc 0000000000314031 /system/lib/libart.so (_ZN3artL18InvokeWithArgArrayERKNS_33ScopedObjectAccessAlreadyRunnableEPNS_9ArtMethodEPNS_8ArgArrayEPNS_6JValueEPKc+56)
#41 pc 0000000000314dfd /system/lib/libart.so (_ZN3art35InvokeVirtualOrInterfaceWithJValuesERKNS_33ScopedObjectAccessAlreadyRunnableEP8_jobjectP10_jmethodIDP6jvalue+256)
#42 pc 000000000032be19 /system/lib/libart.so (_ZN3art6Thread14CreateCallbackEPv+848)
#43 pc 0000000000046eb3 /system/lib/libc.so (_ZL15__pthread_startPv+22)
#44 pc 0000000000019acd /system/lib/libc.so (__start_thread+6)

su...@google.com <su...@google.com> #19Apr 18, 2019 08:53PM

Unfortunately, this is still not telling us anything we can diagnose. Paired with the fact that we haven't gotten any other reports of this issue, it's not clear how we should proceed. We would need Motorola system images to proceed at this point. I can suggest one more thing: if you go back to the last version that worked fine for you and simply change your WorkManager dependency (but *not* any of the rest of your app's code changes), does it immediately exhibit the crash? Basically, I'm wondering if something else with your code is triggering or exacerbating the issue.

su...@google.com <su...@google.com> #20Apr 23, 2019 11:26PM

Ping to the original reporter(s).

b....@gmail.com <b....@gmail.com> #21Apr 29, 2019 01:34AM

Sorry I have been on leave for Easter. I think you are right about some other code change triggering this bug, will see if I can work anything out. I am at I/O next week as well if you want to have a look yourself.

su...@google.com <su...@google.com> #22Apr 29, 2019 04:42PM

Status: Won't Fix (Infeasible)

Thanks, closing this out for now - feel free to reply if there's anything else we can assist you with on this matter.

b....@gmail.com <b....@gmail.com> #23Apr 30, 2019 12:52AM

This is a definite stab in the dark but do you use a ForeignKey with Room? This is the only reference I can find to similar crashes online.

https://stackoverflow.com/questions/50662521/tombstone-using-foreignkey-with-room

su...@google.com <su...@google.com> #24Apr 30, 2019 04:38PM

We do use foreign keys, but we've been doing that since our early alpha versions so I'm not sure that's it.

b....@gmail.com <b....@gmail.com> #25Apr 30, 2019 10:00PM

Fair enough, both crash reports have this sqlite3_step+536 in common. Will keep trying to work it out.

b....@gmail.com <b....@gmail.com> #26May 6, 2019 09:16PM

We seem to have narrowed this down to calling

WorkManager.initialize(applicationContext, workManagerConfig)
WorkManager.getInstance().getWorkInfosByTagLiveData(DownloadManager.WORK_MANAGER_DOWNLOAD_TAG).observeForever {}

If we wrap the second line in a coroutine to main just to delay it a cycle then the crash goes away, at least on our test device. We might roll out the fix to test it.

su...@google.com <su...@google.com> #27May 6, 2019 09:23PM

Hi, I'm glad you have some reproducible steps. It would help us a lot if you could actually boil this down to a minimal sample app that can reproduce it so you can share it with us and we can also examine what is going wrong.

b....@gmail.com <b....@gmail.com> #28May 6, 2019 09:55PM

Done! This crashes for us on the second launch, you need a large amount queued jobs for it to happen. Testing on a Moto X 2014 victara running Android 6.0.

WorkManagerCrash.zip

726 KB

Download

ra...@google.com <ra...@google.com> #29May 21, 2019 05:20PM

Status: Assigned (reopened)

We managed to get a test device, and I can reproduce it.

I see this:

05-21 10:18:50.804 352 352 D SFPerfTracer: layers: (6:13) (FocusedStackFrame (0xb8370eb8): 0:108)* (DimLayer (0xb83412c0): 9:12) (StatusBar (0xb83bbf38): 0:701) (NavigationBar (0xb8389d10): 0:550) (com.android.systemui.ImageWallpaper (0xb83b23f8): 0:234) (DimLayer (0xb83989f0): 0:45)- (DimLayer (0xb83907e0): 0:8)- (com.example.workmanagercrash/com.example.workmanagercrash.MainActivity (0xb836c948): 0:31)- (com.android.systemui/com.android.systemui.recents.RecentsActivity (0xb838d188): 0:58)- (thumbnail anim (0xb834e7a0): 0:23)- (com.google.android.googlequicksearchbox/com.google.android.launcher.GEL (0xb834e7a0): 0:13) (Application Error: com.example.workmanagercrash (0xb83989f0): 8:14)
05-21 10:18:50.804 463 463 F DEBUG : *** *** *** *** *** *** *** *** *** *** *** *** *** *** *** ***
05-21 10:18:50.804 463 463 F DEBUG : Build fingerprint: 'motorola/victara_tmo/victara:6.0/MPES24.49-18-7/7:user/release-keys'
05-21 10:18:50.805 463 463 F DEBUG : Revision: 'p2bf'
05-21 10:18:50.805 463 463 F DEBUG : ABI: 'arm'
05-21 10:18:50.805 463 463 F DEBUG : pid: 9165, tid: 9180, name: WorkManager-Wor >>> com.example.workmanagercrash <<<
05-21 10:18:50.805 463 463 F DEBUG : signal 11 (SIGSEGV), code 1 (SEGV_MAPERR), fault addr 0x0
05-21 10:18:50.819 463 463 F DEBUG : r0 b9b04660 r1 af9ece50 r2 00000000 r3 00000002
05-21 10:18:50.819 463 463 F DEBUG : r4 b9b044b8 r5 b692e118 r6 00000000 r7 b9b04f08
05-21 10:18:50.819 463 463 F DEBUG : r8 00000001 r9 b9b044b8 sl 00000000 fp 00000002
05-21 10:18:50.819 463 463 F DEBUG : ip b692ddfc sp af9ece28 lr b6881e5b pc 00000000 cpsr 200f0010
05-21 10:18:50.823 463 463 F DEBUG :
05-21 10:18:50.823 463 463 F DEBUG : backtrace:
05-21 10:18:50.824 463 463 F DEBUG : #00 pc 00000000 <unknown>
05-21 10:18:50.824 463 463 F DEBUG : #01 pc 00024e59 /system/lib/libsqlite.so
05-21 10:18:50.824 463 463 F DEBUG : #02 pc 00024173 /system/lib/libsqlite.so
05-21 10:18:50.824 463 463 F DEBUG : #03 pc 0000e759 /system/lib/libsqlite.so
05-21 10:18:50.824 463 463 F DEBUG : #04 pc 0002be41 /system/lib/libsqlite.so
05-21 10:18:50.824 463 463 F DEBUG : #05 pc 00039ad7 /system/lib/libsqlite.so
05-21 10:18:50.824 463 463 F DEBUG : #06 pc 0000ffc5 /system/lib/libsqlite.so (sqlite3_step+724)
05-21 10:18:50.824 463 463 F DEBUG : #07 pc 00075021 /system/lib/libandroid_runtime.so
05-21 10:18:50.824 463 463 F DEBUG : #08 pc 02287663 /system/framework/arm/boot.oat (offset 0x1fda000)
05-21 10:18:51.062 1769 2069 V AlarmManager: sending alarm {f6ba791 type 3 *alarm*:android.content.jobscheduler.JOB_DELAY_EXPIRED}
05-21 10:18:51.065 1769 1769 V AlarmManager: done {f6ba791, *alarm*:android.content.jobscheduler.JOB_DELAY_EXPIRED} [3ms]
05-21 10:18:51.131 463 463 F DEBUG :
05-21 10:18:51.131 463 463 F DEBUG : Tombstone written to: /data/tombstones/tombstone_01
05-21 10:18:51.131 463 463 E DEBUG : AM write failed: Broken pipe
05-21 10:18:51.133 1769 1786 I BootReceiver: Copying /data/tombstones/tombstone_01 to DropBox (SYSTEM_TOMBSTONE)
05-21 10:18:51.184 485 485 I Zygote : Process 9165 exited due to signal (11)
05-21 10:18:51.214 1769 2729 I ActivityManager: Process com.example.workmanagercrash (pid 9165) has died
05-21 10:18:51.215 1769 2729 W ActivityManager: Scheduling restart of crashed service com.example.workmanagercrash/androidx.work.impl.background.systemjob.SystemJobService in 1000ms
05-21 10:18:51.238 1769 1769 I ActivityManager: Start proc 9188:com.example.workmanagercrash/u0a106 for service com.example.workmanagercrash/androidx.work.impl.background.systemjob.SystemJobService
05-21 10:18:51.256 9188 9188 I art : Late-enabling -Xcheck:jni
05-21 10:18:51.301 9188 9188 W System : ClassLoader referenced unknown path: /data/app/com.example.workmanagercrash-1/lib/arm
05-21 10:18:51.476 9188 9202 F libc : Fatal signal 11 (SIGSEGV), code 1, fault addr 0x0 in tid 9202 (WorkManager-Wor)
05-21 10:18:51.578 463 463 F DEBUG : *** *** *** *** *** *** *** *** *** *** *** *** *** *** *** ***
05-21 10:18:51.578 463 463 F DEBUG : Build fingerprint: 'motorola/victara_tmo/victara:6.0/MPES24.49-18-7/7:user/release-keys'
05-21 10:18:51.579 463 463 F DEBUG : Revision: 'p2bf'
05-21 10:18:51.579 463 463 F DEBUG : ABI: 'arm'
05-21 10:18:51.579 463 463 F DEBUG : pid: 9188, tid: 9202, name: WorkManager-Wor >>> com.example.workmanagercrash <<<
05-21 10:18:51.580 463 463 F DEBUG : signal 11 (SIGSEGV), code 1 (SEGV_MAPERR), fault addr 0x0
05-21 10:18:51.609 463 463 F DEBUG : r0 b9b048c0 r1 af9ece50 r2 00000000 r3 00000002
05-21 10:18:51.609 463 463 F DEBUG : r4 b9b04718 r5 b692e118 r6 00000000 r7 b9b05170
05-21 10:18:51.609 463 463 F DEBUG : r8 00000001 r9 b9b04718 sl 00000000 fp 00000002
05-21 10:18:51.609 463 463 F DEBUG : ip b692ddfc sp af9ece28 lr b6881e5b pc 00000000 cpsr 200f0010
05-21 10:18:51.615 463 463 F DEBUG :
05-21 10:18:51.615 463 463 F DEBUG : backtrace:
05-21 10:18:51.616 463 463 F DEBUG : #00 pc 00000000 <unknown>
05-21 10:18:51.616 463 463 F DEBUG : #01 pc 00024e59 /system/lib/libsqlite.so
05-21 10:18:51.616 463 463 F DEBUG : #02 pc 00024173 /system/lib/libsqlite.so
05-21 10:18:51.616 463 463 F DEBUG : #03 pc 0000e759 /system/lib/libsqlite.so
05-21 10:18:51.616 463 463 F DEBUG : #04 pc 0002be41 /system/lib/libsqlite.so
05-21 10:18:51.616 463 463 F DEBUG : #05 pc 00039ad7 /system/lib/libsqlite.so
05-21 10:18:51.616 463 463 F DEBUG : #06 pc 0000ffc5 /system/lib/libsqlite.so (sqlite3_step+724)
05-21 10:18:51.616 463 463 F DEBUG : #07 pc 00075021 /system/lib/libandroid_runtime.so
05-21 10:18:51.616 463 463 F DEBUG : #08 pc 02287663 /system/framework/arm/boot.oat (offset 0x1fda000)
05-21 10:18:51.902 463 463 F DEBUG :
05-21 10:18:51.902 463 463 F DEBUG : Tombstone written to: /data/tombstones/tombstone_02
05-21 10:18:51.902 463 463 E DEBUG : AM write failed: Broken pipe
05-21 10:18:51.903 1769 1786 I BootReceiver: Copying /data/tombstones/tombstone_02 to DropBox (SYSTEM_TOMBSTONE)
05-21 10:18:51.952 485 485 I Zygote : Process 9188 exited due to signal (11)
05-21 10:18:51.966 1769 2757 I ActivityManager: Process com.example.workmanagercrash (pid 9188) has died

ap...@google.com <ap...@google.com> #30May 22, 2019 05:35PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 957adb282e41c2662fff6221325e6b51cd7377f9
Author: Rahul Ravikumar <rahulrav@google.com>
Date: Tue May 21 14:37:00 2019

Fixes SQLite issues on some devices.

* Always beginTransaction() outside a try.
* Make sure SystemJobScheduler marks transactions as successful.

Test: Existing tests pass.
Fixes:

b/130182503

b/132697495

Change-Id: I55092537781fbfee97f4336eb7cf1a49e647d62a

M work/workmanager-gcm/src/main/java/androidx/work/impl/background/gcm/WorkManagerGcmDispatcher.java
M work/workmanager/src/main/java/androidx/work/impl/WorkerWrapper.java
M work/workmanager/src/main/java/androidx/work/impl/background/systemjob/SystemJobScheduler.java
M work/workmanager/src/main/java/androidx/work/impl/utils/ForceStopRunnable.java

https://android-review.googlesource.com/966057

https://goto.google.com/android-sha1/957adb282e41c2662fff6221325e6b51cd7377f9

lo...@gmail.com <lo...@gmail.com> #31May 22, 2019 08:29PM

Will it be fixed in a maintainance release of 2.0, or will we have to wait for 2.1 next RC or release?

ra...@google.com <ra...@google.com> #32May 22, 2019 08:35PM

This will show up in the next 2.1.0 release.

Issue 130182503

Description

Issue summary

Comments

da...@google.com <da...@google.com> #2Apr 9, 2019 04:24PM

b....@gmail.com <b....@gmail.com> #3Apr 9, 2019 08:53PM

su...@google.com <su...@google.com> Apr 9, 2019 10:18PM

b....@gmail.com <b....@gmail.com> #4Apr 9, 2019 10:54PM

su...@google.com <su...@google.com> #5Apr 9, 2019 11:35PM

b....@gmail.com <b....@gmail.com> #6Apr 9, 2019 11:46PM

su...@google.com <su...@google.com> #7Apr 9, 2019 11:50PM

b....@gmail.com <b....@gmail.com> #8Apr 10, 2019 12:06AM

da...@google.com <da...@google.com> #9Apr 10, 2019 12:44AM

b....@gmail.com <b....@gmail.com> #10Apr 10, 2019 01:36AM

b....@gmail.com <b....@gmail.com> #11Apr 10, 2019 01:43AM

b....@gmail.com <b....@gmail.com> #12Apr 10, 2019 03:29AM

da...@google.com <da...@google.com> #13Apr 10, 2019 06:26PM

b....@gmail.com <b....@gmail.com> #14Apr 11, 2019 11:23AM

su...@google.com <su...@google.com> #15Apr 11, 2019 05:58PM

b....@gmail.com <b....@gmail.com> #16Apr 11, 2019 10:10PM

b....@gmail.com <b....@gmail.com> #17Apr 15, 2019 10:21PM

b....@gmail.com <b....@gmail.com> #18Apr 17, 2019 12:02AM

su...@google.com <su...@google.com> #19Apr 18, 2019 08:53PM

su...@google.com <su...@google.com> #20Apr 23, 2019 11:26PM

b....@gmail.com <b....@gmail.com> #21Apr 29, 2019 01:34AM

su...@google.com <su...@google.com> #22Apr 29, 2019 04:42PM

b....@gmail.com <b....@gmail.com> #23Apr 30, 2019 12:52AM

su...@google.com <su...@google.com> #24Apr 30, 2019 04:38PM

b....@gmail.com <b....@gmail.com> #25Apr 30, 2019 10:00PM

b....@gmail.com <b....@gmail.com> #26May 6, 2019 09:16PM

su...@google.com <su...@google.com> #27May 6, 2019 09:23PM

b....@gmail.com <b....@gmail.com> #28May 6, 2019 09:55PM

ra...@google.com <ra...@google.com> #29May 21, 2019 05:20PM

ap...@google.com <ap...@google.com> #30May 22, 2019 05:35PM

lo...@gmail.com <lo...@gmail.com> #31May 22, 2019 08:29PM

ra...@google.com <ra...@google.com> #32May 22, 2019 08:35PM

Add comment

Issue metadata