Fixed
Status Update
Comments
li...@gmail.com <li...@gmail.com> #2
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 92bd7222fcfd7523e8fa80b7f72e967b8bbf4750
Author: Ian Lake <ilake@google.com>
Date: Tue Aug 27 10:07:52 2019
Split LifecycleCallbacks from FragmentManager
Create a separate FragmentLifecycleCallbacksDispatcher
object that is responsible for dispatching
FragmentLifecycleCallbacks events.
Test: existing FragmentLifecycleTest pass
BUG: 139536619
Change-Id: I64cc2b364af65760b0008efb317a742df2c0718d
A fragment/fragment/src/main/java/androidx/fragment/app/FragmentLifecycleCallbacksDispatcher.java
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentManager.java
https://android-review.googlesource.com/1110155
https://goto.google.com/android-sha1/92bd7222fcfd7523e8fa80b7f72e967b8bbf4750
Branch: androidx-master-dev
commit 92bd7222fcfd7523e8fa80b7f72e967b8bbf4750
Author: Ian Lake <ilake@google.com>
Date: Tue Aug 27 10:07:52 2019
Split LifecycleCallbacks from FragmentManager
Create a separate FragmentLifecycleCallbacksDispatcher
object that is responsible for dispatching
FragmentLifecycleCallbacks events.
Test: existing FragmentLifecycleTest pass
BUG: 139536619
Change-Id: I64cc2b364af65760b0008efb317a742df2c0718d
A fragment/fragment/src/main/java/androidx/fragment/app/FragmentLifecycleCallbacksDispatcher.java
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentManager.java
ra...@google.com <ra...@google.com> #3
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 092d14cd22c174405221b930665869f7c9fc8b65
Author: Ian Lake <ilake@google.com>
Date: Tue Aug 27 14:46:02 2019
Remove FragmentState mInstance
Make FragmentState a simple Parcelable by removing
its mInstance field and its instantiate() method.
This required we change the order of restoring:
instead of reconnecting retained Fragments with their
FragmentState instances, we first iterate through
all FragmentState instances and do one of two things:
1) Reconnect the retained fragment if it exists
2) Create a new fragment from the FragmentState
This allows us to do just one pass through our
FragmentState objects and run the edge case of
detecting retained fragments created after the
state was saved after creating the set of active
fragments.
Test: all existing tests pass
BUG: 139536619
Change-Id: Iba7cc300c127bc05127d122fa5acc1ccc871a76b
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentManager.java
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentManagerViewModel.java
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentState.java
https://android-review.googlesource.com/1108716
https://goto.google.com/android-sha1/092d14cd22c174405221b930665869f7c9fc8b65
Branch: androidx-master-dev
commit 092d14cd22c174405221b930665869f7c9fc8b65
Author: Ian Lake <ilake@google.com>
Date: Tue Aug 27 14:46:02 2019
Remove FragmentState mInstance
Make FragmentState a simple Parcelable by removing
its mInstance field and its instantiate() method.
This required we change the order of restoring:
instead of reconnecting retained Fragments with their
FragmentState instances, we first iterate through
all FragmentState instances and do one of two things:
1) Reconnect the retained fragment if it exists
2) Create a new fragment from the FragmentState
This allows us to do just one pass through our
FragmentState objects and run the edge case of
detecting retained fragments created after the
state was saved after creating the set of active
fragments.
Test: all existing tests pass
BUG: 139536619
Change-Id: Iba7cc300c127bc05127d122fa5acc1ccc871a76b
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentManager.java
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentManagerViewModel.java
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentState.java
ra...@google.com <ra...@google.com> #4
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 66d98b470d8887fdd16461c2da0df69ec62dd8d8
Author: Ian Lake <ilake@google.com>
Date: Fri Aug 16 13:22:20 2019
Add skeleton for FragmentStateManager
Store a HashMap of mWho to FragmentStateManager
instances. This serves as the minimal starting
point for moving logic that interacts with a
single Fragment from FragmentManager into
FragmentStateManager.
Test: existing tests pass, new FragmentStateManagerTest
BUG: 139536619
Change-Id: Ifaea272a3202e918143f65245fb98157ad971827
A fragment/fragment/src/androidTest/java/androidx/fragment/app/FragmentStateManagerTest.kt
M fragment/fragment/src/main/java/androidx/fragment/app/BackStackState.java
M fragment/fragment/src/main/java/androidx/fragment/app/Fragment.java
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentManager.java
A fragment/fragment/src/main/java/androidx/fragment/app/FragmentStateManager.java
https://android-review.googlesource.com/1109796
https://goto.google.com/android-sha1/66d98b470d8887fdd16461c2da0df69ec62dd8d8
Branch: androidx-master-dev
commit 66d98b470d8887fdd16461c2da0df69ec62dd8d8
Author: Ian Lake <ilake@google.com>
Date: Fri Aug 16 13:22:20 2019
Add skeleton for FragmentStateManager
Store a HashMap of mWho to FragmentStateManager
instances. This serves as the minimal starting
point for moving logic that interacts with a
single Fragment from FragmentManager into
FragmentStateManager.
Test: existing tests pass, new FragmentStateManagerTest
BUG: 139536619
Change-Id: Ifaea272a3202e918143f65245fb98157ad971827
A fragment/fragment/src/androidTest/java/androidx/fragment/app/FragmentStateManagerTest.kt
M fragment/fragment/src/main/java/androidx/fragment/app/BackStackState.java
M fragment/fragment/src/main/java/androidx/fragment/app/Fragment.java
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentManager.java
A fragment/fragment/src/main/java/androidx/fragment/app/FragmentStateManager.java
ni...@gmail.com <ni...@gmail.com> #5
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 92d322f39a3436da8ce0e59f55194c70abe1fb8e
Author: Ian Lake <ilake@google.com>
Date: Tue Aug 27 16:46:05 2019
Move saving/restore Fragment state to FragmentStateManager
Separate the saving and restoring of Fragment
instances from FragmentManager, allowing
FragmentStateManager to fully manage the
restoration of Fragments.
Test: new FragmentStateManagerTest, existing tests
BUG: 139536619
Change-Id: Iba0df8f617d7805995612eaad52e26f5f2e99707
M fragment/fragment/src/androidTest/java/androidx/fragment/app/FragmentStateManagerTest.kt
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentManager.java
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentStateManager.java
https://android-review.googlesource.com/1109797
https://goto.google.com/android-sha1/92d322f39a3436da8ce0e59f55194c70abe1fb8e
Branch: androidx-master-dev
commit 92d322f39a3436da8ce0e59f55194c70abe1fb8e
Author: Ian Lake <ilake@google.com>
Date: Tue Aug 27 16:46:05 2019
Move saving/restore Fragment state to FragmentStateManager
Separate the saving and restoring of Fragment
instances from FragmentManager, allowing
FragmentStateManager to fully manage the
restoration of Fragments.
Test: new FragmentStateManagerTest, existing tests
BUG: 139536619
Change-Id: Iba0df8f617d7805995612eaad52e26f5f2e99707
M fragment/fragment/src/androidTest/java/androidx/fragment/app/FragmentStateManagerTest.kt
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentManager.java
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentStateManager.java
ra...@google.com <ra...@google.com> #6
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 5318d9bfea4baae7190875673fd087b9526c30c5
Author: Ian Lake <ilake@google.com>
Date: Wed Sep 04 13:40:58 2019
Move ensureInflatedFragmentView to FragmentStateManager
Move this logic into FragmentStateManager.
Test: all existing tests pass
BUG: 139536619
Change-Id: I1f8fafba5e35fda592bbe13954eed2ff355aae55
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentManager.java
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentStateManager.java
https://android-review.googlesource.com/1113752
https://goto.google.com/android-sha1/5318d9bfea4baae7190875673fd087b9526c30c5
Branch: androidx-master-dev
commit 5318d9bfea4baae7190875673fd087b9526c30c5
Author: Ian Lake <ilake@google.com>
Date: Wed Sep 04 13:40:58 2019
Move ensureInflatedFragmentView to FragmentStateManager
Move this logic into FragmentStateManager.
Test: all existing tests pass
BUG: 139536619
Change-Id: I1f8fafba5e35fda592bbe13954eed2ff355aae55
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentManager.java
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentStateManager.java
ni...@gmail.com <ni...@gmail.com> #7
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 61497f97f85997ed8bf4dd58d6e513e810784f1e
Author: Ian Lake <ilake@google.com>
Date: Fri Sep 20 14:23:27 2019
Have FragmentStateManager compute the Fragment's max state
Move logic restricting the Fragment to a particular
state into FragmentStateManager.
Test: all existing tests pass
BUG: 139536619
Change-Id: Ief8528ed9990da515f0765199f64f4ca04bd2494
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentManager.java
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentStateManager.java
https://android-review.googlesource.com/1126844
https://goto.google.com/android-sha1/61497f97f85997ed8bf4dd58d6e513e810784f1e
Branch: androidx-master-dev
commit 61497f97f85997ed8bf4dd58d6e513e810784f1e
Author: Ian Lake <ilake@google.com>
Date: Fri Sep 20 14:23:27 2019
Have FragmentStateManager compute the Fragment's max state
Move logic restricting the Fragment to a particular
state into FragmentStateManager.
Test: all existing tests pass
BUG: 139536619
Change-Id: Ief8528ed9990da515f0765199f64f4ca04bd2494
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentManager.java
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentStateManager.java
su...@google.com <su...@google.com> #8
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 359974ef2d7a879b4a96373b96e1c537b252dfa2
Author: Ian Lake <ilake@google.com>
Date: Thu Sep 26 14:56:35 2019
Move start/resume/pause/stop to FragmentStateManager
Test: Fragment tests still pass
BUG: 139536619
Change-Id: I1cabaaa361e9b0d0e142b06e5d9ee4a7c1b1e4c4
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentManager.java
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentStateManager.java
https://android-review.googlesource.com/1129475
https://goto.google.com/android-sha1/359974ef2d7a879b4a96373b96e1c537b252dfa2
Branch: androidx-master-dev
commit 359974ef2d7a879b4a96373b96e1c537b252dfa2
Author: Ian Lake <ilake@google.com>
Date: Thu Sep 26 14:56:35 2019
Move start/resume/pause/stop to FragmentStateManager
Test: Fragment tests still pass
BUG: 139536619
Change-Id: I1cabaaa361e9b0d0e142b06e5d9ee4a7c1b1e4c4
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentManager.java
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentStateManager.java
ni...@gmail.com <ni...@gmail.com> #9
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 669381d551753c454afbf5ff5d0cfb66bac78247
Author: Ian Lake <ilake@google.com>
Date: Tue Oct 01 11:14:39 2019
Move attach/detach to FragmentStateManager
Logic in dealing with target fragments and
mActive remain in moveToState() for now.
Test: Fragment tests still pass
BUG: 139536619
Change-Id: If65bce1b315b7e5a9010a39044c406cb3d3be37d
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentManager.java
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentStateManager.java
https://android-review.googlesource.com/1131672
https://goto.google.com/android-sha1/669381d551753c454afbf5ff5d0cfb66bac78247
Branch: androidx-master-dev
commit 669381d551753c454afbf5ff5d0cfb66bac78247
Author: Ian Lake <ilake@google.com>
Date: Tue Oct 01 11:14:39 2019
Move attach/detach to FragmentStateManager
Logic in dealing with target fragments and
mActive remain in moveToState() for now.
Test: Fragment tests still pass
BUG: 139536619
Change-Id: If65bce1b315b7e5a9010a39044c406cb3d3be37d
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentManager.java
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentStateManager.java
su...@google.com <su...@google.com> #10
Project: platform/frameworks/support
Branch: androidx-master-dev
commit bef266f3ab8734afc111c70413687380ad2d9161
Author: Ian Lake <ilake@google.com>
Date: Tue Oct 01 11:04:33 2019
Move create/destroy to FragmentStateManager
Due to restoreSaveState()'s cleaning up
of no longer valid retained Fragments, moveToState()
now always creates a FragmentStateManager if one
does not exist so that we can continue to run the
create callbacks despite these retained Fragments
not being in mActive.
Interactions with mExitAnimationCancellationSignals
as part of destroying the Fragment remain in
moveToState() for now.
Test: Fragment tests still pass
BUG: 139536619
Change-Id: Id05f4e78f6fc0cef6be9cc7abc0d58b40b2e3f43
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentManager.java
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentStateManager.java
https://android-review.googlesource.com/1131291
https://goto.google.com/android-sha1/bef266f3ab8734afc111c70413687380ad2d9161
Branch: androidx-master-dev
commit bef266f3ab8734afc111c70413687380ad2d9161
Author: Ian Lake <ilake@google.com>
Date: Tue Oct 01 11:04:33 2019
Move create/destroy to FragmentStateManager
Due to restoreSaveState()'s cleaning up
of no longer valid retained Fragments, moveToState()
now always creates a FragmentStateManager if one
does not exist so that we can continue to run the
create callbacks despite these retained Fragments
not being in mActive.
Interactions with mExitAnimationCancellationSignals
as part of destroying the Fragment remain in
moveToState() for now.
Test: Fragment tests still pass
BUG: 139536619
Change-Id: Id05f4e78f6fc0cef6be9cc7abc0d58b40b2e3f43
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentManager.java
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentStateManager.java
ni...@gmail.com <ni...@gmail.com> #11
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 0d32170b1e98a00ab67b487241bbba687ad99d79
Author: Ian Lake <ilake@google.com>
Date: Tue Oct 01 10:49:06 2019
Move restoreState() out of moveToState()
We can safely call restoreState() immediately
after creating a FragmentStateManager instance
rather than waiting for moveToState().
This simplifies the logic required since
we know we'll have the correct value of
mDeferStart before computeMaxState().
Test: all existing tests still pass
BUG: 139536619
Change-Id: I4602a4987c4f20c9ccf3a083b8ecb48f963be1c4
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentManager.java
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentStateManager.java
https://android-review.googlesource.com/1130436
https://goto.google.com/android-sha1/0d32170b1e98a00ab67b487241bbba687ad99d79
Branch: androidx-master-dev
commit 0d32170b1e98a00ab67b487241bbba687ad99d79
Author: Ian Lake <ilake@google.com>
Date: Tue Oct 01 10:49:06 2019
Move restoreState() out of moveToState()
We can safely call restoreState() immediately
after creating a FragmentStateManager instance
rather than waiting for moveToState().
This simplifies the logic required since
we know we'll have the correct value of
mDeferStart before computeMaxState().
Test: all existing tests still pass
BUG: 139536619
Change-Id: I4602a4987c4f20c9ccf3a083b8ecb48f963be1c4
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentManager.java
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentStateManager.java
ra...@google.com <ra...@google.com> #12
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 586ebfe6f9f34efde5a08c2c6fcc18428738d580
Author: Ian Lake <ilake@google.com>
Date: Fri Oct 04 14:17:21 2019
Explicitly map Lifecycle.State values to Fragment state
Instead of relying on ordinal() to translate
between Lifecycle.State enums and Fragment state
values, we explicitly map between them when computing
the max state of the Fragment.
Test: all existing tests pass
BUG: 139536619
Change-Id: I11ab18748942c78a7e5027bc91eeddc9fcc0c6be
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentStateManager.java
https://android-review.googlesource.com/1133982
https://goto.google.com/android-sha1/586ebfe6f9f34efde5a08c2c6fcc18428738d580
Branch: androidx-master-dev
commit 586ebfe6f9f34efde5a08c2c6fcc18428738d580
Author: Ian Lake <ilake@google.com>
Date: Fri Oct 04 14:17:21 2019
Explicitly map Lifecycle.State values to Fragment state
Instead of relying on ordinal() to translate
between Lifecycle.State enums and Fragment state
values, we explicitly map between them when computing
the max state of the Fragment.
Test: all existing tests pass
BUG: 139536619
Change-Id: I11ab18748942c78a7e5027bc91eeddc9fcc0c6be
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentStateManager.java
ni...@gmail.com <ni...@gmail.com> #13
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 20f7c62349217f2b3f79a3c7548b2331235de42c
Author: Ian Lake <ilake@google.com>
Date: Fri Oct 04 10:42:27 2019
Move ACTIVITY_CREATED to FragmentStateManager
Moving to the ACTIVITY_CREATED state in
FragmentManager involves three actions:
- Creating the View
- Calling onActivityCreated()
- Calling onViewStateRestored
Move these as three separate methods in
FragmentStateManager.
Test: all existing Fragment tests pass
BUG: 139536619
Change-Id: I9abe87cf41580da011d3e8bd831d721bc0fe3ab2
M fragment/fragment/src/androidTest/java/androidx/fragment/app/FragmentContainerViewTest.kt
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentManager.java
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentStateManager.java
https://android-review.googlesource.com/1133600
https://goto.google.com/android-sha1/20f7c62349217f2b3f79a3c7548b2331235de42c
Branch: androidx-master-dev
commit 20f7c62349217f2b3f79a3c7548b2331235de42c
Author: Ian Lake <ilake@google.com>
Date: Fri Oct 04 10:42:27 2019
Move ACTIVITY_CREATED to FragmentStateManager
Moving to the ACTIVITY_CREATED state in
FragmentManager involves three actions:
- Creating the View
- Calling onActivityCreated()
- Calling onViewStateRestored
Move these as three separate methods in
FragmentStateManager.
Test: all existing Fragment tests pass
BUG: 139536619
Change-Id: I9abe87cf41580da011d3e8bd831d721bc0fe3ab2
M fragment/fragment/src/androidTest/java/androidx/fragment/app/FragmentContainerViewTest.kt
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentManager.java
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentStateManager.java
ni...@gmail.com <ni...@gmail.com> #14
Do we have any update on this issue, which can be shared to external reporter.
ra...@google.com <ra...@google.com> #15
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 5cc913017fb5cc881f2b7ea16e629c4c7cdc8c34
Author: Ian Lake <ilake@google.com>
Date: Fri Oct 11 10:24:19 2019
Move animateRemoveFragment out of FragmentManager
Make it a static method in FragmentAnim.
Test: all existing tests pass
BUG: 139536619
Change-Id: I16b9530151f483cdc4ddbdf79bba5cc9ed6e6ab1
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentAnim.java
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentManager.java
https://android-review.googlesource.com/1141236
https://goto.google.com/android-sha1/5cc913017fb5cc881f2b7ea16e629c4c7cdc8c34
Branch: androidx-master-dev
commit 5cc913017fb5cc881f2b7ea16e629c4c7cdc8c34
Author: Ian Lake <ilake@google.com>
Date: Fri Oct 11 10:24:19 2019
Move animateRemoveFragment out of FragmentManager
Make it a static method in FragmentAnim.
Test: all existing tests pass
BUG: 139536619
Change-Id: I16b9530151f483cdc4ddbdf79bba5cc9ed6e6ab1
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentAnim.java
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentManager.java
ra...@google.com <ra...@google.com> #16
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 3ca3fd13d021730e09e8dc1dc622ab753abcbd9d
Author: Ian Lake <ilake@google.com>
Date: Fri Oct 11 09:28:58 2019
Move loadAnimation out of FragmentManager
Test: all tests still pass
BUG: 139536619
Change-Id: I7e5549c825f69e38ab02a38e8067c594c908d154
A fragment/fragment/src/main/java/androidx/fragment/app/FragmentAnim.java
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentManager.java
https://android-review.googlesource.com/1141116
https://goto.google.com/android-sha1/3ca3fd13d021730e09e8dc1dc622ab753abcbd9d
Branch: androidx-master-dev
commit 3ca3fd13d021730e09e8dc1dc622ab753abcbd9d
Author: Ian Lake <ilake@google.com>
Date: Fri Oct 11 09:28:58 2019
Move loadAnimation out of FragmentManager
Test: all tests still pass
BUG: 139536619
Change-Id: I7e5549c825f69e38ab02a38e8067c594c908d154
A fragment/fragment/src/main/java/androidx/fragment/app/FragmentAnim.java
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentManager.java
li...@gmail.com <li...@gmail.com> #17
Do we have any update on this issue, which can be shared to external reporter.
ra...@google.com <ra...@google.com> #18
Project: platform/frameworks/support
Branch: androidx-master-dev
commit c06fb9f4d3334701bc1de8ee85c7a4e6149addcf
Author: Ian Lake <ilake@google.com>
Date: Mon Nov 11 10:32:31 2019
Move <fragment> tag state handling to FragmentStateManager
Move the logic for handling <fragment> tag added
Fragments that are not in the layout to
FragmentStateManager's computeMaxState() with the
other state logic.
Test: newly added FragmentLifecycleTest
BUG: 139536619
Change-Id: Ieaabdac16786418f89279a17bbe5661e12c11290
M fragment/fragment/src/androidTest/java/androidx/fragment/app/FragmentLifecycleTest.kt
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentManager.java
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentStateManager.java
https://android-review.googlesource.com/1164079
Branch: androidx-master-dev
commit c06fb9f4d3334701bc1de8ee85c7a4e6149addcf
Author: Ian Lake <ilake@google.com>
Date: Mon Nov 11 10:32:31 2019
Move <fragment> tag state handling to FragmentStateManager
Move the logic for handling <fragment> tag added
Fragments that are not in the layout to
FragmentStateManager's computeMaxState() with the
other state logic.
Test: newly added FragmentLifecycleTest
BUG: 139536619
Change-Id: Ieaabdac16786418f89279a17bbe5661e12c11290
M fragment/fragment/src/androidTest/java/androidx/fragment/app/FragmentLifecycleTest.kt
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentManager.java
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentStateManager.java
li...@gmail.com <li...@gmail.com> #19
Project: platform/frameworks/support
Branch: androidx-master-dev
commit ac963796fb52c1556be07a9dae91ee4034f20715
Author: Ian Lake <ilake@google.com>
Date: Mon Nov 11 11:03:15 2019
Move initState() call into FragmentStateManager
Instead of doing this work in moveToState(), it
can be moved into FragmentStateManager since it
only depends on the Fragment's internal state.
Test: all existing Fragment tests pass
BUG: 139536619
Change-Id: I100be37c69f3d9274db308a44bfb4c8df09a3062
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentManager.java
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentStateManager.java
https://android-review.googlesource.com/1164080
Branch: androidx-master-dev
commit ac963796fb52c1556be07a9dae91ee4034f20715
Author: Ian Lake <ilake@google.com>
Date: Mon Nov 11 11:03:15 2019
Move initState() call into FragmentStateManager
Instead of doing this work in moveToState(), it
can be moved into FragmentStateManager since it
only depends on the Fragment's internal state.
Test: all existing Fragment tests pass
BUG: 139536619
Change-Id: I100be37c69f3d9274db308a44bfb4c8df09a3062
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentManager.java
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentStateManager.java
ra...@google.com <ra...@google.com> #20
Project: platform/frameworks/support
Branch: androidx-master-dev
commit fd68f92de244735a6b6eccb73474d952d287b0d3
Author: Ian Lake <ilake@google.com>
Date: Tue Nov 19 16:01:35 2019
Move active and added fragments to FragmentStore
Instead of FragmentManager directly storing and
managing the set of active and added fragments, move
that functionality to a separately testable
FragmentStore object.
This will make it possible to have FragmentStateManager
access other FragmentStateManagers without directly
knowing about FragmentManager.
Test: new FragmentStore tests, all existing tests pass
BUG: 139536619
Change-Id: I69cefc8b2422f809e1498c5c9e4b09edd9026840
A fragment/fragment/src/androidTest/java/androidx/fragment/app/FragmentStoreTest.kt
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentManager.java
A fragment/fragment/src/main/java/androidx/fragment/app/FragmentStore.java
https://android-review.googlesource.com/1170093
Branch: androidx-master-dev
commit fd68f92de244735a6b6eccb73474d952d287b0d3
Author: Ian Lake <ilake@google.com>
Date: Tue Nov 19 16:01:35 2019
Move active and added fragments to FragmentStore
Instead of FragmentManager directly storing and
managing the set of active and added fragments, move
that functionality to a separately testable
FragmentStore object.
This will make it possible to have FragmentStateManager
access other FragmentStateManagers without directly
knowing about FragmentManager.
Test: new FragmentStore tests, all existing tests pass
BUG: 139536619
Change-Id: I69cefc8b2422f809e1498c5c9e4b09edd9026840
A fragment/fragment/src/androidTest/java/androidx/fragment/app/FragmentStoreTest.kt
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentManager.java
A fragment/fragment/src/main/java/androidx/fragment/app/FragmentStore.java
Description
I know 2.1.0-alpha02 is out but I cannot test it as I CANNOT reproduce this issue on both alpha01 and 02.
Proguard mappings
------------------
androidx.work.impl.constraints.trackers.NetworkStateTracker -> zl
androidx.work.impl.constraints.trackers.ConstraintTracker -> yl
androidx.work.impl.constraints.controllers.ConstraintController -> pl
androidx.work.impl.constraints.WorkConstraintsTracker -> ml
androidx.work.impl.background.systemalarm.WorkTimer -> gl
Crash report from user
-----------------
APP_VERSION_NAME=228 armeabi-v7a
ANDROID_VERSION=5.0
BRAND=samsung
PHONE_MODEL=SM-N9005
PRODUCT=hltexx
USER_APP_START_DATE=2019-05-22T09:58:13.756+01:00
USER_CRASH_DATE=2019-05-22T19:21:59.888+01:00
STACK_TRACE=java.lang.RuntimeException: Error receiving broadcast Intent { act=android.net.conn.CONNECTIVITY_CHANGE flg=0x4000010 (has extras) } in zl$a@5eda151
at android.app.LoadedApk$ReceiverDispatcher$Args.run(LoadedApk.java:933)
at android.os.Handler.handleCallback(Handler.java:739)
at android.os.Handler.dispatchMessage(Handler.java:95)
at android.os.Looper.loop(Looper.java:145)
at android.app.ActivityThread.main(ActivityThread.java:5938)
at java.lang.reflect.Method.invoke(Native Method)
at java.lang.reflect.Method.invoke(Method.java:372)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1400)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1195)
Caused by: java.util.concurrent.RejectedExecutionException: Task java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask@220005dc rejected from java.util.concurrent.ScheduledThreadPoolExecutor@ffebca8[Terminated, pool size = 0, active threads = 0, queued tasks = 0, completed tasks = 0]
at java.util.concurrent.ThreadPoolExecutor$AbortPolicy.rejectedExecution(ThreadPoolExecutor.java:2011)
at java.util.concurrent.ThreadPoolExecutor.reject(ThreadPoolExecutor.java:793)
at java.util.concurrent.ScheduledThreadPoolExecutor.delayedExecute(ScheduledThreadPoolExecutor.java:298)
at java.util.concurrent.ScheduledThreadPoolExecutor.schedule(ScheduledThreadPoolExecutor.java:503)
at java.util.concurrent.Executors$DelegatedScheduledExecutorService.schedule(Executors.java:644)
at gl.a(SourceFile:7)
at dl.b(SourceFile:5)
at ml.a(SourceFile:21)
at pl.b(SourceFile:3)
at pl.a(SourceFile:18)
at yl.a(SourceFile:17)
at zl$a.onReceive(SourceFile:4)
at android.app.LoadedApk$ReceiverDispatcher$Args.run(LoadedApk.java:923)
... 8 more
LOGCAT=--------- beginning of main
05-22 19:21:59.727 D/AndroidRuntime(11913): Shutting down VM
05-22 19:21:59.757 E/ACRA (11913): ACRA caught a RuntimeException for com.nll.asr
05-22 19:21:59.757 E/ACRA (11913): java.lang.RuntimeException: Error receiving broadcast Intent { act=android.net.conn.CONNECTIVITY_CHANGE flg=0x4000010 (has extras) } in zl$a@5eda151
05-22 19:21:59.757 E/ACRA (11913): at android.app.LoadedApk$ReceiverDispatcher$Args.run(LoadedApk.java:933)
05-22 19:21:59.757 E/ACRA (11913): at android.os.Handler.handleCallback(Handler.java:739)
05-22 19:21:59.757 E/ACRA (11913): at android.os.Handler.dispatchMessage(Handler.java:95)
05-22 19:21:59.757 E/ACRA (11913): at android.os.Looper.loop(Looper.java:145)
05-22 19:21:59.757 E/ACRA (11913): at android.app.ActivityThread.main(ActivityThread.java:5938)
05-22 19:21:59.757 E/ACRA (11913): at java.lang.reflect.Method.invoke(Native Method)
05-22 19:21:59.757 E/ACRA (11913): at java.lang.reflect.Method.invoke(Method.java:372)
05-22 19:21:59.757 E/ACRA (11913): at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1400)
05-22 19:21:59.757 E/ACRA (11913): at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1195)
05-22 19:21:59.757 E/ACRA (11913): Caused by: java.util.concurrent.RejectedExecutionException: Task java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask@220005dc rejected from java.util.concurrent.ScheduledThreadPoolExecutor@ffebca8[Terminated, pool size = 0, active threads = 0, queued tasks = 0, completed tasks = 0]
05-22 19:21:59.757 E/ACRA (11913): at java.util.concurrent.ThreadPoolExecutor$AbortPolicy.rejectedExecution(ThreadPoolExecutor.java:2011)
05-22 19:21:59.757 E/ACRA (11913): at java.util.concurrent.ThreadPoolExecutor.reject(ThreadPoolExecutor.java:793)
05-22 19:21:59.757 E/ACRA (11913): at java.util.concurrent.ScheduledThreadPoolExecutor.delayedExecute(ScheduledThreadPoolExecutor.java:298)
05-22 19:21:59.757 E/ACRA (11913): at java.util.concurrent.ScheduledThreadPoolExecutor.schedule(ScheduledThreadPoolExecutor.java:503)
05-22 19:21:59.757 E/ACRA (11913): at java.util.concurrent.Executors$DelegatedScheduledExecutorService.schedule(Executors.java:644)
05-22 19:21:59.757 E/ACRA (11913): at gl.a(SourceFile:7)
05-22 19:21:59.757 E/ACRA (11913): at dl.b(SourceFile:5)
05-22 19:21:59.757 E/ACRA (11913): at ml.a(SourceFile:21)
05-22 19:21:59.757 E/ACRA (11913): at pl.b(SourceFile:3)
05-22 19:21:59.757 E/ACRA (11913): at pl.a(SourceFile:18)
05-22 19:21:59.757 E/ACRA (11913): at yl.a(SourceFile:17)
05-22 19:21:59.757 E/ACRA (11913): at zl$a.onReceive(SourceFile:4)
05-22 19:21:59.757 E/ACRA (11913): at android.app.LoadedApk$ReceiverDispatcher$Args.run(LoadedApk.java:923)
05-22 19:21:59.757 E/ACRA (11913): ... 8 more
REPORT_ID=a476ba1d-9c82-4b7a-90cd-5d91e77df69d
IS_SILENT=false