IssueTracker

Project: platform/frameworks/support
Branch: androidx-master-dev

commit a071470cde57cf7eb6e39a67d331d716a0f8b842
Author: Ian Lake <ilake@google.com>
Date:   Wed Jan 15 14:01:37 2020

    Add SpecialEffectsController infrastructure
   
    "Special Effects" is the blanket term for
    Animation, Animator, framework Transition, and
    AndroidX Transition that Fragments currently support.
   
    Add the infrastructure around a SpecialEffectsController
    which would operate on the container (i.e., ViewGroup)
    level and coordinate all of the special effects.
   
    This will eventually allow us to track the
    postponed state at the container level.
   
    Currently all APIs are purposefully package private
    as they should not be used by external developers
    at this time.
   
    BUG: 147749580
    Test: new test suites pass
    Change-Id: I1e209bb4f55c21aa01afb49035d41f5b8d7d3eca

A       fragment/fragment/src/androidTest/java/androidx/fragment/app/DefaultSpecialEffectsControllerTest.kt
A       fragment/fragment/src/androidTest/java/androidx/fragment/app/SpecialEffectsControllerTest.kt
A       fragment/fragment/src/main/java/androidx/fragment/app/DefaultSpecialEffectsController.java
M       fragment/fragment/src/main/java/androidx/fragment/app/FragmentManager.java
A       fragment/fragment/src/main/java/androidx/fragment/app/SpecialEffectsController.java
A       fragment/fragment/src/main/java/androidx/fragment/app/SpecialEffectsControllerFactory.java
M       fragment/fragment/src/main/res/values/ids.xml
M       jetifier/jetifier/migration.config

https://android-review.googlesource.com/1209367

Project: platform/frameworks/support
Branch: androidx-master-dev

commit d990bffa6728272e139e1b5d58e764e9197b1adc
Author: Ian Lake <ilake@google.com>
Date:   Thu Jan 16 14:05:14 2020

    Find the appropriate SpecialEffectsControllerFactory
   
    Instead of requiring each call to
    getOrCreateController() require passing in the
    factory, use findFragmentManager() to find the
    containing FragmentManager and get the factory from
    it.
   
    Test: new test passes
    BUG: 147749580
    Change-Id: I44f747ba84feb2911a8d0811e40d1b46644429a5

M       fragment/fragment/src/androidTest/java/androidx/fragment/app/DefaultSpecialEffectsControllerTest.kt
M       fragment/fragment/src/main/java/androidx/fragment/app/SpecialEffectsController.java

https://android-review.googlesource.com/1210675

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 62e13263d9ee368a255cfb7db73eba061ca85f9c
Author: Ian Lake <ilake@google.com>
Date:   Fri Jan 17 13:09:12 2020

    Allow cancellation of special effects operations
   
    Pipe through a CancellationSignal to Operation
    so that a SpecialEffectsController can handle
    cancellation.
   
    Test: new test passes
    BUG: 147749580
    Change-Id: Iff9525a3d3e079a3b0b6818e43e6efdb16207a7a

M       fragment/fragment/src/androidTest/java/androidx/fragment/app/SpecialEffectsControllerTest.kt
M       fragment/fragment/src/main/java/androidx/fragment/app/FragmentStateManager.java
M       fragment/fragment/src/main/java/androidx/fragment/app/SpecialEffectsController.java

https://android-review.googlesource.com/1212445

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 9ea0884726565254629ff5c99ec919f56e0af1d9
Author: Ian Lake <ilake@google.com>
Date:   Fri Jan 17 11:09:14 2020

    Allow enqueuing special effects operations
   
    Build the initial infrastructure for enqueuing
    ADD and REMOVE operations to a SpecialEffectsController.
   
    This currently doesn't change any runtime behavior
    since DefaultSpecialEffectsController doesn't actually
    do anything and FragmentStateManager isn't used to
    move Fragments beyond CREATED with moveToExpectedState()
    in production code.
   
    Cancellation will be handled in a follow up CL.
   
    Test: new SpecialEffectsControllerTest tests pass
    BUG: 147749580
    Change-Id: I6a3009de80419fd878f2f838bf8e234c20b933ae

M       fragment/fragment/src/androidTest/java/androidx/fragment/app/SpecialEffectsControllerTest.kt
M       fragment/fragment/src/main/java/androidx/fragment/app/DefaultSpecialEffectsController.java
M       fragment/fragment/src/main/java/androidx/fragment/app/FragmentManager.java
M       fragment/fragment/src/main/java/androidx/fragment/app/FragmentStateManager.java
M       fragment/fragment/src/main/java/androidx/fragment/app/SpecialEffectsController.java

https://android-review.googlesource.com/1212444

Project: platform/frameworks/support
Branch: androidx-master-dev

commit d67221893efc073415220d4d3635f159e728b905
Author: Ian Lake <ilake@google.com>
Date:   Tue Jan 21 16:49:50 2020

    Add isAwaitingCompletion() API
   
    Build the infrastructure for allowing the
    FragmentStateManager to check whether a
    SpecialEffectsController is still awaiting
    completion of queued up / executing
    operations.
   
    Test: updated tests to call new API
    BUG: 147749580
    Change-Id: I6ebd563c505dc2e7b65ced4932316986c478a8cf

M       fragment/fragment/src/androidTest/java/androidx/fragment/app/SpecialEffectsControllerTest.kt
M       fragment/fragment/src/main/java/androidx/fragment/app/SpecialEffectsController.java

https://android-review.googlesource.com/1214213

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 974d9e0f0f1ca4108fa653302c239f9025dcd0d9
Author: Ian Lake <ilake@google.com>
Date:   Fri Feb 07 15:46:17 2020

    Add animations to DefaultSpecialEffectsController
   
    Build the base for running Animations / Animators
    in DefaultSpecialEffectsController, correctly only
    calling complete() when they finish.
   
    Test: visual inspection, comparing the code to the existing code
    BUG: 147749580
    Change-Id: Ib0eaeb34bfac7ca5e32b3feea9a2730388dcfd60

M       fragment/fragment/src/main/java/androidx/fragment/app/DefaultSpecialEffectsController.java
M       fragment/fragment/src/main/java/androidx/fragment/app/FragmentAnim.java

https://android-review.googlesource.com/1230307

Project: platform/frameworks/support
Branch: androidx-master-dev

commit d08aad2c5c5da3127969d4243e93ea8f0e8eccd3
Author: Ian Lake <ilake@google.com>
Date:   Tue Feb 11 15:36:30 2020

    Add initial infrastructure for transitions
   
    Allow DefaultSpecialEffectsController to
    start framework or AndroidX transitions.
   
    This just pipes the Fragment APIs through to
    beginDelayedTransition(). It does not currently
    handle shared element transitions.
   
    Test: visual inspection, comparing the code to the existing code
    BUG: 147749580
    Change-Id: Ieb9b9de9bafd59d4a6b9036df389cff263cd737e

M       fragment/fragment/src/main/java/androidx/fragment/app/DefaultSpecialEffectsController.java
M       fragment/fragment/src/main/java/androidx/fragment/app/FragmentTransition.java

https://android-review.googlesource.com/1232694

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 9c458049e7543914de98760102017b10dd04068e
Author: Ian Lake <ilake@google.com>
Date:   Tue Feb 18 12:57:03 2020

    Add cancelAllOperations() to SpecialEffectsController
   
    Provide an API for cancelling all operations
    (both pending and being executed) for a
    SpecialEffectsController.
   
    Test: new tests pass
    BUG: 147749580
    Change-Id: Id90f270869470bd44d73163a84343cf2cda3cd47

M       fragment/fragment/src/androidTest/java/androidx/fragment/app/SpecialEffectsControllerTest.kt
M       fragment/fragment/src/main/java/androidx/fragment/app/SpecialEffectsController.java

https://android-review.googlesource.com/1238926

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 4d3bac24c5a77c5ab5624795afa709b3f265bf74
Author: Ian Lake <ilake@google.com>
Date:   Tue Feb 25 15:47:06 2020

    Add infrastructure to fully switch to FragmentStateManager
   
    Add the initial logic to fully replace all usages of
    moveToState() with FragmentStateManager and its
    moveToExpectedState().
   
    Enabling this flag currently causes many tests to fail
    (due to work not being completed on b/147749580), but
    this infrastructure will allow us to confirm our fixes
    are actually applied while iterating through those
    outstanding issues.
   
    Test: tests all pass with USE_STATE_MANAGER = false
    BUG: 139536619
    Change-Id: I84340091ce1b0bcc3e26051e25a12d7b38b860c4

M       fragment/fragment/src/main/java/androidx/fragment/app/BackStackRecord.java
M       fragment/fragment/src/main/java/androidx/fragment/app/FragmentManager.java
M       fragment/fragment/src/main/java/androidx/fragment/app/FragmentStore.java

https://android-review.googlesource.com/1243715

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 56a9dc625ea8a9f35569549b4c2f24c1fbc7ff48
Author: Ian Lake <ilake@google.com>
Date:   Mon Mar 02 15:32:16 2020

    Add infrastructure for awaiting enter/exit effects
   
    Add new states for awaiting enter effects
    (which block going to RESUMED) and awaiting
    exit effects (which block going to CREATED).
   
    Changed isAwaitingCompletion() to
    getAwaitingCompletionType() to know what
    type of Operation is uncompleted.
   
    Test: existing tests pass
    BUG: 147749580
    Change-Id: Ifc28f62dfaadbcd222e3f2d8cf4a21e7eacf6091

M       fragment/fragment/src/androidTest/java/androidx/fragment/app/SpecialEffectsControllerTest.kt
M       fragment/fragment/src/main/java/androidx/fragment/app/Fragment.java
M       fragment/fragment/src/main/java/androidx/fragment/app/FragmentStateManager.java
M       fragment/fragment/src/main/java/androidx/fragment/app/SpecialEffectsController.java

https://android-review.googlesource.com/1248227

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 5a7e88f9d605f0a735d922e73463d1c603683e22
Author: Ian Lake <ilake@google.com>
Date:   Thu Mar 05 16:02:57 2020

    Don't call postpone when using FragmentStateManager
   
    Avoid calling through to postponePostponableTransactions
    at all when USE_STATE_MANAGER is true as it will
    be responsible for taking care of postponement in
    the future.
   
    Tightened up the state management in FragmentStateManager
    to avoid crashes in the test suite due to bad
    transitions between states.
   
    Test: all tests pass with USE_STATE_MANAGER=false
    Test: test suite doesn't crash with USE_STATE_MANAGER=true
    BUG: 147749580
    Change-Id: I6ff2c3fbe325c82ea5e33dd5c0cb07c908bbd613

M       fragment/fragment/src/main/java/androidx/fragment/app/Fragment.java
M       fragment/fragment/src/main/java/androidx/fragment/app/FragmentManager.java
M       fragment/fragment/src/main/java/androidx/fragment/app/FragmentStateManager.java

https://android-review.googlesource.com/1252296

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 20090a3bd0d8392a165f56b3a9da4efd1a86875c
Author: Ian Lake <ilake@google.com>
Date:   Mon Mar 09 15:04:48 2020

    Start transitions before starting animations
   
    Ensure that transitions start before animations
    so that they properly capture the current state.
   
    Test: existing tests pass
    BUG: 147749580
    Change-Id: Icc5bfae9b60554225307dadb278d7c2700527dfd

M       fragment/fragment/src/main/java/androidx/fragment/app/DefaultSpecialEffectsController.java

https://android-review.googlesource.com/1253639

Project: platform/frameworks/support
Branch: androidx-master-dev

commit ea897029344b96b61a86de8a0607d307c281ab3d
Author: Ian Lake <ilake@google.com>
Date:   Mon Mar 09 16:44:41 2020

    Correctly add/remove view using SpecialEffectsController
   
    Ensure that DefaultSpecialEffectsController
    correctly applies shows the View or removes
    the View based on the appropriate
    operation type.
   
    Test: existing tests pass
    Test: more tests pass when using USE_STATE_MANAGER
    BUG: 147749580
    Change-Id: I5dc190adc85a357a74862e25567769575dd135ef

M       fragment/fragment/src/main/java/androidx/fragment/app/DefaultSpecialEffectsController.java
M       fragment/fragment/src/main/java/androidx/fragment/app/FragmentStateManager.java

https://android-review.googlesource.com/1253010

Adding on to this, I get a `Trying to set a replacement startPostponedEnterTransition on {fragment}` when performing the following behavior:

Quickly open two (new) fragment instances of the same fragment, and exit/open them repeatedly. For example, via a double click, or simply calling a method that creates a fragment transaction to show the fragment twice. After opening/closing the said fragment several times, the exception will occur. I believe this has to do with the aforementioned issues with the FragmentManager getting into a unpredictable state.
Some extra things to be noted:
- I use `setReorderingAllowed(true)` and `replace` in the Fragment transaction
- I call `postponeEnterTransition()` in `onCreate` of the Fragment
- I call `startPostponedEnterTransition()` after `onViewCreated`, in the Observer of a LiveData. The LiveData's `setValue` is called before the fragment transaction, so it should be called as soon as the livedata observer is attached and observing.
- The Fragment that is being instantiated and opened twice is opened from another Fragment that follows the same steps, such that the stack looks like so: Fragment A is added, the user clicks on a button to open Fragment B, and two new instances of Fragment B are added to the stack.

Some notable behavior that occurs: After opening Fragment B, Fragment A and two instances of Fragment B are on the stack. Upon pressing the "back" button, all three fragments are "popped" from the stack. When setting `setReorderingAllowed(false)`, only one of the instances of Fragment B are popped from the stack, which is expected.

If there are any more details or clarity I can provide, let me know, as this is a bit of a strange/obscure bug.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 385938be24095f3b32c9687c9d2468c60bdb84fb
Author: Ian Lake <ilake@google.com>
Date:   Wed Apr 08 15:34:33 2020

    Don't start special effects when destroyed
   
    When the FragmentManager is destroyed, we
    shouldn't kick off any new special effects.
   
    Test: failing tests use USE_STATE_MANAGER now pass
    BUG: 147749580
    Change-Id: Ib0ce087b81adaf87bd5e76d92a90785f6aa673a7

M       fragment/fragment/src/main/java/androidx/fragment/app/FragmentStateManager.java

https://android-review.googlesource.com/1282597

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 0650e2e4b6e7e428970acd4fa31fe7fb44cd1b8e
Author: Ian Lake <ilake@google.com>
Date:   Wed Apr 08 16:08:12 2020

    Call saveViewState() in moveToExpectedState()
   
    Ensure that saveViewState() is called before
    the View's special effects start.
   
    Test: less tests fail with USE_STATE_MANAGER
    BUG: 147749580
    Change-Id: I9a2b683396e1fb2efc032a4eda689e63fcf9e038

M       fragment/fragment/src/main/java/androidx/fragment/app/FragmentStateManager.java

https://android-review.googlesource.com/1282614

Project: platform/frameworks/support
Branch: androidx-master-dev

commit d5d98e981e20b76b09a3da4635ad3c5bfd5fdedb
Author: Ian Lake <ilake@google.com>
Date:   Fri Apr 10 13:47:39 2020

    Make FragmentManager state changes execute special effects
   
    Each change to the FragmentManager's state should
    result in any pending special effects operations
    being executed.
   
    This avoids fragments getting stuck in
    AWAITING_ENTER_EFFECTS after a configuration change.
   
    Test: inflatedFragmentNotInLayout now passes with USE_STATE_MANAGER
    BUG: 147749580
    Change-Id: I3c82373dd5fa0a4447e41a0566b5c45c959150f8

M       fragment/fragment/src/main/java/androidx/fragment/app/FragmentManager.java

https://android-review.googlesource.com/1284457

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 0c3d420cc4bbb8c3c8b28ec2570a3a1d4a47e042
Author: Ian Lake <ilake@google.com>
Date:   Wed Apr 15 09:52:10 2020

    Move findFragmentUnder() into FragmentStateManager
   
    Instead of moving the Fragment after the fact to
    the right index in its container after the fact,
    place the fragment at the right index when it is
    added in the first place.
   
    This fixes fragment ordering tests when using
    USE_STATE_MANAGER.
   
    Test: existing view ordering tests still pass
    BUG: 147749580
    Change-Id: I3c70ba71e8caf38f543b1601b564c1bf28d76dec

M       fragment/fragment/src/androidTest/java/androidx/fragment/app/FragmentTest.kt
M       fragment/fragment/src/main/java/androidx/fragment/app/FragmentManager.java
M       fragment/fragment/src/main/java/androidx/fragment/app/FragmentStateManager.java

https://android-review.googlesource.com/1284535

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 0f294af6a0a98a55f1e6797695ccae31c62f26a6
Author: Ian Lake <ilake@google.com>
Date:   Thu Apr 16 15:52:01 2020

    Use under and over fragments for relative positioning
   
    The index that a newly added fragment's view should
    be added to its container should be relative to
    *all* other fragments in that container. This means
    it should be above any fragments that are before it
    in mAdded order and below any fragments that are
    after it in mAdded order.
   
    If no other fragment exists in the container, the
    fragment's view should be added at the end of the
    container (i.e., an index of -1) so that the fragment
    is after any non-fragment views in the same container.
   
    Test: updated FragmentStoreTest tests
    BUG: 147749580
    BUG: 154241885
    Change-Id: I51f5e4c5d30d2ead62c27b2d44c68d704f31713e

M       fragment/fragment/src/androidTest/java/androidx/fragment/app/FragmentStoreTest.kt
M       fragment/fragment/src/main/java/androidx/fragment/app/FragmentStateManager.java
M       fragment/fragment/src/main/java/androidx/fragment/app/FragmentStore.java

https://android-review.googlesource.com/1288351

Project: platform/frameworks/support
Branch: androidx-master-dev

commit f6bc21adad203544e66b8e23b7a181598172e7cb
Author: Ian Lake <ilake@google.com>
Date:   Fri Apr 17 15:52:18 2020

    Fix Animation listeners with USE_STATE_MANAGER
   
    Since an Animation can only have a single
    listener, we need to wrap enter animations
    in an AnimationSet to ensure that we allow any
    animation listener set on the Animation passed to
    DefaultSpecialEffectsController still fires.
   
    Test: FragmentAnimationTest#animationListenersAreCalled() passes
    BUG: 147749580
    Change-Id: Ibca0bd00b7408bf9a06b4831a782384437f0630d

M       fragment/fragment/src/main/java/androidx/fragment/app/DefaultSpecialEffectsController.java
M       fragment/fragment/src/main/java/androidx/fragment/app/FragmentAnim.java

https://android-review.googlesource.com/1289556

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 263faa13f7a6f4a4a33bb404225ab776895a6350
Author: Ian Lake <ilake@google.com>
Date:   Wed Apr 29 15:25:01 2020

    Determine direction based on FragmentTransactions
   
    Rather than have DefaultSpecialEffectsController
    try to determine whether the set of Operations
    should be considered a pop or not, pass that information
    through from FragmentManager which determines
    direction by looking at the the FragmentTransactions
    themselves.
   
    By using only the direction of the last
    FragmentTransaction, we can ensure that all operations
    being executed are going in the same direction - this is
    important when using non symmetric animations (such as
    sliding to the left vs right).
   
    Test: no regressions when running tests with USE_STATE_MANAGER
    BUG: 147749580
    Change-Id: I458ad8e2e7f728881b76fb2bcb25c4bdecf276d4

M       fragment/fragment/src/androidTest/java/androidx/fragment/app/SpecialEffectsControllerTest.kt
M       fragment/fragment/src/main/java/androidx/fragment/app/DefaultSpecialEffectsController.java
M       fragment/fragment/src/main/java/androidx/fragment/app/FragmentManager.java
M       fragment/fragment/src/main/java/androidx/fragment/app/SpecialEffectsController.java

https://android-review.googlesource.com/1298248

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 44240d845252dea7a7b4a2b2a1cddea3d93860e4
Author: Ian Lake <ilake@google.com>
Date:   Thu May 07 14:10:50 2020

    Explicitly target transitioning Views
   
    Ensure that each Transition explicitly targets
    the Views within the associated Fragment.
   
    Test: many more tests pass with USE_STATE_MANAGER
    BUG: 147749580
    Change-Id: Ie3a4fee66d5490abc6234afe79f84b337a66b2b7

M       fragment/fragment/src/main/java/androidx/fragment/app/DefaultSpecialEffectsController.java
M       fragment/fragment/src/main/java/androidx/fragment/app/FragmentTransition.java

https://android-review.googlesource.com/1306174

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 38d6b0aea86ce6884740849b841a3604a99ad6fe
Author: Ian Lake <ilake@google.com>
Date:   Tue May 12 14:59:47 2020

    Early return from startTransitions
   
    When there is no Transition implementation
    that can handle all transitions, we should
    early return rather than have a giant else
    statement.
   
    Test: ./gradlew bOS
    BUG: 147749580
    Change-Id: I92aa1a5b020c81847e2cad831494b2a206294866

M       fragment/fragment/src/main/java/androidx/fragment/app/DefaultSpecialEffectsController.java

https://android-review.googlesource.com/1309776

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 96f880a054ca70663071677b85b37b6eeba48ea8
Author: Ian Lake <ilake@google.com>
Date:   Tue May 19 12:28:41 2020

    Add initial support for shared element transitions
   
    Allow DefaultSpecialEffectsController to determine
    what shared element transition to run and build the
    initial logic to determine what views should be
    excluded from the regular transition and instead
    added to the shared element transition.
   
    Test: no regressions when USE_STATE_MANAGER = true
    BUG: 147749580
    Change-Id: I728194fc964b850ed9cf9f2b798dc2acdb763429

M       fragment/fragment/src/main/java/androidx/fragment/app/BackStackRecord.java
M       fragment/fragment/src/main/java/androidx/fragment/app/DefaultSpecialEffectsController.java
M       fragment/fragment/src/main/java/androidx/fragment/app/Fragment.java

https://android-review.googlesource.com/1315090

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 28878f23fab386fdd299338c1a1cdda87927f199
Author: Ian Lake <ilake@google.com>
Date:   Wed May 20 15:41:31 2020

    Compute epicenter of transitions
   
    Use the first shared element from
    the firstOut fragment and the lastIn
    fragment to drive the epicenters of
    the exiting+shared element and entering
    transitions, respectively.
   
    Test: more tests pass epicenter tests
    BUG: 147749580
    Change-Id: I2697c3af1aa3dd8551a84ef1414bde02dbcd22fb

M       fragment/fragment/src/main/java/androidx/fragment/app/DefaultSpecialEffectsController.java

https://android-review.googlesource.com/1315915