Call WorkManagerImpl.getInstance in background.systemjob.SystemJobService.onCreate caused java.lang.IllegalStateException [135858602]

Fixed

Bug

Status Update

No update yet.

Description

ya...@gmail.com

created issue #1

Jun 24, 2019 04:12AM

Component used: androidx.work:work-runtime:2.1.0-beta01
Version used: 2.1.0-beta01
Devices/Android versions reproduced on: Android 7.1, Android 8.1, Android 9 / W_P200 (W_P200), Xperia Z5 Compact (E5823), ZenFone, Xperia Z5 Compact, V30, FP2, ...

I'm not able to reproduce but I can see a significant number of crash at production live

java.lang.RuntimeException:
at android.app.ActivityThread.handleCreateService (ActivityThread.java:3265)
at android.app.ActivityThread.-wrap5 (ActivityThread.java)
at android.app.ActivityThread$H.handleMessage (ActivityThread.java:1598)
at android.os.Handler.dispatchMessage (Handler.java:102)
at android.os.Looper.loop (Looper.java:241)
at android.app.ActivityThread.main (ActivityThread.java:6274)
at java.lang.reflect.Method.invoke (Method.java)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run (ZygoteInit.java:886)
at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:776)
Caused by: java.lang.IllegalStateException:
at androidx.work.impl.WorkManagerImpl.getInstance (WorkManagerImpl.java:142)
at androidx.work.impl.background.systemjob.SystemJobService.onCreate (SystemJobService.java:53)
at android.app.ActivityThread.handleCreateService (ActivityThread.java:3255)
at android.app.ActivityThread.-wrap5 (ActivityThread.java)
at android.app.ActivityThread$H.handleMessage (ActivityThread.java:1598)
at android.os.Handler.dispatchMessage (Handler.java:102)
at android.os.Looper.loop (Looper.java:241)
at android.app.ActivityThread.main (ActivityThread.java:6274)
at java.lang.reflect.Method.invoke (Method.java)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run (ZygoteInit.java:886)
at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:776)

My detailed finding is as follow. So far, I have no idea how it happens. I cross post at

https://stackoverflow.com/questions/56729702/call-workmanagerimpl-getinstance-in-background-systemjob-systemjobservice-oncrea (Easier to read due to better formatting)

We are using the following WorkManager library

def work_version = "2.1.0-beta01"
implementation "androidx.work:work-runtime:$work_version"
Our Application class is being modified as follow so that it will work well with WorkManager

public class WeNoteApplication extends MultiDexApplication implements DefaultLifecycleObserver, Configuration.Provider {

private static WeNoteApplication me;

@Override
public void onCreate() {
super.onCreate();

me = this;

...
}

public static WeNoteApplication instance() {
return me;
}

@NonNull
@Override
public Configuration getWorkManagerConfiguration() {
return new Configuration.Builder()
.build();
}
}
We do not add any WorkManager related code in AndroidManifest.xml. We solely rely on Default initialization

This is how we construct WorkManager

public static WorkManager getWorkManager() {
WeNoteApplication weNoteApplication = WeNoteApplication.instance();
return WorkManager.getInstance(weNoteApplication);
}
The above function is called in 4 different places

Activity
Fragment
BroadcastReceiver
IntentService
Still, we receive the following crash log in production. It happens in Android 7.1, Android 8.1, Android 9 (so far)

java.lang.RuntimeException:
at android.app.ActivityThread.handleCreateService (ActivityThread.java:3265)
at android.app.ActivityThread.-wrap5 (ActivityThread.java)
at android.app.ActivityThread$H.handleMessage (ActivityThread.java:1598)
at android.os.Handler.dispatchMessage (Handler.java:102)
at android.os.Looper.loop (Looper.java:241)
at android.app.ActivityThread.main (ActivityThread.java:6274)
at java.lang.reflect.Method.invoke (Method.java)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run (ZygoteInit.java:886)
at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:776)
Caused by: java.lang.IllegalStateException:
at androidx.work.impl.WorkManagerImpl.getInstance (WorkManagerImpl.java:142)
at androidx.work.impl.background.systemjob.SystemJobService.onCreate (SystemJobService.java:53)
at android.app.ActivityThread.handleCreateService (ActivityThread.java:3255)
at android.app.ActivityThread.-wrap5 (ActivityThread.java)
at android.app.ActivityThread$H.handleMessage (ActivityThread.java:1598)
at android.os.Handler.dispatchMessage (Handler.java:102)
at android.os.Looper.loop (Looper.java:241)
at android.app.ActivityThread.main (ActivityThread.java:6274)
at java.lang.reflect.Method.invoke (Method.java)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run (ZygoteInit.java:886)
at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:776)
As you can see in the crash, the crash origins from WorkManager internally, and not from our app.

By looking at

https://android.googlesource.com/platform/frameworks/support/+/androidx-master-dev/work/workmanager/src/main/java/androidx/work/impl/WorkManagerImpl.java#142

WorkManagerImpl
/**
* Retrieves the singleton instance of {@link WorkManagerImpl}.
*
* @param context A context for on-demand initialization.
* @return The singleton instance of {@link WorkManagerImpl}
* @hide
*/
@RestrictTo(RestrictTo.Scope.LIBRARY_GROUP)
public static @NonNull WorkManagerImpl getInstance(@NonNull Context context) {
synchronized (sLock) {
WorkManagerImpl instance = getInstance();
if (instance == null) {
Context appContext = context.getApplicationContext();
if (appContext instanceof Configuration.Provider) {
initialize(
appContext,
((Configuration.Provider) appContext).getWorkManagerConfiguration());
instance = getInstance(appContext);
} else {
throw new IllegalStateException("WorkManager is not initialized properly. You "
+ "have explicitly disabled WorkManagerInitializer in your manifest, "
+ "have not manually called WorkManager#initialize at this point, and "
+ "your Application does not implement Configuration.Provider.");
}
There are 2 possibilities of the crash

appContext is null. (How can it be null?)
appContext does not implement Configuration.Provider (But we already implement in our WeNoteApplication?)
To figure out how context is being passed to WorkManagerImpl from SystemJobService, we look at the code of androidx.work.impl.background.systemjob.SystemJobService.onCreate

SystemJobService
@RestrictTo(RestrictTo.Scope.LIBRARY_GROUP)
@RequiresApi(WorkManagerImpl.MIN_JOB_SCHEDULER_API_LEVEL)
public class SystemJobService extends JobService implements ExecutionListener {
private static final String TAG = Logger.tagWithPrefix("SystemJobService");
private WorkManagerImpl mWorkManagerImpl;
private final Map<String, JobParameters> mJobParameters = new HashMap<>();
@Override
public void onCreate() {
super.onCreate();
mWorkManagerImpl = WorkManagerImpl.getInstance(getApplicationContext());
Look fine at first sight. But, why WorkManagerImpl cannot obtain Configuration.Provider although I already implement Configuration.Provider in my Application? Is it because I'm using MultiDexApplication?

Comments

ya...@gmail.com <ya...@gmail.com> #2Jun 24, 2019 04:52AM

Bringing setMaxSchedulerLimit to say 49 doesn't help. Same error.

su...@google.com <su...@google.com> Jun 24, 2019 04:46PM

Assigned to su...@google.com.

ap...@google.com <ap...@google.com> #3Jun 24, 2019 06:48PM

Marked as fixed.

If you are using work-firebase then you should not be using JobScheduler directly. Can you please send us the full bug report so we can investigate ?

ya...@gmail.com <ya...@gmail.com> #4Jun 24, 2019 06:56PM

java.lang.IllegalStateException: Apps may not schedule more than 100 distinct jobs
at android.os.Parcel.readException(Parcel.java:1692)
at android.os.Parcel.readException(Parcel.java:1637)
at android.app.job.IJobScheduler$Stub$Proxy.schedule(IJobScheduler.java:158)
at android.app.JobSchedulerImpl.schedule(JobSchedulerImpl.java:42)
at androidx.work.impl.background.systemjob.SystemJobScheduler.scheduleInternal(SystemJobScheduler.java:126)
at androidx.work.impl.background.systemjob.SystemJobScheduler.schedule(SystemJobScheduler.java:95)
at androidx.work.impl.Schedulers.scheduleInternal(Schedulers.java:104)
at androidx.work.impl.Schedulers.schedule(Schedulers.java:73)
at androidx.work.impl.WorkerWrapper.setSucceededAndNotify(WorkerWrapper.java:393)
at androidx.work.impl.WorkerWrapper.handleResult(WorkerWrapper.java:255)
at androidx.work.impl.WorkerWrapper.run(WorkerWrapper.java:181)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1133)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:607)
at java.lang.Thread.run(Thread.java:761)

su...@google.com <su...@google.com> #5Jun 24, 2019 07:52PM

What do you mean I shouldn't use JobScheduler directly? Isn't work-firebase is just for <21 devices, otherwise JobScheduler always used?

ya...@gmail.com <ya...@gmail.com> #6Jun 24, 2019 08:16PM

I think i was confused by your previous comment. You are right, we only use work-firebase for API < 23.
JobScheduler is used for API >= 23.

This issue should have been resolved in `alpha03` and `alpha04` (we addressed different parts of the problem). If you can reproduce this on a device, then can you do:

1. adb shell dumpsys jobscheduler for your app.
2. Reboot your device.
3. After the reboot, can you re-run adb shell dumpsys jobscheduler ?

I want to check if you see any differences in the jobs created before and after the reboot.

Thanks for your patience.

su...@google.com <su...@google.com> #7Jun 24, 2019 08:21PM

Actually for step 2, the easier thing to do is to force stop your app. You don't need to fo a full reboot.

ya...@gmail.com <ya...@gmail.com> #8Jun 24, 2019 08:48PM

I don't have to to rummage through traces. Here's code snippet that sends app into a crash loop.

https://pastebin.com/NcTAnwjZ

Android 9.png

122 KB

View

Download

su...@google.com <su...@google.com> #9Jun 24, 2019 09:10PM

I tried to reproduce this on alpha04. However, I cannot reproduce your issue.

For reference, this is what my activity looks like:

class MainActivity : AppCompatActivity() {
override fun onCreate(savedInstanceState: Bundle?) {
super.onCreate(savedInstanceState)
setContentView(R.layout.activity_main)
findViewById<Button>(R.id.scheduler_limits_testcase1).setOnClickListener {
for (i in 1..100) {
val a1 = newWorkRequest("--- A1 ---")
val b1 = newWorkRequest("--- B1 ---")
val b2 = newWorkRequest("--- B2 ---")
val c1 = newWorkRequest("--- C1 ---")
WorkManager.getInstance()!!
.beginWith(a1).then(b1).enqueue()
WorkManager.getInstance()!!
.beginWith(a1).then(b2).enqueue()
WorkManager.getInstance()!!
.beginWith(b1, b2).then(c1).enqueue()
}

}
}

companion object {
private fun newWorkRequest(message: String): OneTimeWorkRequest {
val data = mapOf(TestWorker.KEY_MESSAGE to message).toWorkData()
return OneTimeWorkRequestBuilder<TestWorker>()
.setInputData(data)
.build()
}
}
}

This is what my Worker looks like:

class TestWorker : Worker() {
companion object {
private const val TAG = "TestWorker"
private const val MESSAGE_DEFAULT = "Default"
const val KEY_MESSAGE = "KEY_MESSAGE"
}

override fun doWork(): Result {
val message = inputData.getString(KEY_MESSAGE, MESSAGE_DEFAULT)
val random = Random()
val time = 500L + random.nextInt(300)
Log.d(TAG, "Before. $message")
Thread.sleep(time)
Log.d(TAG, "After. $message")
return Result.SUCCESS
}
}

ya...@gmail.com <ya...@gmail.com> #10Jun 26, 2019 03:24AM

Do you have another part of your codebase that is scheduling jobs with JobScheduler?

su...@google.com <su...@google.com> #11Jun 26, 2019 04:05PM

We have 1 job that schedules once on app start, that's it.

zh...@kuaishou.com <zh...@kuaishou.com> #12Mar 19, 2020 11:25AM

I created a sample app.

For some reason it rarely crashes on AVD Emulator(Api 27), but 100% crashes on Genymotion Api 26 and my Xiaomi Redmi 7.1.2

You can try both Activities.

si...@gmail.com <si...@gmail.com> #13Aug 1, 2020 01:36PM

Hi, I've tried numerous times and have been unable to get your example to exhibit this problem. Could you please update to alpha05 and reproduce it? If you can reliably reproduce this issue, could you please do so with verbose logging enabled in your Configuration object (introduced in alpha05) and send us a bugreport?

Message last modified on Aug 1, 2020 01:37PM

mr...@gmail.com <mr...@gmail.com> #14Aug 16, 2020 03:05PM

I will some time later when I have time

Message last modified on Aug 16, 2020 03:05PM

bh...@gmail.com <bh...@gmail.com> #15Sep 25, 2020 10:38AM

Alpha 05, VERBOSE log level. Running the MainActivity in previous app.

pt...@gmail.com <pt...@gmail.com> #16Dec 9, 2020 01:02PM

Hmm, there is a possibility based on your stacktrace that you are running into

b/111801342

; something about these particular devices/emulators is leading to the issue manifesting like this. This is fixed in alpha06 (which will be released later today). Please update later today to check.

ah...@safarifoneict.com <ah...@safarifoneict.com> #17Apr 28, 2021 10:57AM

Comment has been deleted.

Message last modified on May 21, 2021 06:02AM

ds...@servicetitan.com <ds...@servicetitan.com> #18Oct 6, 2021 04:27PM

↑ This is Genymotion not Xiaomi log

Message last modified on Oct 8, 2021 08:11PM

li...@gmail.com <li...@gmail.com> #19Dec 18, 2021 05:17AM

I tried to reproduce this on a Genymotion emulator as well (on alpha04 and alpha06) on API 26. I cannot seem to.
I am marking this as not reproducible.

[Deleted User] <[Deleted User]> #20Jan 26, 2022 10:00AM

You tried to reproduce it on my example above?

d4...@gmail.com <d4...@gmail.com> #21Jul 8, 2022 05:15PM

How can you not reproduce it when I linked you the code to do so?

ps...@pinterest.com <ps...@pinterest.com> #22Feb 28, 2023 07:00PM

Same issue for me, "java.lang.IllegalStateException: Apps may not schedule more than 100 distinct jobs", on Android 8.0.0 (HTC U11).

Just for my understanding, should we be able to enqueue more than ~100 WorkRequest ?

ra...@google.com <ra...@google.com> #23Feb 28, 2023 07:33PM

Yes, you should. We found some edge cases where it's possible to schedule more work than allowable by the system and we're working on a fix. Thanks!

ka...@walmart.com <ka...@walmart.com> #24May 19, 2023 05:54PM

Fixed in

https://android-review.googlesource.com/c/platform/frameworks/support/+/726647.

Message last modified on May 19, 2023 05:56PM

yk...@gmail.com <yk...@gmail.com> #25May 23, 2023 05:22AM

A fix should be available in alpha07.

a....@gmail.com <a....@gmail.com> #26Aug 17, 2023 04:21PM

I still got the 100 job crash once using alpha-07