NPE on SystemJobScheduler.getPendingJobIds [138364061]

Fixed

Bug

Status Update

No update yet.

Description

ru...@gmail.com

created issue #1

Jul 25, 2019 06:13PM

Component used: WorkManager
Version used: 2.1.0
Devices/Android versions reproduced on: 6.0

We're getting this crash on multiple devices:

Fatal Exception: java.lang.NullPointerException: Attempt to invoke virtual method 'boolean android.util.ArrayMap.containsKey(java.lang.Object)' on a null object reference
at android.os.BaseBundle.containsKey + 277(BaseBundle.java:277)
at androidx.work.impl.background.systemjob.SystemJobScheduler.getPendingJobIds + 331(SystemJobScheduler.java:331)
at androidx.work.impl.background.systemjob.SystemJobScheduler.schedule + 138(SystemJobScheduler.java:138)
at androidx.work.impl.Schedulers.schedule + 93(Schedulers.java:93)
at androidx.work.impl.WorkManagerImpl.rescheduleEligibleWork + 587(WorkManagerImpl.java:587)
at androidx.work.impl.utils.ForceStopRunnable.run + 82(ForceStopRunnable.java:82)
at androidx.work.impl.utils.SerialExecutor$Task.run + 75(SerialExecutor.java:75)
at java.util.concurrent.ThreadPoolExecutor.runWorker + 1113(ThreadPoolExecutor.java:1113)
at java.util.concurrent.ThreadPoolExecutor$Worker.run + 588(ThreadPoolExecutor.java:588)
at java.lang.Thread.run + 833(Thread.java:833)

For some reason, the mMap in BaseBundle is null and getPendingJobIds doesn't catch that:

for (JobInfo jobInfo : jobs) {
PersistableBundle extras = jobInfo.getExtras();
// The map inside extras can be null, so extras.containsKey can cause a NPE
if (extras != null && extras.containsKey(EXTRA_WORK_SPEC_ID)) {
if (workSpecId.equals(extras.getString(EXTRA_WORK_SPEC_ID))) {
jobIds.add(jobInfo.getId());
}
}
}

Comments

su...@google.com <su...@google.com> #2Jul 25, 2019 07:29PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 1e5efa0794e826bc1b3b153796ed5659fb97fca2
Author: Ian Lake <ilake@google.com>
Date: Fri Feb 08 10:23:54 2019

Prefer exact matching deep links

Instead of only taking into account the
number of matching arguments for deep link
matching, always prefer exact matches.

Test: updated tests
BUG: 123969518
Change-Id: Ibd8ab5b6ba251991fa994ebd297bcb9ffb5851bd

M navigation/common/src/androidTest/java/androidx/navigation/NavDestinationAndroidTest.kt
M navigation/common/src/androidTest/java/androidx/navigation/NavGraphAndroidTest.kt
M navigation/common/src/main/java/androidx/navigation/NavDeepLink.java
M navigation/common/src/main/java/androidx/navigation/NavDestination.java

https://android-review.googlesource.com/898367

https://goto.google.com/android-sha1/1e5efa0794e826bc1b3b153796ed5659fb97fca2

ru...@gmail.com <ru...@gmail.com> #3Jul 25, 2019 07:37PM

This is fixed internally and will be available in Navigation 1.0.0-beta02 - we'll always prefer an exact deep match link (where exact means your deep link does not contain any .* or {param} tags)

an...@google.com <an...@google.com> #4Jul 26, 2019 11:32PM

The following changes were cherrypicked through Coastguard (

https://android-build.googleplex.com/coastguard/)
Release Track: (

https://android-build.googleplex.com/coastguard/dashboard/6206758647365632/#/cherrypickHistory/all)
Created: 2019-07-26 23:31:17.300138+00:00
Changes: aosp/1092375

ru...@gmail.com <ru...@gmail.com> #5Jul 27, 2019 01:14AM

This also seems to happen in SystemJobService.onStartJob. Should I create a new bug?

Caused by java.lang.NullPointerException: Attempt to invoke virtual method 'java.lang.Object android.util.ArrayMap.get(java.lang.Object)' on a null object reference
at android.os.BaseBundle.getString + 928(BaseBundle.java:928)
at androidx.work.impl.background.systemjob.SystemJobService.onStartJob + 104(SystemJobService.java:104)
at android.app.job.JobService$JobHandler.handleMessage + 126(JobService.java:126)
at android.os.Handler.dispatchMessage + 102(Handler.java:102)
at android.os.Looper.loop + 150(Looper.java:150)
at android.app.ActivityThread.main + 5621(ActivityThread.java:5621)
at java.lang.reflect.Method.invoke(Method.java)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run + 794(ZygoteInit.java:794)
at com.android.internal.os.ZygoteInit.main + 684(ZygoteInit.java:684)

ra...@google.com <ra...@google.com> #6Jul 27, 2019 06:30AM

Yes, please do. I can take a look.

ru...@gmail.com <ru...@gmail.com> #7Jul 27, 2019 10:03AM

It's here now:

https://issuetracker.google.com/issues/138441699

Thank you for fixing this so quickly.

su...@google.com <su...@google.com> Jul 29, 2019 09:55PM

Marked as fixed, reassigned to su...@google.com.