[ViewPager2] Behavior of horizontal scroll is wrong when using ViewPager2 in CoordinatorLayout [138668210]

Fixed

Bug

Status Update

No update yet.

Description

dx...@gmail.com

created issue #1

Jul 31, 2019 03:23AM

* ViewPager2 in CoordinatorLayout.
* Using NestedScrollView with Fragment in item of ViewPager2.
* This is set in NestedScrollView: `app: layout_behavior =" @ string / appbar_scrolling_view_behavior "`
* An event may be taken in horizontal scrolling while vertical scrolling.

Thank you.

Comments

dx...@gmail.com <dx...@gmail.com> #2Jul 31, 2019 03:31AM

My guess is an AutoValue extension is what's needed here:

http://ryanharter.com/blog/2016/05/16/autovalue-extensions/

We accept pull requests! :)

jg...@google.com <jg...@google.com> #3Jul 31, 2019 11:10AM

> We accept pull requests! :)

Is there a public repo somewhere? I don't see any obvious repo for it in

https://android.googlesource.com, and it doesn't seem to be inside

https://android.googlesource.com/platform/frameworks/support.

Room supports final fields (yay!), which probably will suffice for many people with respect to this feature request.

dx...@gmail.com <dx...@gmail.com> #4Aug 1, 2019 09:56AM

Room supports immutability (it can use arg constructors) but does not directly support AutoValue. It is in the schedule but not high priority :/. Idk much about its internals at this stage so I'm not sure how we would implement it but should be totally doable.

Sorry we don't have the source release yet :/.

jg...@google.com <jg...@google.com> Aug 6, 2019 03:18PM

Assigned to jg...@google.com.

jg...@google.com <jg...@google.com> #5Aug 12, 2019 04:28PM

"It is in the schedule but not high priority" -- completely understandable.

"Sorry we don't have the source release yet :/." -- ah, OK, I thought perhaps with the pull request comment, that meant that there was a repo somewhere that I had overlooked.

Thanks!

no-scroll-orientation-lock.mp4

11 MB

Download

je...@google.com <je...@google.com> Aug 13, 2019 03:55PM

Accepted by je...@google.com.

ap...@google.com <ap...@google.com> #6Aug 22, 2019 01:52PM

Add autovalue support also means you can easily achieve parcelable by

https://github.com/rharter/auto-value-parcel. Please consider support this.

je...@google.com <je...@google.com> #7Aug 22, 2019 02:41PM

AutoValue is really a handy way to ensure data integrity.

je...@google.com <je...@google.com> #8Aug 22, 2019 02:42PM

Marked as fixed.

Please add AutoValue support. AutoValue is a Google library with really good benefits such as toString() , hashCode() , AutoValue.Builder , checks at creation time if @NonNull values are null, etc.