Fixed
Status Update
No update yet.
Comments
cc...@google.com
The benchmarks of the benchmark lib (androidx.benchmark.benchmark) are likely entirely from toggling testBuildType to release, and have largely returned back to previous values, though variance may be higher than before. We'll need to keep an eye on that.
Looking at the three big compose improvements, we see similar behavior, e.g. CheckboxesInRows:https://screenshot.googleplex.com/LjfrGwdnLgO
Looking at the three big compose improvements, we see similar behavior, e.g. CheckboxesInRows:
cc...@google.com
On average, benchmarks became about 50% faster, but it varies drastically per benchmark, with many benchmarks unaffected (and not showing in the results above).
Closing this as fixed, since we're back to before, but this proves how significant release mode dependencies are in (at minimum) removing overhead of code coverage. Notably, this change didn't affect all benchmarks equally, so the overhead of debug build type is unpredictable, and thus more important to avoid.
We should try and migrate back to release testBuildType sooner rather than later (see
Closing this as fixed, since we're back to before, but this proves how significant release mode dependencies are in (at minimum) removing overhead of code coverage. Notably, this change didn't affect all benchmarks equally, so the overhead of debug build type is unpredictable, and thus more important to avoid.
We should try and migrate back to release testBuildType sooner rather than later (see
Description
Range of builds:
androidx.ui.benchmark.test.RectsInColumnBenchmark_first_layout_1_
androidx.ui.benchmark.test.RectsInColumnBenchmark_toggleRectangleColor_layout_10_
androidx.benchmark.benchmark.ParameterizedBenchmark_noop_1_
androidx.ui.benchmark.test.CheckboxesInRowsBenchmark_first_draw_10_
androidx.benchmark.integration.startup.benchmark.StartupBenchmark_spin
androidx.ui.benchmark.test.CheckboxesInRowsBenchmark_layout_10_
androidx.ui.benchmark.test.RectsInColumnSharedModelBenchmark_first_measure_10_
androidx.ui.benchmark.test.RectsInColumnBenchmark_layout_1_
androidx.ui.benchmark.test.CheckboxesInRowsBenchmark_first_draw_1_
androidx.ui.benchmark.test.RectsInColumnSharedModelBenchmark_draw_10_
androidx.ui.benchmark.test.RectsInColumnBenchmark_toggleRectangleColor_layout_1_
androidx.ui.benchmark.test.RectsInColumnSharedModelBenchmark_layout_10_
androidx.ui.benchmark.test.RectsInColumnBenchmark_layout_10_
androidx.benchmark.benchmark.ParameterizedBenchmark_noop_0_
androidx.benchmark.benchmark.TrivialJavaBenchmark_nothing
androidx.ui.benchmark.test.RectsInColumnBenchmark_first_layout_10_
androidx.ui.benchmark.test.CheckboxesInRowsBenchmark_layout_1_
androidx.ui.benchmark.test.CheckboxesInRowsBenchmark_toggleCheckbox_layout_1_
androidx.ui.benchmark.test.RectsInColumnBenchmark_toggleRectangleColor_measure_10_
androidx.ui.benchmark.test.CheckboxesInRowsBenchmark_toggleCheckbox_layout_10_
androidx.ui.benchmark.test.RectsInColumnSharedModelBenchmark_first_draw_10_
androidx.ui.benchmark.test.CheckboxesInRowsBenchmark_toggleCheckbox_measure_1_
androidx.ui.benchmark.test.CheckboxesInRowsBenchmark_toggleCheckbox_measure_10_
androidx.ui.benchmark.test.CheckboxesInRowsBenchmark_first_measure_10_
androidx.ui.benchmark.test.CheckboxesInRowsBenchmark_first_layout_10_
androidx.ui.benchmark.test.RectsInColumnBenchmark_first_measure_10_
androidx.ui.benchmark.test.RectsInColumnBenchmark_toggleRectangleColor_draw_10_
androidx.ui.benchmark.test.RectsInColumnBenchmark_first_measure_1_
androidx.ui.benchmark.test.RectsInColumnSharedModelBenchmark_layout_1_
androidx.ui.benchmark.test.CheckboxesInRowsBenchmark_first_layout_1_
androidx.ui.benchmark.test.RectsInColumnBenchmark_draw_10_
androidx.ui.benchmark.test.RectsInColumnBenchmark_toggleRectangleColor_measure_1_
androidx.ui.benchmark.test.RectsInColumnSharedModelBenchmark_first_layout_10_
androidx.ui.benchmark.test.CheckboxesInRowsBenchmark_draw_1_
androidx.recyclerview.benchmark.ScrollBenchmark_offset
androidx.ui.benchmark.test.CheckboxesInRowsBenchmark_first_measure_1_
androidx.ui.benchmark.test.RectsInColumnSharedModelBenchmark_toggleRectangleColor_measure_1_
androidx.ui.benchmark.test.RectsInColumnSharedModelBenchmark_toggleRectangleColor_draw_10_
androidx.ui.benchmark.test.RectsInColumnSharedModelBenchmark_first_measure_1_
androidx.ui.benchmark.test.RectsInColumnBenchmark_first_draw_1_
androidx.ui.benchmark.test.CheckboxesInRowsBenchmark_toggleCheckbox_draw_1_
androidx.slice.SliceViewMetrics_testSet_shortcut_
androidx.ui.benchmark.test.RectsInColumnSharedModelBenchmark_first_layout_1_