Fixed
Status Update
No update yet.
Comments
da...@google.com
Room supports List and Set but not Map. We can certainly do this, but we will need a mechanism (maybe in the annotation) to know which column to use as the key of the Map since users can define DAO methods that return a Map of POJOs with some but not all columns of an Entity. Even if its an Entity where we can infer the primary key, it can be possible that might not be the key a user wants or might be possible that the Entity has a composed key of more than one column.
da...@google.com
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit 353f7769726477f284391858fac47b92e834a001
Author: Elif Bilgin <elifbilgin@google.com>
Date: Mon Aug 23 13:46:28 2021
Adding support for ArrayMap return type in @MapInfo.
Adding ArrayMap to the list of supported map return type for Dao query functions. This type is very similar to the Map type handling, hence functionality has been added to MapQueryResultAdapter.kt to handle ArrayMap to avoid duplicate code.
Test: MultimapQueryTest.java
Bug: 138910317
Change-Id: Ic7985d3dbeb242158b9ae33989279131032a67c8
M room/integration-tests/testapp/src/androidTest/java/androidx/room/integration/testapp/dao/MusicDao.java
M room/integration-tests/testapp/src/androidTest/java/androidx/room/integration/testapp/test/MultimapQueryTest.java
M room/room-compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/room-compiler/src/main/kotlin/androidx/room/solver/query/result/MapQueryResultAdapter.kt
https://android-review.googlesource.com/1806616
Branch: androidx-main
commit 353f7769726477f284391858fac47b92e834a001
Author: Elif Bilgin <elifbilgin@google.com>
Date: Mon Aug 23 13:46:28 2021
Adding support for ArrayMap return type in @MapInfo.
Adding ArrayMap to the list of supported map return type for Dao query functions. This type is very similar to the Map type handling, hence functionality has been added to MapQueryResultAdapter.kt to handle ArrayMap to avoid duplicate code.
Test: MultimapQueryTest.java
Bug: 138910317
Change-Id: Ic7985d3dbeb242158b9ae33989279131032a67c8
M room/integration-tests/testapp/src/androidTest/java/androidx/room/integration/testapp/dao/MusicDao.java
M room/integration-tests/testapp/src/androidTest/java/androidx/room/integration/testapp/test/MultimapQueryTest.java
M room/room-compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/room-compiler/src/main/kotlin/androidx/room/solver/query/result/MapQueryResultAdapter.kt
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit 29251c7f04b5f2b0e12ebf97f774cf0a5f780d8b
Author: Elif Bilgin <elifbilgin@google.com>
Date: Wed Aug 25 12:37:58 2021
Supporting SparseArray and LongSparseArray in @MapInfo.
Adding support for the SparseArray return type (keyed by integer) and LongSparseArray return type (keyed by Long) in query methods.
Test: MultimapQueryTest.java
Bug: 138910317
Change-Id: Ic91a2774796d9ce3d4d57a5121f90e3cf339281b
M room/room-compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/room-compiler/src/main/kotlin/androidx/room/ext/javapoet_ext.kt
M room/integration-tests/testapp/src/androidTest/java/androidx/room/integration/testapp/test/MultimapQueryTest.java
M room/integration-tests/testapp/src/androidTest/java/androidx/room/integration/testapp/dao/MusicDao.java
M room/room-compiler/src/main/kotlin/androidx/room/solver/query/result/MapQueryResultAdapter.kt
https://android-review.googlesource.com/1809044
Branch: androidx-main
commit 29251c7f04b5f2b0e12ebf97f774cf0a5f780d8b
Author: Elif Bilgin <elifbilgin@google.com>
Date: Wed Aug 25 12:37:58 2021
Supporting SparseArray and LongSparseArray in @MapInfo.
Adding support for the SparseArray return type (keyed by integer) and LongSparseArray return type (keyed by Long) in query methods.
Test: MultimapQueryTest.java
Bug: 138910317
Change-Id: Ic91a2774796d9ce3d4d57a5121f90e3cf339281b
M room/room-compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/room-compiler/src/main/kotlin/androidx/room/ext/javapoet_ext.kt
M room/integration-tests/testapp/src/androidTest/java/androidx/room/integration/testapp/test/MultimapQueryTest.java
M room/integration-tests/testapp/src/androidTest/java/androidx/room/integration/testapp/dao/MusicDao.java
M room/room-compiler/src/main/kotlin/androidx/room/solver/query/result/MapQueryResultAdapter.kt
Description
Currently for queries like `SELCT *` we can use return type List<Model>. Can we also support ArrayMap<String, Model> (for TEXT type primary key) or ArrayMap<Long, Model> (for INTEGER type primary key). This will make traversing faster in this list of elements.
I haven't tried HashMap but support, that would also be great.
SparseArray in case of INTEGER type primary key can also make sense.