Duplicate

Bug

Status Update

No update yet.

Description

[Deleted User]

created issue #1

Aug 7, 2019 08:46AM

If I set paddings on ViewPager2 like so:
<androidx.viewpager2.widget.ViewPager2
android:paddingEnd="20dp"
android:paddingStart="20dp"
android:clipToPadding="false" />

the padding is also applied to overscrollIndicators, which makes them not stick to the view bounds. please check the GIF attached

overscroll.gif

347 KB

View

Download

Comments

[Deleted User] <[Deleted User]> #2Aug 7, 2019 08:52AM

Project: platform/frameworks/support
Branch: androidx-main
Author: Jeremy Woods <jbwoods@google.com>
Link: https://android-review.googlesource.com/3544660

Remove android specific NavControllerViewModel

Expand for full commit details

Remove android specific NavControllerViewModel 
 
Everything in NavControllerViewModel is common API so we don't need an 
Android version. Moving that code to common. 
 
Test: all tests pass 
Bug: 403616316 
 
Change-Id: Ibe154b2d04adc0a536f9a5e170cc8fbb44ed1bcf

Files:

D navigation/navigation-runtime/src/androidMain/kotlin/androidx/navigation/NavControllerViewModel.android.kt
M navigation/navigation-runtime/src/commonMain/kotlin/androidx/navigation/NavControllerViewModel.kt

Hash: 3bb40a6be709d8c7e13f56f248a6433154aec72e
Date: Fri Mar 14 21:37:30 2025

jg...@google.com <jg...@google.com> Aug 7, 2019 11:20AM

Assigned to jg...@google.com.

jg...@google.com <jg...@google.com> #3Aug 7, 2019 04:15PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Jeremy Woods <jbwoods@google.com>
Link: https://android-review.googlesource.com/3544945

Implement nonAndroid NavType

Expand for full commit details

Implement nonAndroid NavType 
 
Moving call common implementation of NavType to commonMain and then 
allow both the nonAndroid and Android implementation to use them. 
 
Test: all tests pass 
Bug: 403616316 
Change-Id: I297d8846859aaa719b179c7e69e993d0d6e28fd6

Files:

M navigation/navigation-common/src/androidMain/kotlin/androidx/navigation/NavType.android.kt
M navigation/navigation-common/src/commonMain/kotlin/androidx/navigation/NavType.kt
M navigation/navigation-common/src/nonAndroidMain/kotlin/androidx/navigation/NavType.nonAndroid.kt

Hash: 8f968ddbb3b8296af2033db4cf2658255fa43853
Date: Fri Mar 14 22:41:34 2025

[Deleted User] <[Deleted User]> #4Aug 7, 2019 05:39PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Jeremy Woods <jbwoods@google.com>
Link: https://android-review.googlesource.com/3555283

Change NavBackStackEntryState to SavedState

Expand for full commit details

Change NavBackStackEntryState to SavedState 
 
Instead of NavBackStackEntryState being a Parcelable, we can change it 
to use SavedState. This allows for compat with other platforms. 
 
Test: all tests pass 
Bug: 403616316 
Change-Id: I1da40e98fbc70413e0818a95cb00aa1e5aa7a3dd

Files:

M navigation/navigation-runtime/src/androidMain/kotlin/androidx/navigation/NavBackStackEntryState.android.kt
M navigation/navigation-runtime/src/androidMain/kotlin/androidx/navigation/NavController.android.kt
A navigation/navigation-runtime/src/commonMain/kotlin/androidx/navigation/NavBackStackEntryState.kt
A navigation/navigation-runtime/src/commonMain/kotlin/androidx/navigation/internal/NavBackStackEntryStateImpl.kt
A navigation/navigation-runtime/src/nonAndroidMain/kotlin/androidx/navigation/NavBackStackEntryState.nonAndroid.kt

Hash: 52447f8ffb1f3e1f9890f8bb9d1ac1690aad508d
Date: Thu Mar 20 19:48:37 2025

jg...@google.com <jg...@google.com> #5Aug 8, 2019 01:56PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Jeremy Woods <jbwoods@google.com>
Link: https://android-review.googlesource.com/3555586

Introduce NavContext

Expand for full commit details

Introduce NavContext 
 
Providing a multiplatform compatible version of Context that can be 
used across navigation. 
 
RelNote: "Added multi-platform NavContext that helps to wrap Android's context." 
Test: all tests pass 
Bug: 403616316 
Change-Id: Ic4b1249ea6dc1a363855a4162ef136bf74809256

Files:

M navigation/navigation-common/bcv/native/current.txt
M navigation/navigation-common/src/androidMain/kotlin/androidx/navigation/NavBackStackEntry.android.kt
M navigation/navigation-common/src/androidMain/kotlin/androidx/navigation/NavDestination.android.kt
M navigation/navigation-common/src/androidMain/kotlin/androidx/navigation/NavGraph.android.kt
A navigation/navigation-common/src/androidMain/kotlin/androidx/navigation/internal/NavContext.android.kt
M navigation/navigation-common/src/commonMain/kotlin/androidx/navigation/NavBackStackEntry.kt
A navigation/navigation-common/src/commonMain/kotlin/androidx/navigation/internal/NavContext.kt
M navigation/navigation-common/src/nonAndroidMain/kotlin/androidx/navigation/NavBackStackEntry.nonAndroid.kt
A navigation/navigation-common/src/nonAndroidMain/kotlin/androidx/navigation/internal/NavContext.nonAndroid.kt
M navigation/navigation-runtime/src/androidInstrumentedTest/kotlin/androidx/navigation/NavBackStackEntryTest.kt
M navigation/navigation-runtime/src/androidMain/kotlin/androidx/navigation/NavBackStackEntryState.android.kt
M navigation/navigation-runtime/src/androidMain/kotlin/androidx/navigation/NavController.android.kt
M navigation/navigation-runtime/src/androidMain/kotlin/androidx/navigation/NavDeepLinkBuilder.android.kt
M navigation/navigation-runtime/src/commonMain/kotlin/androidx/navigation/NavController.kt
M navigation/navigation-runtime/src/nonAndroidMain/kotlin/androidx/navigation/NavController.nonAndroid.kt
M navigation/navigation-testing/src/androidMain/kotlin/androidx/navigation/testing/TestNavigatorState.android.kt
M navigation/navigation-ui/src/main/java/androidx/navigation/ui/NavigationUI.kt

Hash: 11b876fc10dec008f1f3b979795470f92ed4bb19
Date: Fri Mar 21 15:15:05 2025

[Deleted User] <[Deleted User]> #6Aug 8, 2019 02:09PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Jeremy Woods <jbwoods@google.com>
Link: https://android-review.googlesource.com/3561523

Introduce AtomicInt

Expand for full commit details

Introduce AtomicInt 
 
Adding a multi-platform AtomicInteger implementation and using it in 
NavController. 
 
Test: all tests pass 
Bug: 403616316 
Change-Id: I4126b3b9f946bd651afe06a242194e6f2d40302c

Files:

M navigation/navigation-runtime/src/androidMain/kotlin/androidx/navigation/NavController.android.kt
A navigation/navigation-runtime/src/androidMain/kotlin/androidx/navigation/internal/AtomicInt.android.kt
A navigation/navigation-runtime/src/commonMain/kotlin/androidx/navigation/internal/AtomicInt.kt
A navigation/navigation-runtime/src/nonAndroidMain/kotlin/androidx/navigation/internal/AtomicInt.nonAndroid.kt

Hash: f6fe240b918e01ca382e741b728f43c068e3d9db
Date: Tue Mar 25 19:34:06 2025

jg...@google.com <jg...@google.com> #7Aug 8, 2019 02:38PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Jeremy Woods <jbwoods@google.com>
Link: https://android-review.googlesource.com/3552203

Provide NavController implementation in common

Expand for full commit details

Provide NavController implementation in common 
 
Adding a new internal NavControllerImpl to clean up NavController 
implementation. 
 
RelNote: N/A 
Test: all tests pass 
Bug: 403616316 
Change-Id: I7aee97b1c3a497803534480cb10205fdf0455310

Files:

M navigation/navigation-common/bcv/native/current.txt
M navigation/navigation-common/src/nonAndroidMain/kotlin/androidx/navigation/NavDestination.nonAndroid.kt
M navigation/navigation-runtime/bcv/native/current.txt
M navigation/navigation-runtime/src/androidMain/kotlin/androidx/navigation/NavController.android.kt
M navigation/navigation-runtime/src/commonMain/kotlin/androidx/navigation/NavController.kt
A navigation/navigation-runtime/src/commonMain/kotlin/androidx/navigation/internal/NavControllerImpl.kt
M navigation/navigation-runtime/src/nonAndroidMain/kotlin/androidx/navigation/NavController.nonAndroid.kt

Hash: 08d41ac1a7d63948d9747e5572e9bc47e2c539d6
Date: Wed Mar 26 07:51:37 2025

je...@google.com <je...@google.com> Aug 12, 2019 02:44PM

Accepted by je...@google.com.

ap...@google.com <ap...@google.com> #8Aug 16, 2019 02:05PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Jeremy Woods <jbwoods@google.com>
Link: https://android-review.googlesource.com/3559987

Provide additional NavGraph and NavDestination APIs

Expand for full commit details

Provide additional NavGraph and NavDestination APIs 
 
Adding a public int id and an internal getDisplayName to 
NavDestination. 
 
Adding startdestinationId and findNodeComprehensive to NavGraph. 
 
RelNote: N/A 
Test: all tests pass 
Bug: 403616316 
Change-Id: Idf3293890e4cd69f88aa4d72634c9be821663449

Files:

M navigation/navigation-common/bcv/native/current.txt
M navigation/navigation-common/src/androidMain/kotlin/androidx/navigation/NavDestination.android.kt
M navigation/navigation-common/src/androidMain/kotlin/androidx/navigation/NavGraph.android.kt
M navigation/navigation-common/src/commonMain/kotlin/androidx/navigation/NavDestination.kt
M navigation/navigation-common/src/commonMain/kotlin/androidx/navigation/NavGraph.kt
M navigation/navigation-common/src/nonAndroidMain/kotlin/androidx/navigation/NavDestination.nonAndroid.kt
M navigation/navigation-common/src/nonAndroidMain/kotlin/androidx/navigation/NavGraph.nonAndroid.kt

Hash: 5f335b3312dfb96723faa7b7c57e3981d13f40f3
Date: Wed Mar 26 07:45:00 2025

ap...@google.com <ap...@google.com> #9Aug 21, 2019 11:57PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Jeremy Woods <jbwoods@google.com>
Link: https://android-review.googlesource.com/3561524

Provide internal multi-platform Log

Expand for full commit details

Provide internal multi-platform Log 
 
Ensuring that we have the ability to log from common code. This only 
takes over for info logs, other types of logs remain on the android 
platform only. 
 
Test: all tests pass 
Bug: 403616316 
Change-Id: I14b8b1e16cc7565b0789fd11bf85143fe0ed38d3

Files:

M navigation/navigation-runtime/src/androidMain/kotlin/androidx/navigation/NavController.android.kt
A navigation/navigation-runtime/src/androidMain/kotlin/androidx/navigation/internal/Log.android.kt
A navigation/navigation-runtime/src/commonMain/kotlin/androidx/navigation/internal/Log.kt
A navigation/navigation-runtime/src/nonAndroidMain/kotlin/androidx/navigation/internal/Log.nonAndroid.kt

Hash: 55f9ec50929827a5becc445c22805be6f3d28950
Date: Tue Mar 25 20:22:11 2025

je...@google.com <je...@google.com> #10Aug 28, 2019 05:27PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main
Author: Jeremy Woods <jbwoods@google.com>
Link: https://android-review.googlesource.com/3560566

Provide popUpToId for NavOptions

Expand for full commit details

Provide popUpToId for NavOptions 
 
Adding an expect for popUpToId and implementing it in nonAndroid 
targets. 
 
RelNote: N/A 
Test: all tests pass 
Bug: 403616316 
Change-Id: I9a354359828786be54268096859bf8b3b35b51ac

Files:

M navigation/navigation-common/bcv/native/current.txt
M navigation/navigation-common/src/androidMain/kotlin/androidx/navigation/NavOptions.android.kt
M navigation/navigation-common/src/commonMain/kotlin/androidx/navigation/NavOptions.kt
M navigation/navigation-common/src/nonAndroidMain/kotlin/androidx/navigation/NavOptions.nonAndroid.kt

Hash: b8a7d84a3201329cd33b11c12b2154b4a4215cf1
Date: Wed Mar 26 07:30:20 2025

jg...@google.com <jg...@google.com> #11Aug 29, 2019 02:56PM

Status: Assigned (reopened)

Project: platform/frameworks/support
Branch: androidx-main
Author: Jeremy Woods <jbwoods@google.com>
Link: https://android-review.googlesource.com/3560964

Move all of NavBackStackEntryProvider to common

Expand for full commit details

Move all of NavBackStackEntryProvider to common 
 
Adding expect/actual for WeakReference and UUID to move the entire 
NavBackStackEntryProvider class to common. 
 
Test: all tests pass 
Bug: 403616316 
 
Change-Id: I7e3b82e1788edd40e7a7cf92f3ec16c07f7e6bda

Files:

M navigation/navigation-compose/build.gradle
D navigation/navigation-compose/src/androidMain/kotlin/androidx/navigation/compose/NavBackStackEntryProvider.android.kt
M navigation/navigation-compose/src/androidMain/kotlin/androidx/navigation/compose/internal/NavComposeUtils.android.kt
M navigation/navigation-compose/src/commonMain/kotlin/androidx/navigation/compose/NavBackStackEntryProvider.kt
M navigation/navigation-compose/src/commonMain/kotlin/androidx/navigation/compose/NavHost.kt
M navigation/navigation-compose/src/commonMain/kotlin/androidx/navigation/compose/internal/NavComposeUtils.kt
D navigation/navigation-compose/src/nonAndroidMain/kotlin/androidx/navigation/compose/NavBackStackEntryProvider.nonAndroid.kt
A navigation/navigation-compose/src/nonAndroidMain/kotlin/androidx/navigation/compose/internal/NavComposeUtils.nonAndroid.kt
D navigation/navigation-compose/src/nonAndroidMain/kotlin/androidx/navigation/compose/internal/NavHostInternals.nonAndroid.kt

Hash: e59c45ab84ef047b9a5f455851f99a394cd30cbd
Date: Wed Mar 26 19:03:12 2025

gs...@yahoo.com <gs...@yahoo.com> #12Oct 11, 2019 11:46AM

Project: platform/frameworks/support
Branch: androidx-main
Author: Jeremy Woods <jbwoods@google.com>
Link: https://android-review.googlesource.com/3555747

Change the NavUri parse function

Expand for full commit details

Change the NavUri parse function 
 
Changing the parseStringAsNavUri into more of a factory function. 
Ideally this would be a function on a Compantion objects of NavUri, but 
if we want to alias NavUri to android's Uri, this is not possible. 
 
RelNote: "parseStringAsNavUri function has been changed to `NavUri` 
function that takes a String." 
Test: ./gradlew checkApi 
Bug: 403616316 
 
Change-Id: I4db6eeb13f86b3dbd987f9b55a49e9a45a8d0b38

Files:

M navigation/navigation-common/api/current.txt
M navigation/navigation-common/api/restricted_current.txt
M navigation/navigation-common/bcv/native/current.txt
M navigation/navigation-common/src/commonMain/kotlin/androidx/navigation/NavUri.kt

Hash: f353bd4db8d3ef6ea1d9fab22f8423e2217b69c0
Date: Mon Mar 24 04:02:30 2025

jg...@google.com <jg...@google.com> #13Dec 18, 2019 03:59PM

Status: Duplicate of

134912610

Android API Change

This bug was referenced by a recent CL that changed the Android API surface area.

The Android API Council regularly reviews API changes for consistency and sustainability, and we've just added this bug to our hotlist of pending reviews.

We'll wait until you mark this bug as 'Fixed' before starting our review, but please reach out if you'd like us to review it sooner.

Changes to navigation/navigation-common/api/current.txt

androidx.navigation
androidx.navigation.NavUriKt

http://go/agw/platform/frameworks/support/+/f353bd4db8d3ef6ea1d9fab22f8423e2217b69c0%5E%21
https://android-review.googlesource.com/3555747

[Gerrit:https://android-review.googlesource.com/3555747]
[API-Approvers:ilake@google.com]
[Branch:androidx-main]

[LIBRARY_API_REVIEW_TAG:navigation/navigation-common/api/current.txt]

IssueTracker

[ViewPager2] Overscroll Indicators shouldn't obey padding

Status Update

Description

Comments

[Deleted User] <[Deleted User]> #2Aug 7, 2019 08:52AM

jg...@google.com <jg...@google.com> Aug 7, 2019 11:20AM

jg...@google.com <jg...@google.com> #3Aug 7, 2019 04:15PM

[Deleted User] <[Deleted User]> #4Aug 7, 2019 05:39PM

jg...@google.com <jg...@google.com> #5Aug 8, 2019 01:56PM

[Deleted User] <[Deleted User]> #6Aug 8, 2019 02:09PM

jg...@google.com <jg...@google.com> #7Aug 8, 2019 02:38PM

je...@google.com <je...@google.com> Aug 12, 2019 02:44PM

ap...@google.com <ap...@google.com> #8Aug 16, 2019 02:05PM

ap...@google.com <ap...@google.com> #9Aug 21, 2019 11:57PM

je...@google.com <je...@google.com> #10Aug 28, 2019 05:27PM

jg...@google.com <jg...@google.com> #11Aug 29, 2019 02:56PM

gs...@yahoo.com <gs...@yahoo.com> #12Oct 11, 2019 11:46AM

jg...@google.com <jg...@google.com> #13Dec 18, 2019 03:59PM

Android API Change

Issue 139012032

Description

Issue summary

Comments

[Deleted User] <[Deleted User]> #2Aug 7, 2019 08:52AM

jg...@google.com <jg...@google.com> Aug 7, 2019 11:20AM

jg...@google.com <jg...@google.com> #3Aug 7, 2019 04:15PM

[Deleted User] <[Deleted User]> #4Aug 7, 2019 05:39PM

jg...@google.com <jg...@google.com> #5Aug 8, 2019 01:56PM

[Deleted User] <[Deleted User]> #6Aug 8, 2019 02:09PM

jg...@google.com <jg...@google.com> #7Aug 8, 2019 02:38PM

je...@google.com <je...@google.com> Aug 12, 2019 02:44PM

ap...@google.com <ap...@google.com> #8Aug 16, 2019 02:05PM

ap...@google.com <ap...@google.com> #9Aug 21, 2019 11:57PM

je...@google.com <je...@google.com> #10Aug 28, 2019 05:27PM

jg...@google.com <jg...@google.com> #11Aug 29, 2019 02:56PM

gs...@yahoo.com <gs...@yahoo.com> #12Oct 11, 2019 11:46AM

jg...@google.com <jg...@google.com> #13Dec 18, 2019 03:59PM

Android API Change

Add comment

Issue metadata