Fixed
Status Update
No update yet.
Comments
je...@google.com
since these are in public API (:/) we need to do this in 1.2
sh...@google.com
since it is already marked as deprecated, we can probably do it by now.
je...@google.com
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date: Tue Aug 11 09:30:34 2020
[GH] Hide deprecated internal API.
## Proposed Changes
* `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.
## Testing
Test: Ran unit tests locally
## Issues Fixed
Fixes: 76109329
This is an imported pull request fromhttps://github.com/androidx/androidx/pull/61 .
Resolves #61
Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7
Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92
A room/runtime/api/current.ignore
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/RoomDatabase.java
https://android-review.googlesource.com/1396827
Branch: androidx-master-dev
commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date: Tue Aug 11 09:30:34 2020
[GH] Hide deprecated internal API.
## Proposed Changes
* `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.
## Testing
Test: Ran unit tests locally
## Issues Fixed
Fixes: 76109329
This is an imported pull request from
Resolves #61
Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7
Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92
A room/runtime/api/current.ignore
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/RoomDatabase.java
je...@google.com
Reopened because the issue also exists in LinearSnapHelper
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 1192e296b529ca8e7ed3e282ad52c7677a9bb827
Author: Jelle Fresen <jellefresen@google.com>
Date: Thu Aug 22 11:53:02 2019
Always snap to center between padding
Even when clipToPadding is false, the center of RecyclerView is still
the middle of the rectangle described on the inside of the padding, not
the middle of the rectangle described on the outside of the padding.
Bug: 139452422
Test: ./gradlew recyclerview:recyclerview:cC \
-Pandroid.testInstrumentationRunnerArguments.class=\
androidx.recyclerview.widget.StaggeredGridLayoutManagerSnappingTest
and GridLayoutManagerSnappingTest
and LinearLayoutManagerSnappingTest
Change-Id: Ib4da578d4058b4d0c1ed5425b563de6ee292bd2c
M recyclerview/recyclerview/src/main/java/androidx/recyclerview/widget/LinearSnapHelper.java
https://android-review.googlesource.com/1106715
https://goto.google.com/android-sha1/1192e296b529ca8e7ed3e282ad52c7677a9bb827
Branch: androidx-master-dev
commit 1192e296b529ca8e7ed3e282ad52c7677a9bb827
Author: Jelle Fresen <jellefresen@google.com>
Date: Thu Aug 22 11:53:02 2019
Always snap to center between padding
Even when clipToPadding is false, the center of RecyclerView is still
the middle of the rectangle described on the inside of the padding, not
the middle of the rectangle described on the outside of the padding.
Bug: 139452422
Test: ./gradlew recyclerview:recyclerview:cC \
-Pandroid.testInstrumentationRunnerArguments.class=\
androidx.recyclerview.widget.StaggeredGridLayoutManagerSnappingTest
and GridLayoutManagerSnappingTest
and LinearLayoutManagerSnappingTest
Change-Id: Ib4da578d4058b4d0c1ed5425b563de6ee292bd2c
M recyclerview/recyclerview/src/main/java/androidx/recyclerview/widget/LinearSnapHelper.java
Description
The reasoning is that the padding defines the content rectangle, and whether or not children's pixels are clipped to that rectangle or not doesn't change the semantics of that rectangle.
Consider for example a horizontal ViewPager2 that has unequal padding on the left and the right. When it is in idle state, a page exactly fills the rectangle described by the inner edge of the padding, so the page looks to be off-center by design. When snapping kicks in (e.g., because of a swipe), the page to which it is snapping should end up in that same "off-center" position, exactly matching the rectangle described by the inner edge of the padding, regardless of the value of clipToPadding.