Fixed
Status Update
No update yet.
Comments
ap...@google.com
This is a hard one. We can't easily read native crashes from that Motorola device since their system image is not public. I assume you can't reproduce this either, but if possible can you try using WorkManager 2.0.0 or 1.0.1-rc01? This would help track down the possible changes that might have introduced this issue. Thanks!
ap...@google.com
We actually did reproduce it, the current store version of Pocket Casts has WorkManager 2.0.0 and this bug if you want to try and test something. I will try 1.0.1-rc01 and report back.
ap...@google.com
Is there a difference between 1.0.1 and 2.0.1? We tried 2.0.1 and it was crashing, if there is a difference I can try 1.0.1 but I thought they were the same?
ap...@google.com
Can you also describe how you trigger the bug and which devices manifest the problem? Is it just running the app? Is it doing something specific?
ap...@google.com
We are testing on a Moto X running Android 6.0 but our play store report shows numerous motorola devices are crashing as the attached screenshots show. We just downloaded a bunch of episodes (which uses workmanager) and eventually it started crashing, it would then crash at start up every time.
ap...@google.com
So to answer your earlier question, 1.0.1 should be equivalent but I think there may be some small differences in Room between 1.0 and 2.0 and since this crash seems related to Room, that's why we were asking if you could check to see if you can reproduce it on 1.x.
Regarding the initial crash, do you have any logs for that?
Regarding the initial crash, do you have any logs for that?
ap...@google.com
This is the log I have. Hope it helps. Will test 1.0.1 for you
ap...@google.com
The logs are too short its just the crash and not much else before. :(
If the phone happens to be rooted and you are OK with sharing DB queries then you can enable SQL logging so we can see the queries that are occurring:
adb shell setprop log.tag.SQLiteStatements VERBOSE
adb shell stop
adb shell start
It would also be great if you can send us a bigger set of logs, or even better yet a bugreport after the crash occurs. (https://developer.android.com/studio/debug/bug-report )
If the phone happens to be rooted and you are OK with sharing DB queries then you can enable SQL logging so we can see the queries that are occurring:
adb shell setprop log.tag.SQLiteStatements VERBOSE
adb shell stop
adb shell start
It would also be great if you can send us a bigger set of logs, or even better yet a bugreport after the crash occurs. (
ap...@google.com
We can't root the phone sorry, we might be able to send a bug report though
ap...@google.com
We have a bug report from the crash already actually
ap...@google.com
We haven't been able to get the crash to happen on 1.0.1 so far
ap...@google.com
With a version of WorkManager that you are able to reproduce the issue, can you try adding Room 2.1.0-alpha06 as a dependency, effectively upgrading WorkManager's runtime dependency of Room?
Can you also enable WorkManager logs using setMinimumLoggingLevel(Log.DEBUG)https://developer.android.com/topic/libraries/architecture/workmanager/advanced/custom-configuration
If you observe the crash please do take a bug report. If possible also dump dbinfo for the app's package: adb shell dumpsys dbinfo <package-name>
Can you also enable WorkManager logs using setMinimumLoggingLevel(Log.DEBUG)
If you observe the crash please do take a bug report. If possible also dump dbinfo for the app's package: adb shell dumpsys dbinfo <package-name>
vi...@google.com
We have gone back to 2.0.0 and haven't been able to make it crash again unfortunately. Will keep trying. We are rolling out an update next week that reverts to 1.0.0 and will let you know if the crash goes away in production as well
ap...@google.com
I just want to distinguish between which versions you are using/experiencing this on.
1. The bug title lists 2.0.0
2. The first update lists 2.0.1-rc01
3. #14 lists 2.0.0
Can you reproduce at all with any version of WorkManager 2.x at this point? And if so, which ones work and which ones don't?
1. The bug title lists 2.0.0
2. The first update lists 2.0.1-rc01
3. #14 lists 2.0.0
Can you reproduce at all with any version of WorkManager 2.x at this point? And if so, which ones work and which ones don't?
ap...@google.com
Our store version had 2.0.0 and is what the screenshots come from, we reproduced locally using that. We upgraded to 2.0.1rc1 and the phone was still crashing. We downgraded to 1.0.0 and the crash went away. To help with this testing we went back to 2.0.0 to try and get it to crash again but we haven't been able to get it to happen again.
vi...@google.com
We rolled out an update to the Play Store using WorkManager 1.0.0 and the issue has persisted unfortunately
ap...@google.com
Not sure it helps but this trace has a few more lines in it.
backtrace:
#00 pc 0000000000000000 <unknown>
#01 pc 0000000000025cdd /system/lib/libsqlite.so
#02 pc 0000000000025011 /system/lib/libsqlite.so
#03 pc 000000000000eb95 /system/lib/libsqlite.so
#04 pc 000000000002d60d /system/lib/libsqlite.so
#05 pc 000000000003b409 /system/lib/libsqlite.so
#06 pc 0000000000010931 /system/lib/libsqlite.so (sqlite3_step+536)
#07 pc 000000000007f175 /system/lib/libandroid_runtime.so
#08 pc 00000000018a0a33 /system/framework/arm/boot-framework.oat (android.database.sqlite.SQLiteConnection.nativeExecute+102)
#09 pc 00000000018a34b9 /system/framework/arm/boot-framework.oat (android.database.sqlite.SQLiteConnection.execute+260)
#10 pc 00000000018b3741 /system/framework/arm/boot-framework.oat (android.database.sqlite.SQLiteSession.endTransactionUnchecked+364)
#11 pc 00000000018b3ee5 /system/framework/arm/boot-framework.oat (android.database.sqlite.SQLiteSession.endTransaction+144)
#12 pc 00000000018ac61d /system/framework/arm/boot-framework.oat (android.database.sqlite.SQLiteDatabase.endTransaction+72)
#13 pc 00000000000a91c1 /system/lib/libart.so (art_quick_invoke_stub_internal+64)
#14 pc 00000000004031e9 /system/lib/libart.so (art_quick_invoke_stub+232)
#15 pc 00000000000b0455 /system/lib/libart.so (_ZN3art9ArtMethod6InvokeEPNS_6ThreadEPjjPNS_6JValueEPKc+136)
#16 pc 00000000001ec389 /system/lib/libart.so (_ZN3art11interpreter34ArtInterpreterToCompiledCodeBridgeEPNS_6ThreadEPNS_9ArtMethodEPKNS_7DexFile8CodeItemEPNS_11ShadowFrameEPNS_6JValueE+200)
#17 pc 00000000001e6939 /system/lib/libart.so (_ZN3art11interpreter6DoCallILb0ELb0EEEbPNS_9ArtMethodEPNS_6ThreadERNS_11ShadowFrameEPKNS_11InstructionEtPNS_6JValueE+492)
#18 pc 00000000003fd663 /system/lib/libart.so (MterpInvokeVirtualQuick+322)
#19 pc 000000000009fd94 /system/lib/libart.so (ExecuteMterpImpl+29972)
#20 pc 00000000001ca783 /system/lib/libart.so (_ZN3art11interpreterL7ExecuteEPNS_6ThreadEPKNS_7DexFile8CodeItemERNS_11ShadowFrameENS_6JValueEb+290)
#21 pc 00000000001cf2eb /system/lib/libart.so (_ZN3art11interpreter33ArtInterpreterToInterpreterBridgeEPNS_6ThreadEPKNS_7DexFile8CodeItemEPNS_11ShadowFrameEPNS_6JValueE+114)
#22 pc 00000000001e691f /system/lib/libart.so (_ZN3art11interpreter6DoCallILb0ELb0EEEbPNS_9ArtMethodEPNS_6ThreadERNS_11ShadowFrameEPKNS_11InstructionEtPNS_6JValueE+466)
#23 pc 00000000003fb92b /system/lib/libart.so (MterpInvokeInterface+826)
#24 pc 000000000009c214 /system/lib/libart.so (ExecuteMterpImpl+14740)
#25 pc 00000000001ca783 /system/lib/libart.so (_ZN3art11interpreterL7ExecuteEPNS_6ThreadEPKNS_7DexFile8CodeItemERNS_11ShadowFrameENS_6JValueEb+290)
#26 pc 00000000001cf2eb /system/lib/libart.so (_ZN3art11interpreter33ArtInterpreterToInterpreterBridgeEPNS_6ThreadEPKNS_7DexFile8CodeItemEPNS_11ShadowFrameEPNS_6JValueE+114)
#27 pc 00000000001e691f /system/lib/libart.so (_ZN3art11interpreter6DoCallILb0ELb0EEEbPNS_9ArtMethodEPNS_6ThreadERNS_11ShadowFrameEPKNS_11InstructionEtPNS_6JValueE+466)
#28 pc 00000000003fd663 /system/lib/libart.so (MterpInvokeVirtualQuick+322)
#29 pc 000000000009fd94 /system/lib/libart.so (ExecuteMterpImpl+29972)
#30 pc 00000000001ca783 /system/lib/libart.so (_ZN3art11interpreterL7ExecuteEPNS_6ThreadEPKNS_7DexFile8CodeItemERNS_11ShadowFrameENS_6JValueEb+290)
#31 pc 00000000001cf255 /system/lib/libart.so (_ZN3art11interpreter30EnterInterpreterFromEntryPointEPNS_6ThreadEPKNS_7DexFile8CodeItemEPNS_11ShadowFrameE+92)
#32 pc 00000000003f269f /system/lib/libart.so (artQuickToInterpreterBridge+706)
#33 pc 00000000000adc13 /system/lib/libart.so (art_quick_to_interpreter_bridge+34)
#34 pc 000000000064b125 /system/framework/arm/boot-core-libart.oat (java.util.concurrent.ThreadPoolExecutor.runWorker+344)
#35 pc 0000000000652b47 /system/framework/arm/boot-core-libart.oat (java.util.concurrent.ThreadPoolExecutor$Worker.run+42)
#36 pc 00000000005f749d /system/framework/arm/boot.oat (java.lang.Thread.run+48)
#37 pc 00000000000a91c1 /system/lib/libart.so (art_quick_invoke_stub_internal+64)
#38 pc 00000000004031e9 /system/lib/libart.so (art_quick_invoke_stub+232)
#39 pc 00000000000b0455 /system/lib/libart.so (_ZN3art9ArtMethod6InvokeEPNS_6ThreadEPjjPNS_6JValueEPKc+136)
#40 pc 0000000000314031 /system/lib/libart.so (_ZN3artL18InvokeWithArgArrayERKNS_33ScopedObjectAccessAlreadyRunnableEPNS_9ArtMethodEPNS_8ArgArrayEPNS_6JValueEPKc+56)
#41 pc 0000000000314dfd /system/lib/libart.so (_ZN3art35InvokeVirtualOrInterfaceWithJValuesERKNS_33ScopedObjectAccessAlreadyRunnableEP8_jobjectP10_jmethodIDP6jvalue+256)
#42 pc 000000000032be19 /system/lib/libart.so (_ZN3art6Thread14CreateCallbackEPv+848)
#43 pc 0000000000046eb3 /system/lib/libc.so (_ZL15__pthread_startPv+22)
#44 pc 0000000000019acd /system/lib/libc.so (__start_thread+6)
backtrace:
#00 pc 0000000000000000 <unknown>
#01 pc 0000000000025cdd /system/lib/libsqlite.so
#02 pc 0000000000025011 /system/lib/libsqlite.so
#03 pc 000000000000eb95 /system/lib/libsqlite.so
#04 pc 000000000002d60d /system/lib/libsqlite.so
#05 pc 000000000003b409 /system/lib/libsqlite.so
#06 pc 0000000000010931 /system/lib/libsqlite.so (sqlite3_step+536)
#07 pc 000000000007f175 /system/lib/libandroid_runtime.so
#08 pc 00000000018a0a33 /system/framework/arm/boot-framework.oat (android.database.sqlite.SQLiteConnection.nativeExecute+102)
#09 pc 00000000018a34b9 /system/framework/arm/boot-framework.oat (android.database.sqlite.SQLiteConnection.execute+260)
#10 pc 00000000018b3741 /system/framework/arm/boot-framework.oat (android.database.sqlite.SQLiteSession.endTransactionUnchecked+364)
#11 pc 00000000018b3ee5 /system/framework/arm/boot-framework.oat (android.database.sqlite.SQLiteSession.endTransaction+144)
#12 pc 00000000018ac61d /system/framework/arm/boot-framework.oat (android.database.sqlite.SQLiteDatabase.endTransaction+72)
#13 pc 00000000000a91c1 /system/lib/libart.so (art_quick_invoke_stub_internal+64)
#14 pc 00000000004031e9 /system/lib/libart.so (art_quick_invoke_stub+232)
#15 pc 00000000000b0455 /system/lib/libart.so (_ZN3art9ArtMethod6InvokeEPNS_6ThreadEPjjPNS_6JValueEPKc+136)
#16 pc 00000000001ec389 /system/lib/libart.so (_ZN3art11interpreter34ArtInterpreterToCompiledCodeBridgeEPNS_6ThreadEPNS_9ArtMethodEPKNS_7DexFile8CodeItemEPNS_11ShadowFrameEPNS_6JValueE+200)
#17 pc 00000000001e6939 /system/lib/libart.so (_ZN3art11interpreter6DoCallILb0ELb0EEEbPNS_9ArtMethodEPNS_6ThreadERNS_11ShadowFrameEPKNS_11InstructionEtPNS_6JValueE+492)
#18 pc 00000000003fd663 /system/lib/libart.so (MterpInvokeVirtualQuick+322)
#19 pc 000000000009fd94 /system/lib/libart.so (ExecuteMterpImpl+29972)
#20 pc 00000000001ca783 /system/lib/libart.so (_ZN3art11interpreterL7ExecuteEPNS_6ThreadEPKNS_7DexFile8CodeItemERNS_11ShadowFrameENS_6JValueEb+290)
#21 pc 00000000001cf2eb /system/lib/libart.so (_ZN3art11interpreter33ArtInterpreterToInterpreterBridgeEPNS_6ThreadEPKNS_7DexFile8CodeItemEPNS_11ShadowFrameEPNS_6JValueE+114)
#22 pc 00000000001e691f /system/lib/libart.so (_ZN3art11interpreter6DoCallILb0ELb0EEEbPNS_9ArtMethodEPNS_6ThreadERNS_11ShadowFrameEPKNS_11InstructionEtPNS_6JValueE+466)
#23 pc 00000000003fb92b /system/lib/libart.so (MterpInvokeInterface+826)
#24 pc 000000000009c214 /system/lib/libart.so (ExecuteMterpImpl+14740)
#25 pc 00000000001ca783 /system/lib/libart.so (_ZN3art11interpreterL7ExecuteEPNS_6ThreadEPKNS_7DexFile8CodeItemERNS_11ShadowFrameENS_6JValueEb+290)
#26 pc 00000000001cf2eb /system/lib/libart.so (_ZN3art11interpreter33ArtInterpreterToInterpreterBridgeEPNS_6ThreadEPKNS_7DexFile8CodeItemEPNS_11ShadowFrameEPNS_6JValueE+114)
#27 pc 00000000001e691f /system/lib/libart.so (_ZN3art11interpreter6DoCallILb0ELb0EEEbPNS_9ArtMethodEPNS_6ThreadERNS_11ShadowFrameEPKNS_11InstructionEtPNS_6JValueE+466)
#28 pc 00000000003fd663 /system/lib/libart.so (MterpInvokeVirtualQuick+322)
#29 pc 000000000009fd94 /system/lib/libart.so (ExecuteMterpImpl+29972)
#30 pc 00000000001ca783 /system/lib/libart.so (_ZN3art11interpreterL7ExecuteEPNS_6ThreadEPKNS_7DexFile8CodeItemERNS_11ShadowFrameENS_6JValueEb+290)
#31 pc 00000000001cf255 /system/lib/libart.so (_ZN3art11interpreter30EnterInterpreterFromEntryPointEPNS_6ThreadEPKNS_7DexFile8CodeItemEPNS_11ShadowFrameE+92)
#32 pc 00000000003f269f /system/lib/libart.so (artQuickToInterpreterBridge+706)
#33 pc 00000000000adc13 /system/lib/libart.so (art_quick_to_interpreter_bridge+34)
#34 pc 000000000064b125 /system/framework/arm/boot-core-libart.oat (java.util.concurrent.ThreadPoolExecutor.runWorker+344)
#35 pc 0000000000652b47 /system/framework/arm/boot-core-libart.oat (java.util.concurrent.ThreadPoolExecutor$Worker.run+42)
#36 pc 00000000005f749d /system/framework/arm/boot.oat (java.lang.Thread.run+48)
#37 pc 00000000000a91c1 /system/lib/libart.so (art_quick_invoke_stub_internal+64)
#38 pc 00000000004031e9 /system/lib/libart.so (art_quick_invoke_stub+232)
#39 pc 00000000000b0455 /system/lib/libart.so (_ZN3art9ArtMethod6InvokeEPNS_6ThreadEPjjPNS_6JValueEPKc+136)
#40 pc 0000000000314031 /system/lib/libart.so (_ZN3artL18InvokeWithArgArrayERKNS_33ScopedObjectAccessAlreadyRunnableEPNS_9ArtMethodEPNS_8ArgArrayEPNS_6JValueEPKc+56)
#41 pc 0000000000314dfd /system/lib/libart.so (_ZN3art35InvokeVirtualOrInterfaceWithJValuesERKNS_33ScopedObjectAccessAlreadyRunnableEP8_jobjectP10_jmethodIDP6jvalue+256)
#42 pc 000000000032be19 /system/lib/libart.so (_ZN3art6Thread14CreateCallbackEPv+848)
#43 pc 0000000000046eb3 /system/lib/libc.so (_ZL15__pthread_startPv+22)
#44 pc 0000000000019acd /system/lib/libc.so (__start_thread+6)
ap...@google.com
Unfortunately, this is still not telling us anything we can diagnose. Paired with the fact that we haven't gotten any other reports of this issue, it's not clear how we should proceed. We would need Motorola system images to proceed at this point. I can suggest one more thing: if you go back to the last version that worked fine for you and simply change your WorkManager dependency (but *not* any of the rest of your app's code changes), does it immediately exhibit the crash? Basically, I'm wondering if something else with your code is triggering or exacerbating the issue.
ap...@google.com
Ping to the original reporter(s).
an...@google.com
Sorry I have been on leave for Easter. I think you are right about some other code change triggering this bug, will see if I can work anything out. I am at I/O next week as well if you want to have a look yourself.
ap...@google.com
Thanks, closing this out for now - feel free to reply if there's anything else we can assist you with on this matter.
ap...@google.com
This is a definite stab in the dark but do you use a ForeignKey with Room? This is the only reference I can find to similar crashes online. https://stackoverflow.com/questions/50662521/tombstone-using-foreignkey-with-room
il...@google.com
ap...@google.com
We do use foreign keys, but we've been doing that since our early alpha versions so I'm not sure that's it.
ap...@google.com
Fair enough, both crash reports have this sqlite3_step+536 in common. Will keep trying to work it out.
ap...@google.com
We seem to have narrowed this down to calling
WorkManager.initialize(applicationContext, workManagerConfig)
WorkManager.getInstance().getWorkInfosByTagLiveData(DownloadManager.WORK_MANAGER_DOWNLOAD_TAG).observeForever {}
If we wrap the second line in a coroutine to main just to delay it a cycle then the crash goes away, at least on our test device. We might roll out the fix to test it.
WorkManager.initialize(applicationContext, workManagerConfig)
WorkManager.getInstance().getWorkInfosByTagLiveData(DownloadManager.WORK_MANAGER_DOWNLOAD_TAG).observeForever {}
If we wrap the second line in a coroutine to main just to delay it a cycle then the crash goes away, at least on our test device. We might roll out the fix to test it.
ap...@google.com
Hi, I'm glad you have some reproducible steps. It would help us a lot if you could actually boil this down to a minimal sample app that can reproduce it so you can share it with us and we can also examine what is going wrong.
ap...@google.com
Done! This crashes for us on the second launch, you need a large amount queued jobs for it to happen. Testing on a Moto X 2014 victara running Android 6.0.
ap...@google.com
We managed to get a test device, and I can reproduce it.
I see this:
05-21 10:18:50.804 352 352 D SFPerfTracer: layers: (6:13) (FocusedStackFrame (0xb8370eb8): 0:108)* (DimLayer (0xb83412c0): 9:12) (StatusBar (0xb83bbf38): 0:701) (NavigationBar (0xb8389d10): 0:550) (com.android.systemui.ImageWallpaper (0xb83b23f8): 0:234) (DimLayer (0xb83989f0): 0:45)- (DimLayer (0xb83907e0): 0:8)- (com.example.workmanagercrash/com.example.workmanagercrash.MainActivity (0xb836c948): 0:31)- (com.android.systemui/com.android.systemui.recents.RecentsActivity (0xb838d188): 0:58)- (thumbnail anim (0xb834e7a0): 0:23)- (com.google.android.googlequicksearchbox/com.google.android.launcher.GEL (0xb834e7a0): 0:13) (Application Error: com.example.workmanagercrash (0xb83989f0): 8:14)
05-21 10:18:50.804 463 463 F DEBUG : *** *** *** *** *** *** *** *** *** *** *** *** *** *** *** ***
05-21 10:18:50.804 463 463 F DEBUG : Build fingerprint: 'motorola/victara_tmo/victara:6.0/MPES24.49-18-7/7:user/release-keys'
05-21 10:18:50.805 463 463 F DEBUG : Revision: 'p2bf'
05-21 10:18:50.805 463 463 F DEBUG : ABI: 'arm'
05-21 10:18:50.805 463 463 F DEBUG : pid: 9165, tid: 9180, name: WorkManager-Wor >>> com.example.workmanagercrash <<<
05-21 10:18:50.805 463 463 F DEBUG : signal 11 (SIGSEGV), code 1 (SEGV_MAPERR), fault addr 0x0
05-21 10:18:50.819 463 463 F DEBUG : r0 b9b04660 r1 af9ece50 r2 00000000 r3 00000002
05-21 10:18:50.819 463 463 F DEBUG : r4 b9b044b8 r5 b692e118 r6 00000000 r7 b9b04f08
05-21 10:18:50.819 463 463 F DEBUG : r8 00000001 r9 b9b044b8 sl 00000000 fp 00000002
05-21 10:18:50.819 463 463 F DEBUG : ip b692ddfc sp af9ece28 lr b6881e5b pc 00000000 cpsr 200f0010
05-21 10:18:50.823 463 463 F DEBUG :
05-21 10:18:50.823 463 463 F DEBUG : backtrace:
05-21 10:18:50.824 463 463 F DEBUG : #00 pc 00000000 <unknown>
05-21 10:18:50.824 463 463 F DEBUG : #01 pc 00024e59 /system/lib/libsqlite.so
05-21 10:18:50.824 463 463 F DEBUG : #02 pc 00024173 /system/lib/libsqlite.so
05-21 10:18:50.824 463 463 F DEBUG : #03 pc 0000e759 /system/lib/libsqlite.so
05-21 10:18:50.824 463 463 F DEBUG : #04 pc 0002be41 /system/lib/libsqlite.so
05-21 10:18:50.824 463 463 F DEBUG : #05 pc 00039ad7 /system/lib/libsqlite.so
05-21 10:18:50.824 463 463 F DEBUG : #06 pc 0000ffc5 /system/lib/libsqlite.so (sqlite3_step+724)
05-21 10:18:50.824 463 463 F DEBUG : #07 pc 00075021 /system/lib/libandroid_runtime.so
05-21 10:18:50.824 463 463 F DEBUG : #08 pc 02287663 /system/framework/arm/boot.oat (offset 0x1fda000)
05-21 10:18:51.062 1769 2069 V AlarmManager: sending alarm {f6ba791 type 3 *alarm*:android.content.jobscheduler.JOB_DELAY_EXPIRED}
05-21 10:18:51.065 1769 1769 V AlarmManager: done {f6ba791, *alarm*:android.content.jobscheduler.JOB_DELAY_EXPIRED} [3ms]
05-21 10:18:51.131 463 463 F DEBUG :
05-21 10:18:51.131 463 463 F DEBUG : Tombstone written to: /data/tombstones/tombstone_01
05-21 10:18:51.131 463 463 E DEBUG : AM write failed: Broken pipe
05-21 10:18:51.133 1769 1786 I BootReceiver: Copying /data/tombstones/tombstone_01 to DropBox (SYSTEM_TOMBSTONE)
05-21 10:18:51.184 485 485 I Zygote : Process 9165 exited due to signal (11)
05-21 10:18:51.214 1769 2729 I ActivityManager: Process com.example.workmanagercrash (pid 9165) has died
05-21 10:18:51.215 1769 2729 W ActivityManager: Scheduling restart of crashed service com.example.workmanagercrash/androidx.work.impl.background.systemjob.SystemJobService in 1000ms
05-21 10:18:51.238 1769 1769 I ActivityManager: Start proc 9188:com.example.workmanagercrash/u0a106 for service com.example.workmanagercrash/androidx.work.impl.background.systemjob.SystemJobService
05-21 10:18:51.256 9188 9188 I art : Late-enabling -Xcheck:jni
05-21 10:18:51.301 9188 9188 W System : ClassLoader referenced unknown path: /data/app/com.example.workmanagercrash-1/lib/arm
05-21 10:18:51.476 9188 9202 F libc : Fatal signal 11 (SIGSEGV), code 1, fault addr 0x0 in tid 9202 (WorkManager-Wor)
05-21 10:18:51.578 463 463 F DEBUG : *** *** *** *** *** *** *** *** *** *** *** *** *** *** *** ***
05-21 10:18:51.578 463 463 F DEBUG : Build fingerprint: 'motorola/victara_tmo/victara:6.0/MPES24.49-18-7/7:user/release-keys'
05-21 10:18:51.579 463 463 F DEBUG : Revision: 'p2bf'
05-21 10:18:51.579 463 463 F DEBUG : ABI: 'arm'
05-21 10:18:51.579 463 463 F DEBUG : pid: 9188, tid: 9202, name: WorkManager-Wor >>> com.example.workmanagercrash <<<
05-21 10:18:51.580 463 463 F DEBUG : signal 11 (SIGSEGV), code 1 (SEGV_MAPERR), fault addr 0x0
05-21 10:18:51.609 463 463 F DEBUG : r0 b9b048c0 r1 af9ece50 r2 00000000 r3 00000002
05-21 10:18:51.609 463 463 F DEBUG : r4 b9b04718 r5 b692e118 r6 00000000 r7 b9b05170
05-21 10:18:51.609 463 463 F DEBUG : r8 00000001 r9 b9b04718 sl 00000000 fp 00000002
05-21 10:18:51.609 463 463 F DEBUG : ip b692ddfc sp af9ece28 lr b6881e5b pc 00000000 cpsr 200f0010
05-21 10:18:51.615 463 463 F DEBUG :
05-21 10:18:51.615 463 463 F DEBUG : backtrace:
05-21 10:18:51.616 463 463 F DEBUG : #00 pc 00000000 <unknown>
05-21 10:18:51.616 463 463 F DEBUG : #01 pc 00024e59 /system/lib/libsqlite.so
05-21 10:18:51.616 463 463 F DEBUG : #02 pc 00024173 /system/lib/libsqlite.so
05-21 10:18:51.616 463 463 F DEBUG : #03 pc 0000e759 /system/lib/libsqlite.so
05-21 10:18:51.616 463 463 F DEBUG : #04 pc 0002be41 /system/lib/libsqlite.so
05-21 10:18:51.616 463 463 F DEBUG : #05 pc 00039ad7 /system/lib/libsqlite.so
05-21 10:18:51.616 463 463 F DEBUG : #06 pc 0000ffc5 /system/lib/libsqlite.so (sqlite3_step+724)
05-21 10:18:51.616 463 463 F DEBUG : #07 pc 00075021 /system/lib/libandroid_runtime.so
05-21 10:18:51.616 463 463 F DEBUG : #08 pc 02287663 /system/framework/arm/boot.oat (offset 0x1fda000)
05-21 10:18:51.902 463 463 F DEBUG :
05-21 10:18:51.902 463 463 F DEBUG : Tombstone written to: /data/tombstones/tombstone_02
05-21 10:18:51.902 463 463 E DEBUG : AM write failed: Broken pipe
05-21 10:18:51.903 1769 1786 I BootReceiver: Copying /data/tombstones/tombstone_02 to DropBox (SYSTEM_TOMBSTONE)
05-21 10:18:51.952 485 485 I Zygote : Process 9188 exited due to signal (11)
05-21 10:18:51.966 1769 2757 I ActivityManager: Process com.example.workmanagercrash (pid 9188) has died
I see this:
05-21 10:18:50.804 352 352 D SFPerfTracer: layers: (6:13) (FocusedStackFrame (0xb8370eb8): 0:108)* (DimLayer (0xb83412c0): 9:12) (StatusBar (0xb83bbf38): 0:701) (NavigationBar (0xb8389d10): 0:550) (com.android.systemui.ImageWallpaper (0xb83b23f8): 0:234) (DimLayer (0xb83989f0): 0:45)- (DimLayer (0xb83907e0): 0:8)- (com.example.workmanagercrash/com.example.workmanagercrash.MainActivity (0xb836c948): 0:31)- (com.android.systemui/com.android.systemui.recents.RecentsActivity (0xb838d188): 0:58)- (thumbnail anim (0xb834e7a0): 0:23)- (com.google.android.googlequicksearchbox/com.google.android.launcher.GEL (0xb834e7a0): 0:13) (Application Error: com.example.workmanagercrash (0xb83989f0): 8:14)
05-21 10:18:50.804 463 463 F DEBUG : *** *** *** *** *** *** *** *** *** *** *** *** *** *** *** ***
05-21 10:18:50.804 463 463 F DEBUG : Build fingerprint: 'motorola/victara_tmo/victara:6.0/MPES24.49-18-7/7:user/release-keys'
05-21 10:18:50.805 463 463 F DEBUG : Revision: 'p2bf'
05-21 10:18:50.805 463 463 F DEBUG : ABI: 'arm'
05-21 10:18:50.805 463 463 F DEBUG : pid: 9165, tid: 9180, name: WorkManager-Wor >>> com.example.workmanagercrash <<<
05-21 10:18:50.805 463 463 F DEBUG : signal 11 (SIGSEGV), code 1 (SEGV_MAPERR), fault addr 0x0
05-21 10:18:50.819 463 463 F DEBUG : r0 b9b04660 r1 af9ece50 r2 00000000 r3 00000002
05-21 10:18:50.819 463 463 F DEBUG : r4 b9b044b8 r5 b692e118 r6 00000000 r7 b9b04f08
05-21 10:18:50.819 463 463 F DEBUG : r8 00000001 r9 b9b044b8 sl 00000000 fp 00000002
05-21 10:18:50.819 463 463 F DEBUG : ip b692ddfc sp af9ece28 lr b6881e5b pc 00000000 cpsr 200f0010
05-21 10:18:50.823 463 463 F DEBUG :
05-21 10:18:50.823 463 463 F DEBUG : backtrace:
05-21 10:18:50.824 463 463 F DEBUG : #00 pc 00000000 <unknown>
05-21 10:18:50.824 463 463 F DEBUG : #01 pc 00024e59 /system/lib/libsqlite.so
05-21 10:18:50.824 463 463 F DEBUG : #02 pc 00024173 /system/lib/libsqlite.so
05-21 10:18:50.824 463 463 F DEBUG : #03 pc 0000e759 /system/lib/libsqlite.so
05-21 10:18:50.824 463 463 F DEBUG : #04 pc 0002be41 /system/lib/libsqlite.so
05-21 10:18:50.824 463 463 F DEBUG : #05 pc 00039ad7 /system/lib/libsqlite.so
05-21 10:18:50.824 463 463 F DEBUG : #06 pc 0000ffc5 /system/lib/libsqlite.so (sqlite3_step+724)
05-21 10:18:50.824 463 463 F DEBUG : #07 pc 00075021 /system/lib/libandroid_runtime.so
05-21 10:18:50.824 463 463 F DEBUG : #08 pc 02287663 /system/framework/arm/boot.oat (offset 0x1fda000)
05-21 10:18:51.062 1769 2069 V AlarmManager: sending alarm {f6ba791 type 3 *alarm*:android.content.jobscheduler.JOB_DELAY_EXPIRED}
05-21 10:18:51.065 1769 1769 V AlarmManager: done {f6ba791, *alarm*:android.content.jobscheduler.JOB_DELAY_EXPIRED} [3ms]
05-21 10:18:51.131 463 463 F DEBUG :
05-21 10:18:51.131 463 463 F DEBUG : Tombstone written to: /data/tombstones/tombstone_01
05-21 10:18:51.131 463 463 E DEBUG : AM write failed: Broken pipe
05-21 10:18:51.133 1769 1786 I BootReceiver: Copying /data/tombstones/tombstone_01 to DropBox (SYSTEM_TOMBSTONE)
05-21 10:18:51.184 485 485 I Zygote : Process 9165 exited due to signal (11)
05-21 10:18:51.214 1769 2729 I ActivityManager: Process com.example.workmanagercrash (pid 9165) has died
05-21 10:18:51.215 1769 2729 W ActivityManager: Scheduling restart of crashed service com.example.workmanagercrash/androidx.work.impl.background.systemjob.SystemJobService in 1000ms
05-21 10:18:51.238 1769 1769 I ActivityManager: Start proc 9188:com.example.workmanagercrash/u0a106 for service com.example.workmanagercrash/androidx.work.impl.background.systemjob.SystemJobService
05-21 10:18:51.256 9188 9188 I art : Late-enabling -Xcheck:jni
05-21 10:18:51.301 9188 9188 W System : ClassLoader referenced unknown path: /data/app/com.example.workmanagercrash-1/lib/arm
05-21 10:18:51.476 9188 9202 F libc : Fatal signal 11 (SIGSEGV), code 1, fault addr 0x0 in tid 9202 (WorkManager-Wor)
05-21 10:18:51.578 463 463 F DEBUG : *** *** *** *** *** *** *** *** *** *** *** *** *** *** *** ***
05-21 10:18:51.578 463 463 F DEBUG : Build fingerprint: 'motorola/victara_tmo/victara:6.0/MPES24.49-18-7/7:user/release-keys'
05-21 10:18:51.579 463 463 F DEBUG : Revision: 'p2bf'
05-21 10:18:51.579 463 463 F DEBUG : ABI: 'arm'
05-21 10:18:51.579 463 463 F DEBUG : pid: 9188, tid: 9202, name: WorkManager-Wor >>> com.example.workmanagercrash <<<
05-21 10:18:51.580 463 463 F DEBUG : signal 11 (SIGSEGV), code 1 (SEGV_MAPERR), fault addr 0x0
05-21 10:18:51.609 463 463 F DEBUG : r0 b9b048c0 r1 af9ece50 r2 00000000 r3 00000002
05-21 10:18:51.609 463 463 F DEBUG : r4 b9b04718 r5 b692e118 r6 00000000 r7 b9b05170
05-21 10:18:51.609 463 463 F DEBUG : r8 00000001 r9 b9b04718 sl 00000000 fp 00000002
05-21 10:18:51.609 463 463 F DEBUG : ip b692ddfc sp af9ece28 lr b6881e5b pc 00000000 cpsr 200f0010
05-21 10:18:51.615 463 463 F DEBUG :
05-21 10:18:51.615 463 463 F DEBUG : backtrace:
05-21 10:18:51.616 463 463 F DEBUG : #00 pc 00000000 <unknown>
05-21 10:18:51.616 463 463 F DEBUG : #01 pc 00024e59 /system/lib/libsqlite.so
05-21 10:18:51.616 463 463 F DEBUG : #02 pc 00024173 /system/lib/libsqlite.so
05-21 10:18:51.616 463 463 F DEBUG : #03 pc 0000e759 /system/lib/libsqlite.so
05-21 10:18:51.616 463 463 F DEBUG : #04 pc 0002be41 /system/lib/libsqlite.so
05-21 10:18:51.616 463 463 F DEBUG : #05 pc 00039ad7 /system/lib/libsqlite.so
05-21 10:18:51.616 463 463 F DEBUG : #06 pc 0000ffc5 /system/lib/libsqlite.so (sqlite3_step+724)
05-21 10:18:51.616 463 463 F DEBUG : #07 pc 00075021 /system/lib/libandroid_runtime.so
05-21 10:18:51.616 463 463 F DEBUG : #08 pc 02287663 /system/framework/arm/boot.oat (offset 0x1fda000)
05-21 10:18:51.902 463 463 F DEBUG :
05-21 10:18:51.902 463 463 F DEBUG : Tombstone written to: /data/tombstones/tombstone_02
05-21 10:18:51.902 463 463 E DEBUG : AM write failed: Broken pipe
05-21 10:18:51.903 1769 1786 I BootReceiver: Copying /data/tombstones/tombstone_02 to DropBox (SYSTEM_TOMBSTONE)
05-21 10:18:51.952 485 485 I Zygote : Process 9188 exited due to signal (11)
05-21 10:18:51.966 1769 2757 I ActivityManager: Process com.example.workmanagercrash (pid 9188) has died
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 957adb282e41c2662fff6221325e6b51cd7377f9
Author: Rahul Ravikumar <rahulrav@google.com>
Date: Tue May 21 14:37:00 2019
Fixes SQLite issues on some devices.
* Always beginTransaction() outside a try.
* Make sure SystemJobScheduler marks transactions as successful.
Test: Existing tests pass.
Fixes:
Change-Id: I55092537781fbfee97f4336eb7cf1a49e647d62a
M work/workmanager-gcm/src/main/java/androidx/work/impl/background/gcm/WorkManagerGcmDispatcher.java
M work/workmanager/src/main/java/androidx/work/impl/WorkerWrapper.java
M work/workmanager/src/main/java/androidx/work/impl/background/systemjob/SystemJobScheduler.java
M work/workmanager/src/main/java/androidx/work/impl/utils/ForceStopRunnable.java
https://android-review.googlesource.com/966057
https://goto.google.com/android-sha1/957adb282e41c2662fff6221325e6b51cd7377f9
Branch: androidx-master-dev
commit 957adb282e41c2662fff6221325e6b51cd7377f9
Author: Rahul Ravikumar <rahulrav@google.com>
Date: Tue May 21 14:37:00 2019
Fixes SQLite issues on some devices.
* Always beginTransaction() outside a try.
* Make sure SystemJobScheduler marks transactions as successful.
Test: Existing tests pass.
Fixes:
Change-Id: I55092537781fbfee97f4336eb7cf1a49e647d62a
M work/workmanager-gcm/src/main/java/androidx/work/impl/background/gcm/WorkManagerGcmDispatcher.java
M work/workmanager/src/main/java/androidx/work/impl/WorkerWrapper.java
M work/workmanager/src/main/java/androidx/work/impl/background/systemjob/SystemJobScheduler.java
M work/workmanager/src/main/java/androidx/work/impl/utils/ForceStopRunnable.java
ap...@google.com
Will it be fixed in a maintainance release of 2.0, or will we have to wait for 2.1 next RC or release?
ap...@google.com
This will show up in the next 2.1.0 release.
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 07cc34f9a88067c26634a575587cfe55132360c4
Author: Ian Lake <ilake@google.com>
Date: Wed Dec 11 11:06:26 2019
Use FragmentStateManager for <fragment> tag
Use FragmentStateManager's moveToExpectedState
for the <fragment> tag instead of relying on
FragmentManager's moveToState.
Test: existing tests pass
BUG: 139536619
Change-Id: I77778b3d7e634a4ea7c9d228819a9f2936e347f1
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentLayoutInflaterFactory.java
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentStateManager.java
https://android-review.googlesource.com/1186776
Branch: androidx-master-dev
commit 07cc34f9a88067c26634a575587cfe55132360c4
Author: Ian Lake <ilake@google.com>
Date: Wed Dec 11 11:06:26 2019
Use FragmentStateManager for <fragment> tag
Use FragmentStateManager's moveToExpectedState
for the <fragment> tag instead of relying on
FragmentManager's moveToState.
Test: existing tests pass
BUG: 139536619
Change-Id: I77778b3d7e634a4ea7c9d228819a9f2936e347f1
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentLayoutInflaterFactory.java
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentStateManager.java
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 3eb8650f005697c8a036605bf5170b9d8177b761
Author: Ian Lake <ilake@google.com>
Date: Thu Dec 12 13:48:29 2019
Remove getStateAfterAnimating()
FragmentStateManager already knows what the
correct state should be so we don't need to
track it separately with setStateAfterAnimating()
and getStateAfterAnimating().
Test: all existing tests pass
BUG: 139536619
Change-Id: I5d48edbf47aca4f57fda0553cf767dfbfc21d642
M fragment/fragment/src/main/java/androidx/fragment/app/Fragment.java
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentManager.java
https://android-review.googlesource.com/1188453
Branch: androidx-master-dev
commit 3eb8650f005697c8a036605bf5170b9d8177b761
Author: Ian Lake <ilake@google.com>
Date: Thu Dec 12 13:48:29 2019
Remove getStateAfterAnimating()
FragmentStateManager already knows what the
correct state should be so we don't need to
track it separately with setStateAfterAnimating()
and getStateAfterAnimating().
Test: all existing tests pass
BUG: 139536619
Change-Id: I5d48edbf47aca4f57fda0553cf767dfbfc21d642
M fragment/fragment/src/main/java/androidx/fragment/app/Fragment.java
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentManager.java
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit fb4893d9baba2f759a3ebba61f228a48e11fd72c
Author: Ian Lake <ilake@google.com>
Date: Thu Dec 12 14:08:08 2019
Simplify moveToState logic for FragmentTransition
FragmentTransition's moveToState() logic only
applies to newly added Fragments, so we can simplify
the logic used to rely on computeExpectedState().
Test: existing tests pass
BUG: 139536619
Change-Id: I1568791a7aaa3a8a3dfb14a75fa121a32884e443
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentTransition.java
https://android-review.googlesource.com/1188455
Branch: androidx-master-dev
commit fb4893d9baba2f759a3ebba61f228a48e11fd72c
Author: Ian Lake <ilake@google.com>
Date: Thu Dec 12 14:08:08 2019
Simplify moveToState logic for FragmentTransition
FragmentTransition's moveToState() logic only
applies to newly added Fragments, so we can simplify
the logic used to rely on computeExpectedState().
Test: existing tests pass
BUG: 139536619
Change-Id: I1568791a7aaa3a8a3dfb14a75fa121a32884e443
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentTransition.java
an...@google.com
The following changes were cherrypicked through Coastguard (https://android-build.googleplex.com/coastguard/ )
Release Track: (https://android-build.googleplex.com/coastguard/dashboard/6552735953321984/#/history/all )
Created: 2019-12-18 21:08:39.436017+00:00
Changes: aosp/1178750, aosp/1171290, aosp/1170093
Release Track: (
Created: 2019-12-18 21:08:39.436017+00:00
Changes: aosp/1178750, aosp/1171290, aosp/1170093
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 3e885783ef9bf3d7717cc55ae4ccf857d74965f8
Author: Ian Lake <ilake@google.com>
Date: Tue Feb 18 15:29:20 2020
Handle re-entrant calls to moveToExpectedState()
As moveToExpectedState() runs user code that can
potentially change the external state, it is possible
for re-entrant calls to moveToExpectedState() to
happen. In this case, we can ignore the re-entrant
call, knowing that after the current state transition
completes FragmentStateManager will call
computeExpectedState() after each transition and pick
up the updated state.
Test: this isn't technically possible yet, but it will be
BUG: 139536619
Change-Id: I500e6f0e78d20355ab21a1f21fc66067f72e46a9
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentStateManager.java
https://android-review.googlesource.com/1238927
Branch: androidx-master-dev
commit 3e885783ef9bf3d7717cc55ae4ccf857d74965f8
Author: Ian Lake <ilake@google.com>
Date: Tue Feb 18 15:29:20 2020
Handle re-entrant calls to moveToExpectedState()
As moveToExpectedState() runs user code that can
potentially change the external state, it is possible
for re-entrant calls to moveToExpectedState() to
happen. In this case, we can ignore the re-entrant
call, knowing that after the current state transition
completes FragmentStateManager will call
computeExpectedState() after each transition and pick
up the updated state.
Test: this isn't technically possible yet, but it will be
BUG: 139536619
Change-Id: I500e6f0e78d20355ab21a1f21fc66067f72e46a9
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentStateManager.java
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 4d3bac24c5a77c5ab5624795afa709b3f265bf74
Author: Ian Lake <ilake@google.com>
Date: Tue Feb 25 15:47:06 2020
Add infrastructure to fully switch to FragmentStateManager
Add the initial logic to fully replace all usages of
moveToState() with FragmentStateManager and its
moveToExpectedState().
Enabling this flag currently causes many tests to fail
(due to work not being completed on
this infrastructure will allow us to confirm our fixes
are actually applied while iterating through those
outstanding issues.
Test: tests all pass with USE_STATE_MANAGER = false
BUG: 139536619
Change-Id: I84340091ce1b0bcc3e26051e25a12d7b38b860c4
M fragment/fragment/src/main/java/androidx/fragment/app/BackStackRecord.java
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentManager.java
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentStore.java
https://android-review.googlesource.com/1243715
Branch: androidx-master-dev
commit 4d3bac24c5a77c5ab5624795afa709b3f265bf74
Author: Ian Lake <ilake@google.com>
Date: Tue Feb 25 15:47:06 2020
Add infrastructure to fully switch to FragmentStateManager
Add the initial logic to fully replace all usages of
moveToState() with FragmentStateManager and its
moveToExpectedState().
Enabling this flag currently causes many tests to fail
(due to work not being completed on
this infrastructure will allow us to confirm our fixes
are actually applied while iterating through those
outstanding issues.
Test: tests all pass with USE_STATE_MANAGER = false
BUG: 139536619
Change-Id: I84340091ce1b0bcc3e26051e25a12d7b38b860c4
M fragment/fragment/src/main/java/androidx/fragment/app/BackStackRecord.java
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentManager.java
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentStore.java
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit b58d84209a566d60dbec35670fd3d977adcea1cf
Author: Ian Lake <ilake@google.com>
Date: Wed Feb 26 16:11:21 2020
Stop using findFragmentManager in SpecialEffectsController
Instead of relying on findFragmentManager() in
SpecialEffectsController, pass the FragmentManager
in directly. This works around issues where developers
nest fragments without using the childFragmentManager.
findFragmentManager() now correctly throws in those
cases.
Test: new tests pass
Test: SpecialEffectsController tests pass with USE_STATE_MANAGER = true
BUG: 139536619
Change-Id: I7de94fa6275fe8a5e67736194d7fc099539dd395
M fragment/fragment/src/androidTest/java/androidx/fragment/app/DefaultSpecialEffectsControllerTest.kt
A fragment/fragment/src/androidTest/java/androidx/fragment/app/FragmentManagerTest.kt
M fragment/fragment/src/androidTest/java/androidx/fragment/app/SpecialEffectsControllerTest.kt
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentManager.java
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentStateManager.java
M fragment/fragment/src/main/java/androidx/fragment/app/SpecialEffectsController.java
https://android-review.googlesource.com/1244918
Branch: androidx-master-dev
commit b58d84209a566d60dbec35670fd3d977adcea1cf
Author: Ian Lake <ilake@google.com>
Date: Wed Feb 26 16:11:21 2020
Stop using findFragmentManager in SpecialEffectsController
Instead of relying on findFragmentManager() in
SpecialEffectsController, pass the FragmentManager
in directly. This works around issues where developers
nest fragments without using the childFragmentManager.
findFragmentManager() now correctly throws in those
cases.
Test: new tests pass
Test: SpecialEffectsController tests pass with USE_STATE_MANAGER = true
BUG: 139536619
Change-Id: I7de94fa6275fe8a5e67736194d7fc099539dd395
M fragment/fragment/src/androidTest/java/androidx/fragment/app/DefaultSpecialEffectsControllerTest.kt
A fragment/fragment/src/androidTest/java/androidx/fragment/app/FragmentManagerTest.kt
M fragment/fragment/src/androidTest/java/androidx/fragment/app/SpecialEffectsControllerTest.kt
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentManager.java
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentStateManager.java
M fragment/fragment/src/main/java/androidx/fragment/app/SpecialEffectsController.java
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit c643f98908f3d5ee5f48b37e3edcc113a16a6bbc
Author: Ian Lake <ilake@google.com>
Date: Mon Mar 02 09:54:45 2020
Move makeInactive() out of moveToState()
Instead of calling makeInactive() as part
of moveToState() / moveToExpectedState(),
run that logic *after* the state settles.
Updating the target fragments correctly can
then be moved solely to FragmentStateManager's
destroy(), ensure it runs at the right time.
Special care had to be made when restoring
retained fragments that aren't in mActive so
that they are manually removed from the mNonConfig
(as before that would have been take care of
by moveToExpectedState()).
Test: all existing tests pass
BUG: 139536619
Change-Id: Ie33e01622f5edf212822f9c75f60c532a352a2d1
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentManager.java
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentStateManager.java
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentStore.java
https://android-review.googlesource.com/1247791
Branch: androidx-master-dev
commit c643f98908f3d5ee5f48b37e3edcc113a16a6bbc
Author: Ian Lake <ilake@google.com>
Date: Mon Mar 02 09:54:45 2020
Move makeInactive() out of moveToState()
Instead of calling makeInactive() as part
of moveToState() / moveToExpectedState(),
run that logic *after* the state settles.
Updating the target fragments correctly can
then be moved solely to FragmentStateManager's
destroy(), ensure it runs at the right time.
Special care had to be made when restoring
retained fragments that aren't in mActive so
that they are manually removed from the mNonConfig
(as before that would have been take care of
by moveToExpectedState()).
Test: all existing tests pass
BUG: 139536619
Change-Id: Ie33e01622f5edf212822f9c75f60c532a352a2d1
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentManager.java
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentStateManager.java
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentStore.java
fi...@google.com
ilake@, when can we resolve this issue? Thanks
il...@google.com
Re #41 - as soon as the
fi...@google.com
Hi Ian,
Is this fixed?
Thanks,
Fiona
Is this fixed?
Thanks,
Fiona
il...@google.com
See
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit a719fba6b63d6081e7b69de1a70e2d1e81bf52bf
Author: Ian Lake <ilake@google.com>
Date: Fri Jul 17 15:06:39 2020
Add experimental API for enabling FragmentStateManager
Provide an experimental API for controlling whether
the FragmentStateManager and new special effects system
should be enabled.
Currently this new system defaults to off, but will
be changed to true by default once all internal tests
pass. This API will then exist only to verify that
a regression is due to the new code path.
Test: tested in a sample app
BUG: 147749580
BUG: 139536619
Relnote: "Added a new *experimental* API for controlling
whether FragmentManager uses the new internal state
manager for controlling dispatching lifecycle methods,
animations and transitions, and handling postponed
transactions."
Change-Id: I7b6ee13ea89f3989beafe7c474455e8a04e929a3
M fragment/fragment/api/public_plus_experimental_1.3.0-alpha07.txt
M fragment/fragment/api/public_plus_experimental_current.txt
M fragment/fragment/build.gradle
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentManager.java
A fragment/fragment/src/main/java/androidx/fragment/app/FragmentStateManagerControl.java
https://android-review.googlesource.com/1367016
Branch: androidx-master-dev
commit a719fba6b63d6081e7b69de1a70e2d1e81bf52bf
Author: Ian Lake <ilake@google.com>
Date: Fri Jul 17 15:06:39 2020
Add experimental API for enabling FragmentStateManager
Provide an experimental API for controlling whether
the FragmentStateManager and new special effects system
should be enabled.
Currently this new system defaults to off, but will
be changed to true by default once all internal tests
pass. This API will then exist only to verify that
a regression is due to the new code path.
Test: tested in a sample app
BUG: 147749580
BUG: 139536619
Relnote: "Added a new *experimental* API for controlling
whether FragmentManager uses the new internal state
manager for controlling dispatching lifecycle methods,
animations and transitions, and handling postponed
transactions."
Change-Id: I7b6ee13ea89f3989beafe7c474455e8a04e929a3
M fragment/fragment/api/public_plus_experimental_1.3.0-alpha07.txt
M fragment/fragment/api/public_plus_experimental_current.txt
M fragment/fragment/build.gradle
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentManager.java
A fragment/fragment/src/main/java/androidx/fragment/app/FragmentStateManagerControl.java
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit c4e66e2a8b86db77158d21527b6eceb27290097b
Author: Ian Lake <ilake@google.com>
Date: Fri Jul 31 22:43:47 2020
Change reordering parameter from boolean to sealed class
Instead of using a boolean reorderingAllowed
parameter that only shows as 0 or 1 in test naming,
convert it to using a sealed class that makes it
more clear which type of ordering is being used.
Test: tests still pass
BUG: 139536619
Change-Id: I3e7f433d20b13f7bb5882b85d67a0c8267fd4da4
M fragment/fragment/src/androidTest/java/androidx/fragment/app/FragmentTestUtil.kt
M fragment/fragment/src/androidTest/java/androidx/fragment/app/FragmentTransitionAnimTest.kt
M fragment/fragment/src/androidTest/java/androidx/fragment/app/FragmentTransitionTest.kt
M transition/transition/src/androidTest/java/androidx/transition/FragmentTestUtil.kt
M transition/transition/src/androidTest/java/androidx/transition/FragmentTransitionTest.kt
https://android-review.googlesource.com/1384636
Branch: androidx-master-dev
commit c4e66e2a8b86db77158d21527b6eceb27290097b
Author: Ian Lake <ilake@google.com>
Date: Fri Jul 31 22:43:47 2020
Change reordering parameter from boolean to sealed class
Instead of using a boolean reorderingAllowed
parameter that only shows as 0 or 1 in test naming,
convert it to using a sealed class that makes it
more clear which type of ordering is being used.
Test: tests still pass
BUG: 139536619
Change-Id: I3e7f433d20b13f7bb5882b85d67a0c8267fd4da4
M fragment/fragment/src/androidTest/java/androidx/fragment/app/FragmentTestUtil.kt
M fragment/fragment/src/androidTest/java/androidx/fragment/app/FragmentTransitionAnimTest.kt
M fragment/fragment/src/androidTest/java/androidx/fragment/app/FragmentTransitionTest.kt
M transition/transition/src/androidTest/java/androidx/transition/FragmentTestUtil.kt
M transition/transition/src/androidTest/java/androidx/transition/FragmentTransitionTest.kt
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 67ea65bcb2190d8be41e8896ab7b2fbd67c6f56b
Author: Ian Lake <ilake@google.com>
Date: Sun Aug 02 11:33:37 2020
Parameterize tests to use both old and new state manager
Parameterize a number of test suites affected
by the usage of FragmentStateManager so that they
run both under the old state manager and the new
system to avoid regressions during the cross over
time period.
Changed the focusedView() test to not run on the
UI thread, fixing flaky issues when running as part
of a parameterized test suite.
Changed the testTimedPostponeEnterPostponedCalledWithZero()
test to wait for the transition to finish before
finishing the test, ensuring that you don't
enable/disable the state manager while a
transition is running.
Test: tests pass
BUG: 139536619
Change-Id: I1e7bd6f5b135345a9a60c95fe5127b00ff3e69df
M fragment/fragment/src/androidTest/java/androidx/fragment/app/FragmentReorderingTest.kt
M fragment/fragment/src/androidTest/java/androidx/fragment/app/FragmentTestUtil.kt
M fragment/fragment/src/androidTest/java/androidx/fragment/app/FragmentTransitionAnimTest.kt
M fragment/fragment/src/androidTest/java/androidx/fragment/app/FragmentTransitionTest.kt
M fragment/fragment/src/androidTest/java/androidx/fragment/app/PostponedTransitionTest.kt
https://android-review.googlesource.com/1385513
Branch: androidx-master-dev
commit 67ea65bcb2190d8be41e8896ab7b2fbd67c6f56b
Author: Ian Lake <ilake@google.com>
Date: Sun Aug 02 11:33:37 2020
Parameterize tests to use both old and new state manager
Parameterize a number of test suites affected
by the usage of FragmentStateManager so that they
run both under the old state manager and the new
system to avoid regressions during the cross over
time period.
Changed the focusedView() test to not run on the
UI thread, fixing flaky issues when running as part
of a parameterized test suite.
Changed the testTimedPostponeEnterPostponedCalledWithZero()
test to wait for the transition to finish before
finishing the test, ensuring that you don't
enable/disable the state manager while a
transition is running.
Test: tests pass
BUG: 139536619
Change-Id: I1e7bd6f5b135345a9a60c95fe5127b00ff3e69df
M fragment/fragment/src/androidTest/java/androidx/fragment/app/FragmentReorderingTest.kt
M fragment/fragment/src/androidTest/java/androidx/fragment/app/FragmentTestUtil.kt
M fragment/fragment/src/androidTest/java/androidx/fragment/app/FragmentTransitionAnimTest.kt
M fragment/fragment/src/androidTest/java/androidx/fragment/app/FragmentTransitionTest.kt
M fragment/fragment/src/androidTest/java/androidx/fragment/app/PostponedTransitionTest.kt
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit c8263b1e1289276da1b691ac05b7a1808931101c
Author: Ian Lake <ilake@google.com>
Date: Sun Aug 02 11:51:07 2020
Mirror changes in FragmentTransitionTest to transition
Update the FragmentTransitionTest suite in the
transition module to match the updated code in the
fragment module, ensuring that the tests are
parameterized to run with both the old state manager
and the new state manager.
Test: tests still pass
BUG: 139536619
Change-Id: I8c8afac8e384e1f93a44b7d7e940de374c0b8494
M transition/transition/src/androidTest/java/androidx/transition/FragmentTestUtil.kt
M transition/transition/src/androidTest/java/androidx/transition/FragmentTransitionTest.kt
https://android-review.googlesource.com/1385514
Branch: androidx-master-dev
commit c8263b1e1289276da1b691ac05b7a1808931101c
Author: Ian Lake <ilake@google.com>
Date: Sun Aug 02 11:51:07 2020
Mirror changes in FragmentTransitionTest to transition
Update the FragmentTransitionTest suite in the
transition module to match the updated code in the
fragment module, ensuring that the tests are
parameterized to run with both the old state manager
and the new state manager.
Test: tests still pass
BUG: 139536619
Change-Id: I8c8afac8e384e1f93a44b7d7e940de374c0b8494
M transition/transition/src/androidTest/java/androidx/transition/FragmentTestUtil.kt
M transition/transition/src/androidTest/java/androidx/transition/FragmentTransitionTest.kt
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 8c6081e883569b5620f03d5d89648bf9b38289a9
Author: Ian Lake <ilake@google.com>
Date: Sun Aug 02 12:11:43 2020
Enable the new state manager by default
Add a note to FragmentManager.enableNewStateManager()
noting that the new state manager is enabled by default
and providing a link to the issue tracker to ensure
that developers know where to file any possible
regressions with the new state manager.
Test: all existing tests still pass
BUG: 139536619
Change-Id: I80d275cad0a2e0f4cc15c34820f63c71720e3f56
M fragment/fragment/src/androidTest/java/androidx/fragment/app/FragmentTestUtil.kt
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentManager.java
M transition/transition/src/androidTest/java/androidx/transition/FragmentTestUtil.kt
https://android-review.googlesource.com/1385479
Branch: androidx-master-dev
commit 8c6081e883569b5620f03d5d89648bf9b38289a9
Author: Ian Lake <ilake@google.com>
Date: Sun Aug 02 12:11:43 2020
Enable the new state manager by default
Add a note to FragmentManager.enableNewStateManager()
noting that the new state manager is enabled by default
and providing a link to the issue tracker to ensure
that developers know where to file any possible
regressions with the new state manager.
Test: all existing tests still pass
BUG: 139536619
Change-Id: I80d275cad0a2e0f4cc15c34820f63c71720e3f56
M fragment/fragment/src/androidTest/java/androidx/fragment/app/FragmentTestUtil.kt
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentManager.java
M transition/transition/src/androidTest/java/androidx/transition/FragmentTestUtil.kt
il...@google.com
All the work has completed with this effective complete rewrite of the internals of FragmentManager and how it handles animations and transitions. The new state manager is enabled by default for the Fragment 1.3.0-alpha08 release.
You can verify this by following the 6732061 and switching your fragment dependency to 1.3.0-SNAPSHOT.
We've filed FragmentManager.enableNewStateManager() experimental API. Please file any regressions found with the new system as soon as possible.
sa...@gmail.com
This seems to work (the returnTransition) with the new state manager
Description
This would allow us to very explicitly test all of the state transitions a Fragment goes through and would make it a lot easier to make further improvements / changes to those state transitions in a sustainable way.
This should have no effect to consumers of the Fragment API as it would all be internal work.