NPE in BiometricFragment [142599311]

Fixed

Bug

Status Update

No update yet.

Description

[Deleted User]

created issue #1

Oct 14, 2019 02:27AM

Artifact used: androidx.biometric:biometric
Version used: :1.0.0-beta02
Theme used: Theme.AppCompat
Devices/Android versions reproduced on: Pixel 3 XL

Crash logs:

Caused by java.lang.NullPointerException
Attempt to invoke virtual method 'boolean android.os.Bundle.getBoolean(java.lang.String, boolean)' on a null object reference
androidx.biometric.BiometricFragment.isDeviceCredentialAllowed (BiometricFragment.java:238)
androidx.biometric.BiometricPrompt$2.onPause (BiometricPrompt.java:505)
java.lang.reflect.Method.invoke (Method.java)
androidx.lifecycle.ClassesInfoCache$MethodReference.invokeCallback (ClassesInfoCache.java:216)
androidx.lifecycle.ClassesInfoCache$CallbackInfo.invokeMethodsForEvent (ClassesInfoCache.java:194)
androidx.lifecycle.ClassesInfoCache$CallbackInfo.invokeCallbacks (ClassesInfoCache.java:185)
androidx.lifecycle.ReflectiveGenericLifecycleObserver.onStateChanged (ReflectiveGenericLifecycleObserver.java:36)
androidx.lifecycle.LifecycleRegistry$ObserverWithState.dispatchEvent (LifecycleRegistry.java:361)
androidx.lifecycle.LifecycleRegistry.backwardPass (LifecycleRegistry.java:316)
androidx.lifecycle.LifecycleRegistry.sync (LifecycleRegistry.java:334)
androidx.lifecycle.LifecycleRegistry.moveToState (LifecycleRegistry.java:145)
androidx.lifecycle.LifecycleRegistry.handleLifecycleEvent (LifecycleRegistry.java:131)
androidx.lifecycle.ReportFragment.dispatch (ReportFragment.java:123)
androidx.lifecycle.ReportFragment.onPause (ReportFragment.java:96)
android.app.Fragment.performPause (Fragment.java:2735)
android.app.FragmentManagerImpl.moveToState (FragmentManagerImpl.java:1358)
android.app.FragmentManagerImpl.moveFragmentToExpectedState (FragmentManagerImpl.java:1581)
android.app.FragmentManagerImpl.moveToState (FragmentManagerImpl.java:1642)
android.app.FragmentManagerImpl.dispatchMoveToState (FragmentManagerImpl.java:3052)
android.app.FragmentManagerImpl.dispatchPause (FragmentManagerImpl.java:3018)
android.app.FragmentController.dispatchPause (FragmentController.java:217)
android.app.Activity.performPause (Activity.java:7976)
android.app.Instrumentation.callActivityOnPause (Instrumentation.java:1507)
android.app.ActivityThread.performPauseActivityIfNeeded (ActivityThread.java:4493)
android.app.ActivityThread.performPauseActivity (ActivityThread.java:4454)
android.app.ActivityThread.handlePauseActivity (ActivityThread.java:4406)
android.app.servertransaction.PauseActivityItem.execute (PauseActivityItem.java:46)
android.app.servertransaction.TransactionExecutor.executeLifecycleState (TransactionExecutor.java:176)
android.app.servertransaction.TransactionExecutor.execute (TransactionExecutor.java:97)
android.app.ActivityThread$H.handleMessage (ActivityThread.java:2016)
android.os.Handler.dispatchMessage (Handler.java:107)
android.os.Looper.loop (Looper.java:214)
android.app.ActivityThread.main (ActivityThread.java:7356)
java.lang.reflect.Method.invoke (Method.java)
com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run (RuntimeInit.java:492)
com.android.internal.os.ZygoteInit.main (ZygoteInit.java:930)

Comments

vi...@google.com <vi...@google.com> #2Oct 14, 2019 05:56AM

Assigned to vi...@google.com.

what is in update.zip ? can you share that file to triage this issue

do...@gmail.com <do...@gmail.com> #3Oct 15, 2019 11:35PM

MHC19Q for Nexus 5X (bullhead) -

https://dl.google.com/dl/android/aosp//bullhead-ota-mhc19q-8fe67a2b.zip
N4F26T for Nexus 5X (bullhead) -

https://dl.google.com/dl/android/aosp/bullhead-ota-n4f26t-648ce802.zip
WW-12.2.5.23 for Asus ZenFone Go (ASUS_X014D) -

http://dlcdnet.asus.com/pub/ASUS/ZenFone/ZB452KG/UL-ASUS_X014D-WW-12.2.5.23-user.zip

Look like, this happens only with a big images.

vi...@google.com <vi...@google.com> Nov 4, 2019 10:14AM

Reassigned to kc...@google.com.

kc...@google.com <kc...@google.com> Nov 4, 2019 07:11PM

Reassigned to cu...@google.com.

cu...@google.com <cu...@google.com> Nov 6, 2019 06:05PM

Accepted by cu...@google.com.

ap...@google.com <ap...@google.com> #4Nov 6, 2019 08:59PM

Marked as fixed.

On Windows 10 (x64)

an...@google.com <an...@google.com> #5Nov 26, 2019 06:07PM

related to (and probably worked around for now by) internal bug

http://b/36046324

i do think we should also start shipping a 64-bit Windows platform tools package.

we should also consider changing android::base::ReadFdToString to call fstat and pre-size the vector. not worthwhile for reading things like /proc/uptime, but the default expansion behavior for a huge file like a full OTA update is going to result in substantial overhead. (which will explain the regression between .3 and .4, since the former will have allocated exactly the necessary number of bytes.)

lastly (and maybe not worth doing at all, depending on how soon we can get folks to use a 64-bit platform tools on Windows, since all the other platforms are already 64-bit-only), we could consider rewriting the adb sideload code to (a) mmap/munmap rather than actually read in to physical memory or (b) pread. i'm not sure what the performance impact of pread would be (especially on Windows where there is no pread equivalent).