Potential for transparent activity leak with setDeviceCredentialAllowed [143091227]

Fixed

Bug

[AOSP] assigned

Status Update

No update yet.

Description

ma...@gmail.com

created issue #1

Oct 22, 2019 05:58PM

Running on Samsung A50 Android 9 or Emulator Nexus 5X API 27

Android Studio 3.5.1
compileSdkVersion 29
minSdkVersion 21
targetSdkVersion 29

def biometric_version = "1.0.0-rc01"
implementation "androidx.biometric:biometric:$biometric_version"

Scenario 1:
- No biometric or device credentials (PIN, pattern, password) configured
- Biometric prompt not showing
- Activity is not responding (can't tap on button or textfields)

Scenario 2:
- Device credential configured (Pattern)
- Biometric prompt showing pattern authentication
- Tap on Cancel
- Activity is not responding (can't tap on button or textfields)

I can see in the logs "Authentication canceled by user" for both scenario
When fingerprint is configured ans prompt ask for fingerprint if I cancel the activity is responding
It occurs only for device credentials when setDeviceCredentialAllowed(true)

Comments

vi...@google.com <vi...@google.com> Oct 23, 2019 06:21AM

Assigned to vi...@google.com.

vi...@google.com <vi...@google.com> #2Oct 23, 2019 10:37AM

Thanks for trying out Room KMP! This looks like an issue with Android 9+ and armv7 and the way we compile sqlite3.c, specifically linking to the atomic library in C. We'll try to get this fix as soon as possible.

ma...@gmail.com <ma...@gmail.com> #3Oct 24, 2019 09:17PM

Very related: https://sqlite.org/forum/info/aa703e86823efca3, as suspected seems like a linking issue.

MyApplication.zip

14 MB

Download

video.webm

6.5 MB

Download

ma...@gmail.com <ma...@gmail.com> #4Oct 24, 2019 09:48PM

Facing the same issue here, surprisingly using the AndroidSQLiteDriver instead of the bundled one seems to work fine. So for now, others facing the crash can fix it by using the AndroidSQLiteDriver instead of the bundled one

vi...@google.com <vi...@google.com> #5Oct 25, 2019 11:11AM

Reassigned to kc...@google.com.

Project: platform/frameworks/support
Branch: androidx-main

commit cf121571aac008a756b64cda13f76ae4db3e85a6
Author: Daniel Santiago Rivera <danysantiago@google.com>
Date: Wed May 29 11:14:42 2024

Link to Android's atomic lib in bundled SQLite

Fix Bundled SQLite loading for devices with older ARM architecture by linking to Android's atomic library instead of relying on Clang's extension (c_atomic) or GCC's built-ins as used in sqlite3.c.

Also add support for passing linker args to androidx's native compilation infra.

See also discussion in

https://sqlite.org/forum/forumpost/792d76a592608d8f

Bug: 341639198
Test: Locally tested via BundledSQLiteDriverTest in a Nexus 5 on API 23
Change-Id: Ia818b7c4f1a990a1b5e35f4c7a3c89694aee0503

M buildSrc/private/src/main/kotlin/androidx/build/clang/ClangSharedLibraryTask.kt
M buildSrc/private/src/main/kotlin/androidx/build/clang/KonanBuildService.kt
M buildSrc/private/src/main/kotlin/androidx/build/clang/MultiTargetNativeCompilation.kt
M buildSrc/private/src/main/kotlin/androidx/build/clang/NativeTargetCompilation.kt
M sqlite/sqlite-bundled/build.gradle

https://android-review.googlesource.com/3108157

Message last modified on Nov 8, 2019 10:03PM

kc...@google.com <kc...@google.com> #6Oct 25, 2019 05:54PM

Reassigned to an...@google.com.

Hello, even if I updated to version androidx.sqlite:sqlite-bundled:2.5.0-alpha04 I just received a crash on a nexus 5X with android 8.1.0 and another one on Redmi Note 11 Pro with android 13.
I'm using androidx.room:room-runtime-android:2.7.0-alpha01.

This is the log:
Fatal Exception: java.lang.UnsatisfiedLinkError: dalvik.system.PathClassLoader[DexPathList[[zip file "/data/app/com.myproject-ssibkzVuLAo7tvV0puYoEg==/base.apk"],nativeLibraryDirectories=[/data/app/com.myproject-ssibkzVuLAo7tvV0puYoEg==/lib/x86, /system/lib, /vendor/lib]]] couldn't find "libsqliteJni.so"
at java.lang.Runtime.loadLibrary0(Runtime.java:1011)
at java.lang.System.loadLibrary(System.java:1657)
at androidx.sqlite.driver.bundled.NativeLibraryLoader.loadLibrary(NativeLibraryLoader.android.kt:1)
at androidx.sqlite.driver.bundled.BundledSQLiteDriver.<clinit>(BundledSQLiteDriver.jvmAndroid.kt:1)

Thank you!

cu...@google.com <cu...@google.com> #7Oct 25, 2019 09:05PM

Reassigned to cu...@google.com.

Can you try using androidx.room:room-runtime-android:2.7.0-alpha04 and confirm if the issue is still present?

cu...@google.com <cu...@google.com> Oct 28, 2019 06:21PM

Accepted by cu...@google.com.

ap...@google.com <ap...@google.com> #8Oct 28, 2019 09:27PM

Marked as fixed.

I will let you know, in alternative can I use AndroidSQLiteDriver instead of the bundled one just for the android implementation?

an...@google.com <an...@google.com> #9Nov 26, 2019 06:07PM

Ideally you could use AndroidSQLiteDriver but Room has a bug with the AndroidSQLiteDriver that is fixed in version 2.7.0-alpha05 that will be released in July 10 so I recommend that if you do switch to using AndroidSQLiteDriver wait for the alpha05 release.