Fixed
Status Update
No update yet.
Comments
cu...@google.com
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 9eedaee537945692cd37025b8b8c30848540dd71
Author: Curtis Belmonte <curtislb@google.com>
Date: Mon Oct 28 15:10:24 2019
Hide the fingerprint dialog on certain devices
The biometric library currently has a list of devices for which we show
FingerprintDialogFragment as a workaround but which have a conflicting
UI (such as an overlay) that requires the dialog to be dismissed
immediately upon receiving an error. While this is an improvement, it
would arguably be better for the fingerprint dialog not to show at all
on these affected devices. This commit makes that change, using the
preexisting list of affected device models.
Test: Biometric demo app on Galaxy S10 and Note10+
Fixes: 143230260
Change-Id: I81a43db82126cd7f594f2328e3ca9b0158c33881
M biometric/res/values/devices.xml
M biometric/src/main/java/androidx/biometric/BiometricPrompt.java
M biometric/src/main/java/androidx/biometric/FingerprintDialogFragment.java
M biometric/src/main/java/androidx/biometric/Utils.java
https://android-review.googlesource.com/1153025
https://goto.google.com/android-sha1/9eedaee537945692cd37025b8b8c30848540dd71
Branch: androidx-master-dev
commit 9eedaee537945692cd37025b8b8c30848540dd71
Author: Curtis Belmonte <curtislb@google.com>
Date: Mon Oct 28 15:10:24 2019
Hide the fingerprint dialog on certain devices
The biometric library currently has a list of devices for which we show
FingerprintDialogFragment as a workaround but which have a conflicting
UI (such as an overlay) that requires the dialog to be dismissed
immediately upon receiving an error. While this is an improvement, it
would arguably be better for the fingerprint dialog not to show at all
on these affected devices. This commit makes that change, using the
preexisting list of affected device models.
Test: Biometric demo app on Galaxy S10 and Note10+
Fixes: 143230260
Change-Id: I81a43db82126cd7f594f2328e3ca9b0158c33881
M biometric/res/values/devices.xml
M biometric/src/main/java/androidx/biometric/BiometricPrompt.java
M biometric/src/main/java/androidx/biometric/FingerprintDialogFragment.java
M biometric/src/main/java/androidx/biometric/Utils.java
Description
- A bugreport immediately after the issue occurs.
- Sample project to trigger the issue.
- A screenrecord or screenshots showing the issue (if UI related).
BUILD INFO
- Device type: Samsung S10+ (G975F)
- OS version: 9
- Biometric library version: 1.0.0-rc02
STEPS TO REPRODUCE
1. Trigger call to .authenticate()
EXPECTED RESULTS
Only one biometric dialog is shown
OBSERVED RESULTS
What looks to be the Samsung biometric dialog is shown on top of the Android biometric dialog. See attachment.
NUMBER OF TIMES YOU WERE ABLE TO REPRODUCE (e.g. 3/10)
10/10