Status Update
Comments
ap...@google.com <ap...@google.com> #2
Hi, thanks for report!
Could you attach a bit more information about the heap at this point (e.g. a heap dump) if the leak is not reproducible in trivial project?
an...@google.com <an...@google.com> #3
Attached!
an...@google.com <an...@google.com> #4
I looked into the heap dump, seems like we are not disposing certain snapshots. Current snapshot id seems to be around 42k, but we have 108, 116 and 14123 in invalid SnapshotIdSet
for current global snapshot.
It is hard to figure out what caused it without repro though, as those snapshots seem to be already collected by GC.
[Deleted User] <[Deleted User]> #5
I managed to repro it after a bunch of debugging. The bad news is that it's caused when using
Repro:
- Add
implementation io.coil-kt:coil-compose:2.1.0
to build.gradle - Add the following composable:
@Composable fun Leak() {
val lazyListState = rememberLazyListState()
val items by remember { mutableStateOf(List(10000) { it }) }
LazyColumn(state = lazyListState) {
items(items) {
Box(Modifier.fillMaxWidth()) {
AsyncImage(
model = "https://i.picsum.photos/id/104/200/200.jpg?hmac=3XxEVXVjwoI45-6sum_iMwNZ52GT-SJacVWr4fh4hqI",
contentDescription = null
)
}
}
}
}
- Scroll
- Memory 📈
[Deleted User] <[Deleted User]> #6
Branch: androidx-main
commit e82b3518094e5451dd4697f31a412c10075b28c5
Author: Andrei Shikov <ashikov@google.com>
Date: Wed Jul 20 23:43:58 2022
Dispose nested snapshots created from transparent snapshots
Adds a flag to transparent snapshots to "manage" wrapped snapshots which forces dispose of the wrapped snapshot whenever transparent one is disposed.
This flag is only enabled for the snapshots taken inside transparent snapshots, fixing memory leaks in certain conditions.
Fixes a minor bug where transparent snapshot wasn't receiving reads from nested snapshots as well.
Fixes: 239603305
Test: SnapshotTests#testNestedWithinTransparentSnapshotDisposedCorrectly
Change-Id: I62eddd279c8cf44b032d852d646c9ba21ad08a39
M compose/runtime/runtime/src/commonMain/kotlin/androidx/compose/runtime/snapshots/Snapshot.kt
M compose/runtime/runtime/src/commonTest/kotlin/androidx/compose/runtime/snapshots/SnapshotTests.kt
ib...@gmail.com <ib...@gmail.com> #7
Thanks for the quick turnaround!
sa...@gmail.com <sa...@gmail.com> #8
The following release(s) address this bug:
androidx.compose.runtime:runtime:1.3.0
sa...@gmail.com <sa...@gmail.com> #9
Condition: Turn ON the "Don't Keep Activities" option in the "Developer Options."
Description
When I tap use password I get an error from the callback "Unknown error 10" and then when I enter my PIN code or fingerprint callback is not called.
BUILD INFO
- Device type: Samsung A50
- OS version: Android 9
- Biometric library version: "androidx.biometric:biometric:1.0.0-rc02"
STEPS TO REPRODUCE
1. Face recognition enabled, face registered and set as preferred biometric
2. Fingerprint registered and enabled (required to show face recognition prompt, see
3. PIN required to unlock device
4. setDeviceCredentialAllowed(true)
5. Face recognition prompt showing, tap use password
6. Enter PIN code or fingerprint (black screen in video)
EXPECTED RESULTS
Toast showing "Authentication successful" from callback method onAuthenticationSucceeded
OBSERVED RESULTS
Toast showing error at step 5 and callback not called when entering pin code or fingerprint
NUMBER OF TIMES YOU WERE ABLE TO REPRODUCE 100%
Thank you